[v2] make system memory API available for common code

[PATCH v2 07/16] exec/exec-all: remove dependency on cpu.h

Posted by Pierrick Bouvier 3 weeks, 2 days ago

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
---
 include/exec/exec-all.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/include/exec/exec-all.h b/include/exec/exec-all.h
index dd5c40f2233..19b0eda44a7 100644
--- a/include/exec/exec-all.h
+++ b/include/exec/exec-all.h
@@ -20,7 +20,6 @@
 #ifndef EXEC_ALL_H
 #define EXEC_ALL_H
 
-#include "cpu.h"
 #if defined(CONFIG_USER_ONLY)
 #include "exec/cpu_ldst.h"
 #endif
-- 
2.39.5

Re: [PATCH v2 07/16] exec/exec-all: remove dependency on cpu.h

Posted by Philippe Mathieu-Daudé 3 weeks, 2 days ago

On 11/3/25 05:08, Pierrick Bouvier wrote:
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>

Missing the "why" justification we couldn't do that before.

> ---
>   include/exec/exec-all.h | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/include/exec/exec-all.h b/include/exec/exec-all.h
> index dd5c40f2233..19b0eda44a7 100644
> --- a/include/exec/exec-all.h
> +++ b/include/exec/exec-all.h
> @@ -20,7 +20,6 @@
>   #ifndef EXEC_ALL_H
>   #define EXEC_ALL_H
>   
> -#include "cpu.h"
>   #if defined(CONFIG_USER_ONLY)
>   #include "exec/cpu_ldst.h"
>   #endif

Re: [PATCH v2 07/16] exec/exec-all: remove dependency on cpu.h

Posted by Pierrick Bouvier 3 weeks, 1 day ago

On 3/11/25 00:26, Philippe Mathieu-Daudé wrote:
> On 11/3/25 05:08, Pierrick Bouvier wrote:
>> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
>> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
> 
> Missing the "why" justification we couldn't do that before.
> 
>> ---
>>    include/exec/exec-all.h | 1 -
>>    1 file changed, 1 deletion(-)
>>
>> diff --git a/include/exec/exec-all.h b/include/exec/exec-all.h
>> index dd5c40f2233..19b0eda44a7 100644
>> --- a/include/exec/exec-all.h
>> +++ b/include/exec/exec-all.h
>> @@ -20,7 +20,6 @@
>>    #ifndef EXEC_ALL_H
>>    #define EXEC_ALL_H
>>    
>> -#include "cpu.h"
>>    #if defined(CONFIG_USER_ONLY)
>>    #include "exec/cpu_ldst.h"
>>    #endif
> 

Previous commit is named:
codebase: prepare to remove cpu.h from exec/exec-all.h
So before those changes, it's not possible.

I can repeat that here, or squash the patches together, as you prefer.