When commit 72cdd672e18c extended the ppc64 e500 test to add network
support, it forgot to require the 'user' netdev backend. Fix that.

Fixes: 72cdd672e18c ("tests/functional: Replace the ppc64 e500 advent calendar test")
Signed-off-by: Cédric Le Goater <clg@redhat.com>
---
 tests/functional/test_ppc64_e500.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/functional/test_ppc64_e500.py b/tests/functional/test_ppc64_e500.py
index 9ce7ae6c4798..f5fcad9f6b66 100755
--- a/tests/functional/test_ppc64_e500.py
+++ b/tests/functional/test_ppc64_e500.py
@@ -20,6 +20,7 @@ class E500Test(LinuxKernelTest):
 
     def test_ppc64_e500_buildroot(self):
         self.set_machine('ppce500')
+        self.require_netdev('user')
         self.cpu = 'e5500'
 
         uimage_path = self.ASSET_BR2_E5500_UIMAGE.fetch()
-- 
2.48.1

On 08/03/2025 08.13, Cédric Le Goater wrote:
> When commit 72cdd672e18c extended the ppc64 e500 test to add network
> support, it forgot to require the 'user' netdev backend. Fix that.
> 
> Fixes: 72cdd672e18c ("tests/functional: Replace the ppc64 e500 advent calendar test")
> Signed-off-by: Cédric Le Goater <clg@redhat.com>
> ---
>   tests/functional/test_ppc64_e500.py | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/tests/functional/test_ppc64_e500.py b/tests/functional/test_ppc64_e500.py
> index 9ce7ae6c4798..f5fcad9f6b66 100755
> --- a/tests/functional/test_ppc64_e500.py
> +++ b/tests/functional/test_ppc64_e500.py
> @@ -20,6 +20,7 @@ class E500Test(LinuxKernelTest):
>   
>       def test_ppc64_e500_buildroot(self):
>           self.set_machine('ppce500')
> +        self.require_netdev('user')
>           self.cpu = 'e5500'

Thanks, that should fix the issue that I saw in the 
"functional-cfi-ppc64-s390x" job in the gitlab CI (which uses 
--disable-slirp indeed)!

Reviewed-by: Thomas Huth <thuth@redhat.com>

Am 8. März 2025 07:13:28 UTC schrieb "Cédric Le Goater" <clg@redhat.com>:
>When commit 72cdd672e18c extended the ppc64 e500 test to add network
>support, it forgot to require the 'user' netdev backend. Fix that.
>
>Fixes: 72cdd672e18c ("tests/functional: Replace the ppc64 e500 advent calendar test")
>Signed-off-by: Cédric Le Goater <clg@redhat.com>
>---
> tests/functional/test_ppc64_e500.py | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/tests/functional/test_ppc64_e500.py b/tests/functional/test_ppc64_e500.py
>index 9ce7ae6c4798..f5fcad9f6b66 100755
>--- a/tests/functional/test_ppc64_e500.py
>+++ b/tests/functional/test_ppc64_e500.py
>@@ -20,6 +20,7 @@ class E500Test(LinuxKernelTest):
> 
>     def test_ppc64_e500_buildroot(self):
>         self.set_machine('ppce500')
>+        self.require_netdev('user')
>         self.cpu = 'e5500'
> 
>         uimage_path = self.ASSET_BR2_E5500_UIMAGE.fetch()

Thanks for taking care of it, Cédric.

Acked-by: Bernhard Beschow <shentey@gmail.com>

On 8/3/25 08:13, Cédric Le Goater wrote:
> When commit 72cdd672e18c extended the ppc64 e500 test to add network
> support, it forgot to require the 'user' netdev backend. Fix that.
> 
> Fixes: 72cdd672e18c ("tests/functional: Replace the ppc64 e500 advent calendar test")
> Signed-off-by: Cédric Le Goater <clg@redhat.com>
> ---
>   tests/functional/test_ppc64_e500.py | 1 +
>   1 file changed, 1 insertion(+)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>