[v1] accel/tcg: Compile more files once

[PATCH 16/16] accel/tcg: Build tcg-runtime-gvec.c once

Posted by Richard Henderson 8 months, 1 week ago

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 accel/tcg/tcg-runtime-gvec.c | 1 -
 accel/tcg/meson.build        | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/accel/tcg/tcg-runtime-gvec.c b/accel/tcg/tcg-runtime-gvec.c
index afca89baa1..ff927c5dd8 100644
--- a/accel/tcg/tcg-runtime-gvec.c
+++ b/accel/tcg/tcg-runtime-gvec.c
@@ -19,7 +19,6 @@
 
 #include "qemu/osdep.h"
 #include "qemu/host-utils.h"
-#include "cpu.h"
 #include "exec/helper-proto-common.h"
 #include "tcg/tcg-gvec-desc.h"
 
diff --git a/accel/tcg/meson.build b/accel/tcg/meson.build
index 411fe28dea..38ff227eb0 100644
--- a/accel/tcg/meson.build
+++ b/accel/tcg/meson.build
@@ -1,13 +1,13 @@
 common_ss.add(when: 'CONFIG_TCG', if_true: files(
   'cpu-exec-common.c',
   'tcg-runtime.c',
+  'tcg-runtime-gvec.c',
 ))
 tcg_specific_ss = ss.source_set()
 tcg_specific_ss.add(files(
   'tcg-all.c',
   'cpu-exec.c',
   'tb-maint.c',
-  'tcg-runtime-gvec.c',
   'translate-all.c',
   'translator.c',
 ))
-- 
2.43.0

Re: [PATCH 16/16] accel/tcg: Build tcg-runtime-gvec.c once

Posted by Philippe Mathieu-Daudé 8 months, 1 week ago

On 7/3/25 19:56, Richard Henderson wrote:
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>   accel/tcg/tcg-runtime-gvec.c | 1 -
>   accel/tcg/meson.build        | 2 +-
>   2 files changed, 1 insertion(+), 2 deletions(-)

💞

Tested-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Re: [PATCH 16/16] accel/tcg: Build tcg-runtime-gvec.c once

Posted by Pierrick Bouvier 8 months, 1 week ago

On 3/7/25 10:56, Richard Henderson wrote:
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>   accel/tcg/tcg-runtime-gvec.c | 1 -
>   accel/tcg/meson.build        | 2 +-
>   2 files changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/accel/tcg/tcg-runtime-gvec.c b/accel/tcg/tcg-runtime-gvec.c
> index afca89baa1..ff927c5dd8 100644
> --- a/accel/tcg/tcg-runtime-gvec.c
> +++ b/accel/tcg/tcg-runtime-gvec.c
> @@ -19,7 +19,6 @@
>   
>   #include "qemu/osdep.h"
>   #include "qemu/host-utils.h"
> -#include "cpu.h"
>   #include "exec/helper-proto-common.h"
>   #include "tcg/tcg-gvec-desc.h"
>   
> diff --git a/accel/tcg/meson.build b/accel/tcg/meson.build
> index 411fe28dea..38ff227eb0 100644
> --- a/accel/tcg/meson.build
> +++ b/accel/tcg/meson.build
> @@ -1,13 +1,13 @@
>   common_ss.add(when: 'CONFIG_TCG', if_true: files(
>     'cpu-exec-common.c',
>     'tcg-runtime.c',
> +  'tcg-runtime-gvec.c',
>   ))
>   tcg_specific_ss = ss.source_set()
>   tcg_specific_ss.add(files(
>     'tcg-all.c',
>     'cpu-exec.c',
>     'tb-maint.c',
> -  'tcg-runtime-gvec.c',
>     'translate-all.c',
>     'translator.c',
>   ))

Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>