[v1] accel/tcg: Compile more files once

[PATCH 09/16] system: Build watchpoint.c once

Posted by Richard Henderson 8 months, 1 week ago

Now that watchpoint.c uses cputlb.h instead of exec-all.h,
it can be built once.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 system/meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/system/meson.build b/system/meson.build
index 4952f4b2c7..c83d80fa24 100644
--- a/system/meson.build
+++ b/system/meson.build
@@ -3,7 +3,6 @@ specific_ss.add(when: 'CONFIG_SYSTEM_ONLY', if_true: [files(
   'ioport.c',
   'memory.c',
   'physmem.c',
-  'watchpoint.c',
 )])
 
 system_ss.add(files(
@@ -24,6 +23,7 @@ system_ss.add(files(
   'runstate.c',
   'tpm-hmp-cmds.c',
   'vl.c',
+  'watchpoint.c',
 ), sdl, libpmem, libdaxctl)
 
 if have_tpm
-- 
2.43.0

Re: [PATCH 09/16] system: Build watchpoint.c once

Posted by Philippe Mathieu-Daudé 8 months, 1 week ago

On 7/3/25 19:56, Richard Henderson wrote:
> Now that watchpoint.c uses cputlb.h instead of exec-all.h,
> it can be built once.
> 
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>   system/meson.build | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Tested-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

❤️‍🩹

Re: [PATCH 09/16] system: Build watchpoint.c once

Posted by Pierrick Bouvier 8 months, 1 week ago

On 3/7/25 10:56, Richard Henderson wrote:
> Now that watchpoint.c uses cputlb.h instead of exec-all.h,
> it can be built once.
> 
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>   system/meson.build | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/system/meson.build b/system/meson.build
> index 4952f4b2c7..c83d80fa24 100644
> --- a/system/meson.build
> +++ b/system/meson.build
> @@ -3,7 +3,6 @@ specific_ss.add(when: 'CONFIG_SYSTEM_ONLY', if_true: [files(
>     'ioport.c',
>     'memory.c',
>     'physmem.c',
> -  'watchpoint.c',
>   )])
>   
>   system_ss.add(files(
> @@ -24,6 +23,7 @@ system_ss.add(files(
>     'runstate.c',
>     'tpm-hmp-cmds.c',
>     'vl.c',
> +  'watchpoint.c',
>   ), sdl, libpmem, libdaxctl)
>   
>   if have_tpm

Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>