1. Patchew
  2. QEMU
  3. View series

[PATCH] docs/devel/build-environment: enhance MSYS2 instructions

Pierrick Bouvier posted 1 patch 11 months, 1 week ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20250305213853.3685771-1-pierrick.bouvier@linaro.org
Maintainers: "Alex Bennée" <alex.bennee@linaro.org>, "Daniel P. Berrangé" <berrange@redhat.com>, Thomas Huth <thuth@redhat.com>, Markus Armbruster <armbru@redhat.com>, "Philippe Mathieu-Daudé" <philmd@linaro.org>
There is a newer version of this series
docs/devel/build-environment.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[PATCH] docs/devel/build-environment: enhance MSYS2 instructions
Posted by Pierrick Bouvier 11 months, 1 week ago 
Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
---
 docs/devel/build-environment.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/docs/devel/build-environment.rst b/docs/devel/build-environment.rst
index f133ef2e012..661f6ea8504 100644
--- a/docs/devel/build-environment.rst
+++ b/docs/devel/build-environment.rst
@@ -97,11 +97,11 @@ build QEMU in MSYS2 itself.
 
 ::
 
-    pacman -S wget
+    pacman -S wget base-devel git
     wget https://raw.githubusercontent.com/msys2/MINGW-packages/refs/heads/master/mingw-w64-qemu/PKGBUILD
     # Some packages may be missing for your environment, installation will still
     # be done though.
-    makepkg -s PKGBUILD || true
+    makepkg --syncdeps --nobuild PKGBUILD || true
 
 Build on windows-aarch64
 ++++++++++++++++++++++++
-- 
2.39.5
Re: [PATCH] docs/devel/build-environment: enhance MSYS2 instructions
Posted by Daniel P. Berrangé 9 months, 2 weeks ago 
On Wed, Mar 05, 2025 at 01:38:53PM -0800, Pierrick Bouvier wrote:

The commit message really ought to explain why '--syncdeps --nobuild'
is improving on the current '-s'

> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
> ---
>  docs/devel/build-environment.rst | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/docs/devel/build-environment.rst b/docs/devel/build-environment.rst
> index f133ef2e012..661f6ea8504 100644
> --- a/docs/devel/build-environment.rst
> +++ b/docs/devel/build-environment.rst
> @@ -97,11 +97,11 @@ build QEMU in MSYS2 itself.
>  
>  ::
>  
> -    pacman -S wget
> +    pacman -S wget base-devel git
>      wget https://raw.githubusercontent.com/msys2/MINGW-packages/refs/heads/master/mingw-w64-qemu/PKGBUILD
>      # Some packages may be missing for your environment, installation will still
>      # be done though.
> -    makepkg -s PKGBUILD || true
> +    makepkg --syncdeps --nobuild PKGBUILD || true
>  
>  Build on windows-aarch64
>  ++++++++++++++++++++++++
> -- 
> 2.39.5
> 

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
Re: [PATCH] docs/devel/build-environment: enhance MSYS2 instructions
Posted by Philippe Mathieu-Daudé 10 months, 3 weeks ago 
Cc'ing Stefan and Yonggang

On 5/3/25 22:38, Pierrick Bouvier wrote:
> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
> ---
>   docs/devel/build-environment.rst | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/docs/devel/build-environment.rst b/docs/devel/build-environment.rst
> index f133ef2e012..661f6ea8504 100644
> --- a/docs/devel/build-environment.rst
> +++ b/docs/devel/build-environment.rst
> @@ -97,11 +97,11 @@ build QEMU in MSYS2 itself.
>   
>   ::
>   
> -    pacman -S wget
> +    pacman -S wget base-devel git
>       wget https://raw.githubusercontent.com/msys2/MINGW-packages/refs/heads/master/mingw-w64-qemu/PKGBUILD
>       # Some packages may be missing for your environment, installation will still
>       # be done though.
> -    makepkg -s PKGBUILD || true
> +    makepkg --syncdeps --nobuild PKGBUILD || true
>   
>   Build on windows-aarch64
>   ++++++++++++++++++++++++
Re: [PATCH] docs/devel/build-environment: enhance MSYS2 instructions
Posted by Pierrick Bouvier 10 months, 3 weeks ago 
On 3/5/25 13:38, Pierrick Bouvier wrote:
> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
> ---
>   docs/devel/build-environment.rst | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/docs/devel/build-environment.rst b/docs/devel/build-environment.rst
> index f133ef2e012..661f6ea8504 100644
> --- a/docs/devel/build-environment.rst
> +++ b/docs/devel/build-environment.rst
> @@ -97,11 +97,11 @@ build QEMU in MSYS2 itself.
>   
>   ::
>   
> -    pacman -S wget
> +    pacman -S wget base-devel git
>       wget https://raw.githubusercontent.com/msys2/MINGW-packages/refs/heads/master/mingw-w64-qemu/PKGBUILD
>       # Some packages may be missing for your environment, installation will still
>       # be done though.
> -    makepkg -s PKGBUILD || true
> +    makepkg --syncdeps --nobuild PKGBUILD || true
>   
>   Build on windows-aarch64
>   ++++++++++++++++++++++++

Gentle ping on this trivial change for doc.

Thanks,
Pierrick
Re: [PATCH] docs/devel/build-environment: enhance MSYS2 instructions
Posted by Pierrick Bouvier 9 months, 2 weeks ago 
On 3/24/25 10:47 AM, Pierrick Bouvier wrote:
> On 3/5/25 13:38, Pierrick Bouvier wrote:
>> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
>> ---
>>    docs/devel/build-environment.rst | 4 ++--
>>    1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/docs/devel/build-environment.rst b/docs/devel/build-environment.rst
>> index f133ef2e012..661f6ea8504 100644
>> --- a/docs/devel/build-environment.rst
>> +++ b/docs/devel/build-environment.rst
>> @@ -97,11 +97,11 @@ build QEMU in MSYS2 itself.
>>    
>>    ::
>>    
>> -    pacman -S wget
>> +    pacman -S wget base-devel git
>>        wget https://raw.githubusercontent.com/msys2/MINGW-packages/refs/heads/master/mingw-w64-qemu/PKGBUILD
>>        # Some packages may be missing for your environment, installation will still
>>        # be done though.
>> -    makepkg -s PKGBUILD || true
>> +    makepkg --syncdeps --nobuild PKGBUILD || true
>>    
>>    Build on windows-aarch64
>>    ++++++++++++++++++++++++
> 
> Gentle ping on this trivial change for doc.
>

Another gentle ping on this trivial doc change.
Re: [PATCH] docs/devel/build-environment: enhance MSYS2 instructions
Posted by Thomas Huth 9 months, 2 weeks ago 
On 28/04/2025 21.35, Pierrick Bouvier wrote:
> On 3/24/25 10:47 AM, Pierrick Bouvier wrote:
>> On 3/5/25 13:38, Pierrick Bouvier wrote:
>>> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
>>> ---
>>>    docs/devel/build-environment.rst | 4 ++--
>>>    1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/docs/devel/build-environment.rst b/docs/devel/build- 
>>> environment.rst
>>> index f133ef2e012..661f6ea8504 100644
>>> --- a/docs/devel/build-environment.rst
>>> +++ b/docs/devel/build-environment.rst
>>> @@ -97,11 +97,11 @@ build QEMU in MSYS2 itself.
>>>    ::
>>> -    pacman -S wget
>>> +    pacman -S wget base-devel git
>>>        wget https://raw.githubusercontent.com/msys2/MINGW-packages/refs/ 
>>> heads/master/mingw-w64-qemu/PKGBUILD
>>>        # Some packages may be missing for your environment, installation 
>>> will still
>>>        # be done though.
>>> -    makepkg -s PKGBUILD || true
>>> +    makepkg --syncdeps --nobuild PKGBUILD || true
>>>    Build on windows-aarch64
>>>    ++++++++++++++++++++++++
>>
>> Gentle ping on this trivial change for doc.
>>
> 
> Another gentle ping on this trivial doc change.

Not really my turf, I don't have much clue about the MSYS2 environment, but 
since there were no objections, I can add it to my next PR.

  Thomas
Re: [PATCH] docs/devel/build-environment: enhance MSYS2 instructions
Posted by Pierrick Bouvier 9 months, 2 weeks ago 
On 4/30/25 3:09 AM, Thomas Huth wrote:
> On 28/04/2025 21.35, Pierrick Bouvier wrote:
>> On 3/24/25 10:47 AM, Pierrick Bouvier wrote:
>>> On 3/5/25 13:38, Pierrick Bouvier wrote:
>>>> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
>>>> ---
>>>>     docs/devel/build-environment.rst | 4 ++--
>>>>     1 file changed, 2 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/docs/devel/build-environment.rst b/docs/devel/build-
>>>> environment.rst
>>>> index f133ef2e012..661f6ea8504 100644
>>>> --- a/docs/devel/build-environment.rst
>>>> +++ b/docs/devel/build-environment.rst
>>>> @@ -97,11 +97,11 @@ build QEMU in MSYS2 itself.
>>>>     ::
>>>> -    pacman -S wget
>>>> +    pacman -S wget base-devel git
>>>>         wget https://raw.githubusercontent.com/msys2/MINGW-packages/refs/
>>>> heads/master/mingw-w64-qemu/PKGBUILD
>>>>         # Some packages may be missing for your environment, installation
>>>> will still
>>>>         # be done though.
>>>> -    makepkg -s PKGBUILD || true
>>>> +    makepkg --syncdeps --nobuild PKGBUILD || true
>>>>     Build on windows-aarch64
>>>>     ++++++++++++++++++++++++
>>>
>>> Gentle ping on this trivial change for doc.
>>>
>>
>> Another gentle ping on this trivial doc change.
> 
> Not really my turf, I don't have much clue about the MSYS2 environment, but
> since there were no objections, I can add it to my next PR.
>

Thank you, that's appreciated.

>    Thomas
>
Re: [PATCH] docs/devel/build-environment: enhance MSYS2 instructions
Posted by Thomas Huth 9 months, 2 weeks ago 
On 30/04/2025 16.34, Pierrick Bouvier wrote:
> On 4/30/25 3:09 AM, Thomas Huth wrote:
>> On 28/04/2025 21.35, Pierrick Bouvier wrote:
>>> On 3/24/25 10:47 AM, Pierrick Bouvier wrote:
>>>> On 3/5/25 13:38, Pierrick Bouvier wrote:
>>>>> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
>>>>> ---
>>>>>     docs/devel/build-environment.rst | 4 ++--
>>>>>     1 file changed, 2 insertions(+), 2 deletions(-)
>>>>>
>>>>> diff --git a/docs/devel/build-environment.rst b/docs/devel/build-
>>>>> environment.rst
>>>>> index f133ef2e012..661f6ea8504 100644
>>>>> --- a/docs/devel/build-environment.rst
>>>>> +++ b/docs/devel/build-environment.rst
>>>>> @@ -97,11 +97,11 @@ build QEMU in MSYS2 itself.
>>>>>     ::
>>>>> -    pacman -S wget
>>>>> +    pacman -S wget base-devel git
>>>>>         wget https://raw.githubusercontent.com/msys2/MINGW-packages/refs/
>>>>> heads/master/mingw-w64-qemu/PKGBUILD
>>>>>         # Some packages may be missing for your environment, installation
>>>>> will still
>>>>>         # be done though.
>>>>> -    makepkg -s PKGBUILD || true
>>>>> +    makepkg --syncdeps --nobuild PKGBUILD || true
>>>>>     Build on windows-aarch64
>>>>>     ++++++++++++++++++++++++
>>>>
>>>> Gentle ping on this trivial change for doc.
>>>>
>>>
>>> Another gentle ping on this trivial doc change.
>>
>> Not really my turf, I don't have much clue about the MSYS2 environment, but
>> since there were no objections, I can add it to my next PR.
>>
> 
> Thank you, that's appreciated.

Could you still please provide a proper patch description, as Daniel suggested?

  Thanks,
   Thomas
Re: [PATCH] docs/devel/build-environment: enhance MSYS2 instructions
Posted by Pierrick Bouvier 9 months, 2 weeks ago 
On 4/30/25 10:54 AM, Thomas Huth wrote:
> On 30/04/2025 16.34, Pierrick Bouvier wrote:
>> On 4/30/25 3:09 AM, Thomas Huth wrote:
>>> On 28/04/2025 21.35, Pierrick Bouvier wrote:
>>>> On 3/24/25 10:47 AM, Pierrick Bouvier wrote:
>>>>> On 3/5/25 13:38, Pierrick Bouvier wrote:
>>>>>> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
>>>>>> ---
>>>>>>      docs/devel/build-environment.rst | 4 ++--
>>>>>>      1 file changed, 2 insertions(+), 2 deletions(-)
>>>>>>
>>>>>> diff --git a/docs/devel/build-environment.rst b/docs/devel/build-
>>>>>> environment.rst
>>>>>> index f133ef2e012..661f6ea8504 100644
>>>>>> --- a/docs/devel/build-environment.rst
>>>>>> +++ b/docs/devel/build-environment.rst
>>>>>> @@ -97,11 +97,11 @@ build QEMU in MSYS2 itself.
>>>>>>      ::
>>>>>> -    pacman -S wget
>>>>>> +    pacman -S wget base-devel git
>>>>>>          wget https://raw.githubusercontent.com/msys2/MINGW-packages/refs/
>>>>>> heads/master/mingw-w64-qemu/PKGBUILD
>>>>>>          # Some packages may be missing for your environment, installation
>>>>>> will still
>>>>>>          # be done though.
>>>>>> -    makepkg -s PKGBUILD || true
>>>>>> +    makepkg --syncdeps --nobuild PKGBUILD || true
>>>>>>      Build on windows-aarch64
>>>>>>      ++++++++++++++++++++++++
>>>>>
>>>>> Gentle ping on this trivial change for doc.
>>>>>
>>>>
>>>> Another gentle ping on this trivial doc change.
>>>
>>> Not really my turf, I don't have much clue about the MSYS2 environment, but
>>> since there were no objections, I can add it to my next PR.
>>>
>>
>> Thank you, that's appreciated.
> 
> Could you still please provide a proper patch description, as Daniel suggested?
>

Sure.
I just sent v2: 20250430181047.2043492-1-pierrick.bouvier@linaro.org

>    Thanks,
>     Thomas
> 

Thanks,
Pierrick

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.