hw/microblaze: Quick single binary proof of concept

[RFC PATCH 01/18] hw/xen/hvm: Fix Aarch64 typo

Posted by Philippe Mathieu-Daudé 3 weeks, 6 days ago

There is no TARGET_ARM_64 definition. Luckily enough,
when TARGET_AARCH64 is defined, TARGET_ARM also is.

Fixes: 733766cd373 ("hw/arm: introduce xenpvh machine")
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 include/hw/xen/arch_hvm.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/hw/xen/arch_hvm.h b/include/hw/xen/arch_hvm.h
index c7c515220d2..df39c819c8f 100644
--- a/include/hw/xen/arch_hvm.h
+++ b/include/hw/xen/arch_hvm.h
@@ -1,5 +1,5 @@
 #if defined(TARGET_I386) || defined(TARGET_X86_64)
 #include "hw/i386/xen_arch_hvm.h"
-#elif defined(TARGET_ARM) || defined(TARGET_ARM_64)
+#elif defined(TARGET_ARM) || defined(TARGET_AARCH64)
 #include "hw/arm/xen_arch_hvm.h"
 #endif
-- 
2.47.1

Re: [RFC PATCH 01/18] hw/xen/hvm: Fix Aarch64 typo

Posted by Michael Tokarev 2 weeks, 6 days ago

05.03.2025 18:39, Philippe Mathieu-Daudé wrote:
> There is no TARGET_ARM_64 definition. Luckily enough,
> when TARGET_AARCH64 is defined, TARGET_ARM also is.
> 
> Fixes: 733766cd373 ("hw/arm: introduce xenpvh machine")
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   include/hw/xen/arch_hvm.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/hw/xen/arch_hvm.h b/include/hw/xen/arch_hvm.h
> index c7c515220d2..df39c819c8f 100644
> --- a/include/hw/xen/arch_hvm.h
> +++ b/include/hw/xen/arch_hvm.h
> @@ -1,5 +1,5 @@
>   #if defined(TARGET_I386) || defined(TARGET_X86_64)
>   #include "hw/i386/xen_arch_hvm.h"
> -#elif defined(TARGET_ARM) || defined(TARGET_ARM_64)
> +#elif defined(TARGET_ARM) || defined(TARGET_AARCH64)
>   #include "hw/arm/xen_arch_hvm.h"
>   #endif

This is a no-difference change, but I'm picking this up for
qemu-stable - just to remove a wrong code example for possible
copy-paste errors :)

FWIW,

/mjt

Re: [RFC PATCH 01/18] hw/xen/hvm: Fix Aarch64 typo

Posted by Philippe Mathieu-Daudé 2 weeks, 6 days ago

On 13/3/25 09:10, Michael Tokarev wrote:
> 05.03.2025 18:39, Philippe Mathieu-Daudé wrote:
>> There is no TARGET_ARM_64 definition. Luckily enough,
>> when TARGET_AARCH64 is defined, TARGET_ARM also is.
>>
>> Fixes: 733766cd373 ("hw/arm: introduce xenpvh machine")
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>> ---
>>   include/hw/xen/arch_hvm.h | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/hw/xen/arch_hvm.h b/include/hw/xen/arch_hvm.h
>> index c7c515220d2..df39c819c8f 100644
>> --- a/include/hw/xen/arch_hvm.h
>> +++ b/include/hw/xen/arch_hvm.h
>> @@ -1,5 +1,5 @@
>>   #if defined(TARGET_I386) || defined(TARGET_X86_64)
>>   #include "hw/i386/xen_arch_hvm.h"
>> -#elif defined(TARGET_ARM) || defined(TARGET_ARM_64)
>> +#elif defined(TARGET_ARM) || defined(TARGET_AARCH64)
>>   #include "hw/arm/xen_arch_hvm.h"
>>   #endif
> 
> This is a no-difference change, but I'm picking this up for
> qemu-stable - just to remove a wrong code example for possible
> copy-paste errors :)

Good idea, thank you!

Re: [RFC PATCH 01/18] hw/xen/hvm: Fix Aarch64 typo

Posted by Richard Henderson 3 weeks, 6 days ago

On 3/5/25 07:39, Philippe Mathieu-Daudé wrote:
> There is no TARGET_ARM_64 definition. Luckily enough,
> when TARGET_AARCH64 is defined, TARGET_ARM also is.
> 
> Fixes: 733766cd373 ("hw/arm: introduce xenpvh machine")
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   include/hw/xen/arch_hvm.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~

> 
> diff --git a/include/hw/xen/arch_hvm.h b/include/hw/xen/arch_hvm.h
> index c7c515220d2..df39c819c8f 100644
> --- a/include/hw/xen/arch_hvm.h
> +++ b/include/hw/xen/arch_hvm.h
> @@ -1,5 +1,5 @@
>   #if defined(TARGET_I386) || defined(TARGET_X86_64)
>   #include "hw/i386/xen_arch_hvm.h"
> -#elif defined(TARGET_ARM) || defined(TARGET_ARM_64)
> +#elif defined(TARGET_ARM) || defined(TARGET_AARCH64)
>   #include "hw/arm/xen_arch_hvm.h"
>   #endif

Re: [RFC PATCH 01/18] hw/xen/hvm: Fix Aarch64 typo

Posted by Pierrick Bouvier 3 weeks, 6 days ago

On 3/5/25 07:39, Philippe Mathieu-Daudé wrote:
> There is no TARGET_ARM_64 definition. Luckily enough,
> when TARGET_AARCH64 is defined, TARGET_ARM also is.
> 
> Fixes: 733766cd373 ("hw/arm: introduce xenpvh machine")
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   include/hw/xen/arch_hvm.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/hw/xen/arch_hvm.h b/include/hw/xen/arch_hvm.h
> index c7c515220d2..df39c819c8f 100644
> --- a/include/hw/xen/arch_hvm.h
> +++ b/include/hw/xen/arch_hvm.h
> @@ -1,5 +1,5 @@
>   #if defined(TARGET_I386) || defined(TARGET_X86_64)
>   #include "hw/i386/xen_arch_hvm.h"
> -#elif defined(TARGET_ARM) || defined(TARGET_ARM_64)
> +#elif defined(TARGET_ARM) || defined(TARGET_AARCH64)
>   #include "hw/arm/xen_arch_hvm.h"
>   #endif

Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>