[PATCH v2 30/32] plugins/core: make a single build unit

Alex Bennée posted 32 patches 4 weeks ago
[PATCH v2 30/32] plugins/core: make a single build unit
Posted by Alex Bennée 4 weeks ago
Trim through the includes and remove everything not needed for the
core. Only include tcg-op-common.h to remove the need to
TARGET_LONG_BITS and move the build unit into the common set.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 plugins/core.c      | 10 +---------
 plugins/meson.build |  5 +----
 2 files changed, 2 insertions(+), 13 deletions(-)

diff --git a/plugins/core.c b/plugins/core.c
index bb105e8e68..eb9281fe54 100644
--- a/plugins/core.c
+++ b/plugins/core.c
@@ -12,22 +12,14 @@
  * SPDX-License-Identifier: GPL-2.0-or-later
  */
 #include "qemu/osdep.h"
-#include "qemu/error-report.h"
-#include "qemu/config-file.h"
-#include "qapi/error.h"
 #include "qemu/lockable.h"
 #include "qemu/option.h"
 #include "qemu/plugin.h"
 #include "qemu/queue.h"
 #include "qemu/rcu_queue.h"
-#include "qemu/xxhash.h"
 #include "qemu/rcu.h"
-#include "hw/core/cpu.h"
-
-#include "exec/exec-all.h"
 #include "exec/tb-flush.h"
-#include "tcg/tcg.h"
-#include "tcg/tcg-op.h"
+#include "tcg/tcg-op-common.h"
 #include "plugin.h"
 
 struct qemu_plugin_cb {
diff --git a/plugins/meson.build b/plugins/meson.build
index d27220d5ff..3be8245a69 100644
--- a/plugins/meson.build
+++ b/plugins/meson.build
@@ -61,8 +61,5 @@ endif
 user_ss.add(files('user.c', 'api-user.c'))
 system_ss.add(files('system.c', 'api-system.c'))
 
-common_ss.add(files('loader.c', 'api.c'))
+common_ss.add(files('loader.c', 'api.c', 'core.c'))
 
-specific_ss.add(files(
-  'core.c',
-))
-- 
2.39.5


Re: [PATCH v2 30/32] plugins/core: make a single build unit
Posted by Richard Henderson 4 weeks ago
On 3/4/25 14:24, Alex Bennée wrote:
> Trim through the includes and remove everything not needed for the
> core. Only include tcg-op-common.h to remove the need to
> TARGET_LONG_BITS and move the build unit into the common set.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>   plugins/core.c      | 10 +---------
>   plugins/meson.build |  5 +----
>   2 files changed, 2 insertions(+), 13 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~