1. Patchew
  2. QEMU
  3. View series

[PATCH 0/6] Add bios-tables-test for LoongArch64 system

Bibo Mao posted 6 patches 11 months, 2 weeks ago
Only 5 patches received!
tests/data/acpi/loongarch64/virt/APIC         | Bin 0 -> 108 bytes
.../data/acpi/loongarch64/virt/APIC.topology  | Bin 0 -> 213 bytes
tests/data/acpi/loongarch64/virt/DSDT         | Bin 0 -> 3614 bytes
tests/data/acpi/loongarch64/virt/DSDT.memhp   | Bin 0 -> 4951 bytes
tests/data/acpi/loongarch64/virt/FACP         | Bin 0 -> 268 bytes
tests/data/acpi/loongarch64/virt/MCFG         | Bin 0 -> 60 bytes
tests/data/acpi/loongarch64/virt/PPTT         | Bin 0 -> 76 bytes
.../data/acpi/loongarch64/virt/PPTT.topology  | Bin 0 -> 296 bytes
tests/data/acpi/loongarch64/virt/SLIT         |   0
tests/data/acpi/loongarch64/virt/SLIT.memhp   | Bin 0 -> 48 bytes
tests/data/acpi/loongarch64/virt/SPCR         | Bin 0 -> 80 bytes
tests/data/acpi/loongarch64/virt/SRAT         | Bin 0 -> 104 bytes
tests/data/acpi/loongarch64/virt/SRAT.memhp   | Bin 0 -> 184 bytes
.../data/acpi/loongarch64/virt/SRAT.topology  | Bin 0 -> 216 bytes
.../bios-tables-test.loongarch64.iso.qcow2    | Bin 0 -> 12800 bytes
tests/qtest/bios-tables-test.c                |  62 ++++++++++++++++++
tests/qtest/meson.build                       |   3 +-
tests/uefi-test-tools/Makefile                |   5 +-
.../UefiTestToolsPkg/UefiTestToolsPkg.dsc     |   6 +-
tests/uefi-test-tools/uefi-test-build.config  |  10 +++
20 files changed, 82 insertions(+), 4 deletions(-)
create mode 100644 tests/data/acpi/loongarch64/virt/APIC
create mode 100644 tests/data/acpi/loongarch64/virt/APIC.topology
create mode 100644 tests/data/acpi/loongarch64/virt/DSDT
create mode 100644 tests/data/acpi/loongarch64/virt/DSDT.memhp
create mode 100644 tests/data/acpi/loongarch64/virt/FACP
create mode 100644 tests/data/acpi/loongarch64/virt/MCFG
create mode 100644 tests/data/acpi/loongarch64/virt/PPTT
create mode 100644 tests/data/acpi/loongarch64/virt/PPTT.topology
create mode 100644 tests/data/acpi/loongarch64/virt/SLIT
create mode 100644 tests/data/acpi/loongarch64/virt/SLIT.memhp
create mode 100644 tests/data/acpi/loongarch64/virt/SPCR
create mode 100644 tests/data/acpi/loongarch64/virt/SRAT
create mode 100644 tests/data/acpi/loongarch64/virt/SRAT.memhp
create mode 100644 tests/data/acpi/loongarch64/virt/SRAT.topology
create mode 100644 tests/data/uefi-boot-images/bios-tables-test.loongarch64.iso.qcow2
[PATCH 0/6] Add bios-tables-test for LoongArch64 system
Posted by Bibo Mao 11 months, 2 weeks ago 
This patchset add bios-tables-test for LoongArch64 virt machine
system. It works with UEFI bios, with uefi-test-tools LoongArch64
support is added to build bios-tables-test.loongarch64.iso.

Also with test case bios-tables-test, LoongArch64 support is added
and some basic ACPI tables is added here. It passes with command
make check-qtest-loongarch64 with the result:
 qtest-loongarch64/bios-tables-test OK 29.52s 4 subtests passed

Bibo Mao (6):
  uefi-test-tools:: Add LoongArch64 support
  tests/data/uefi-boot-images: Add ISO image for LoongArch system
  tests/qtest/bios-tables-test: Add basic testing for LoongArch64
  tests/acpi: Add empty ACPI data files for LoongArch64
  tests/acpi: Fill acpi table data for LoongArch
  tests/qtest: Enable bios-tables-test for LoongArch

 tests/data/acpi/loongarch64/virt/APIC         | Bin 0 -> 108 bytes
 .../data/acpi/loongarch64/virt/APIC.topology  | Bin 0 -> 213 bytes
 tests/data/acpi/loongarch64/virt/DSDT         | Bin 0 -> 3614 bytes
 tests/data/acpi/loongarch64/virt/DSDT.memhp   | Bin 0 -> 4951 bytes
 tests/data/acpi/loongarch64/virt/FACP         | Bin 0 -> 268 bytes
 tests/data/acpi/loongarch64/virt/MCFG         | Bin 0 -> 60 bytes
 tests/data/acpi/loongarch64/virt/PPTT         | Bin 0 -> 76 bytes
 .../data/acpi/loongarch64/virt/PPTT.topology  | Bin 0 -> 296 bytes
 tests/data/acpi/loongarch64/virt/SLIT         |   0
 tests/data/acpi/loongarch64/virt/SLIT.memhp   | Bin 0 -> 48 bytes
 tests/data/acpi/loongarch64/virt/SPCR         | Bin 0 -> 80 bytes
 tests/data/acpi/loongarch64/virt/SRAT         | Bin 0 -> 104 bytes
 tests/data/acpi/loongarch64/virt/SRAT.memhp   | Bin 0 -> 184 bytes
 .../data/acpi/loongarch64/virt/SRAT.topology  | Bin 0 -> 216 bytes
 .../bios-tables-test.loongarch64.iso.qcow2    | Bin 0 -> 12800 bytes
 tests/qtest/bios-tables-test.c                |  62 ++++++++++++++++++
 tests/qtest/meson.build                       |   3 +-
 tests/uefi-test-tools/Makefile                |   5 +-
 .../UefiTestToolsPkg/UefiTestToolsPkg.dsc     |   6 +-
 tests/uefi-test-tools/uefi-test-build.config  |  10 +++
 20 files changed, 82 insertions(+), 4 deletions(-)
 create mode 100644 tests/data/acpi/loongarch64/virt/APIC
 create mode 100644 tests/data/acpi/loongarch64/virt/APIC.topology
 create mode 100644 tests/data/acpi/loongarch64/virt/DSDT
 create mode 100644 tests/data/acpi/loongarch64/virt/DSDT.memhp
 create mode 100644 tests/data/acpi/loongarch64/virt/FACP
 create mode 100644 tests/data/acpi/loongarch64/virt/MCFG
 create mode 100644 tests/data/acpi/loongarch64/virt/PPTT
 create mode 100644 tests/data/acpi/loongarch64/virt/PPTT.topology
 create mode 100644 tests/data/acpi/loongarch64/virt/SLIT
 create mode 100644 tests/data/acpi/loongarch64/virt/SLIT.memhp
 create mode 100644 tests/data/acpi/loongarch64/virt/SPCR
 create mode 100644 tests/data/acpi/loongarch64/virt/SRAT
 create mode 100644 tests/data/acpi/loongarch64/virt/SRAT.memhp
 create mode 100644 tests/data/acpi/loongarch64/virt/SRAT.topology
 create mode 100644 tests/data/uefi-boot-images/bios-tables-test.loongarch64.iso.qcow2


base-commit: b69801dd6b1eb4d107f7c2f643adf0a4e3ec9124
-- 
2.39.3
Re: [PATCH 0/6] Add bios-tables-test for LoongArch64 system
Posted by Gerd Hoffmann 11 months, 2 weeks ago 
On Fri, Feb 28, 2025 at 05:27:23PM +0800, Bibo Mao wrote:
> This patchset add bios-tables-test for LoongArch64 virt machine
> system. It works with UEFI bios, with uefi-test-tools LoongArch64
> support is added to build bios-tables-test.loongarch64.iso.
> 
> Also with test case bios-tables-test, LoongArch64 support is added
> and some basic ACPI tables is added here. It passes with command
> make check-qtest-loongarch64 with the result:
>  qtest-loongarch64/bios-tables-test OK 29.52s 4 subtests passed

UEFI bits look good to me.

Acked-by: Gerd Hoffmann <kraxel@redhat.com>

take care,
  Gerd
Re: [PATCH 0/6] Add bios-tables-test for LoongArch64 system
Posted by Igor Mammedov 10 months, 1 week ago 
On Fri, 28 Feb 2025 17:27:23 +0800
Bibo Mao <maobibo@loongson.cn> wrote:

> This patchset add bios-tables-test for LoongArch64 virt machine
> system. It works with UEFI bios, with uefi-test-tools LoongArch64
> support is added to build bios-tables-test.loongarch64.iso.
> 
> Also with test case bios-tables-test, LoongArch64 support is added
> and some basic ACPI tables is added here. It passes with command
> make check-qtest-loongarch64 with the result:
>  qtest-loongarch64/bios-tables-test OK 29.52s 4 subtests passed
> 
> Bibo Mao (6):
>   uefi-test-tools:: Add LoongArch64 support
>   tests/data/uefi-boot-images: Add ISO image for LoongArch system
>   tests/qtest/bios-tables-test: Add basic testing for LoongArch64
>   tests/acpi: Add empty ACPI data files for LoongArch64
>   tests/acpi: Fill acpi table data for LoongArch

blobs no longer match (since cpu hotplug was merged after this series)
so blobs need to be updated and series needs to be re-spun

>   tests/qtest: Enable bios-tables-test for LoongArch
> 
>  tests/data/acpi/loongarch64/virt/APIC         | Bin 0 -> 108 bytes
>  .../data/acpi/loongarch64/virt/APIC.topology  | Bin 0 -> 213 bytes
>  tests/data/acpi/loongarch64/virt/DSDT         | Bin 0 -> 3614 bytes
>  tests/data/acpi/loongarch64/virt/DSDT.memhp   | Bin 0 -> 4951 bytes
>  tests/data/acpi/loongarch64/virt/FACP         | Bin 0 -> 268 bytes
>  tests/data/acpi/loongarch64/virt/MCFG         | Bin 0 -> 60 bytes
>  tests/data/acpi/loongarch64/virt/PPTT         | Bin 0 -> 76 bytes
>  .../data/acpi/loongarch64/virt/PPTT.topology  | Bin 0 -> 296 bytes
>  tests/data/acpi/loongarch64/virt/SLIT         |   0
>  tests/data/acpi/loongarch64/virt/SLIT.memhp   | Bin 0 -> 48 bytes
>  tests/data/acpi/loongarch64/virt/SPCR         | Bin 0 -> 80 bytes
>  tests/data/acpi/loongarch64/virt/SRAT         | Bin 0 -> 104 bytes
>  tests/data/acpi/loongarch64/virt/SRAT.memhp   | Bin 0 -> 184 bytes
>  .../data/acpi/loongarch64/virt/SRAT.topology  | Bin 0 -> 216 bytes
>  .../bios-tables-test.loongarch64.iso.qcow2    | Bin 0 -> 12800 bytes
>  tests/qtest/bios-tables-test.c                |  62 ++++++++++++++++++
>  tests/qtest/meson.build                       |   3 +-
>  tests/uefi-test-tools/Makefile                |   5 +-
>  .../UefiTestToolsPkg/UefiTestToolsPkg.dsc     |   6 +-
>  tests/uefi-test-tools/uefi-test-build.config  |  10 +++
>  20 files changed, 82 insertions(+), 4 deletions(-)
>  create mode 100644 tests/data/acpi/loongarch64/virt/APIC
>  create mode 100644 tests/data/acpi/loongarch64/virt/APIC.topology
>  create mode 100644 tests/data/acpi/loongarch64/virt/DSDT
>  create mode 100644 tests/data/acpi/loongarch64/virt/DSDT.memhp
>  create mode 100644 tests/data/acpi/loongarch64/virt/FACP
>  create mode 100644 tests/data/acpi/loongarch64/virt/MCFG
>  create mode 100644 tests/data/acpi/loongarch64/virt/PPTT
>  create mode 100644 tests/data/acpi/loongarch64/virt/PPTT.topology
>  create mode 100644 tests/data/acpi/loongarch64/virt/SLIT
>  create mode 100644 tests/data/acpi/loongarch64/virt/SLIT.memhp
>  create mode 100644 tests/data/acpi/loongarch64/virt/SPCR
>  create mode 100644 tests/data/acpi/loongarch64/virt/SRAT
>  create mode 100644 tests/data/acpi/loongarch64/virt/SRAT.memhp
>  create mode 100644 tests/data/acpi/loongarch64/virt/SRAT.topology
>  create mode 100644 tests/data/uefi-boot-images/bios-tables-test.loongarch64.iso.qcow2
> 
> 
> base-commit: b69801dd6b1eb4d107f7c2f643adf0a4e3ec9124
Re: [PATCH 0/6] Add bios-tables-test for LoongArch64 system
Posted by Bibo Mao 8 months, 3 weeks ago 

On 2025/4/1 下午9:50, Igor Mammedov wrote:
> On Fri, 28 Feb 2025 17:27:23 +0800
> Bibo Mao <maobibo@loongson.cn> wrote:
> 
>> This patchset add bios-tables-test for LoongArch64 virt machine
>> system. It works with UEFI bios, with uefi-test-tools LoongArch64
>> support is added to build bios-tables-test.loongarch64.iso.
>>
>> Also with test case bios-tables-test, LoongArch64 support is added
>> and some basic ACPI tables is added here. It passes with command
>> make check-qtest-loongarch64 with the result:
>>   qtest-loongarch64/bios-tables-test OK 29.52s 4 subtests passed
>>
>> Bibo Mao (6):
>>    uefi-test-tools:: Add LoongArch64 support
>>    tests/data/uefi-boot-images: Add ISO image for LoongArch system
>>    tests/qtest/bios-tables-test: Add basic testing for LoongArch64
>>    tests/acpi: Add empty ACPI data files for LoongArch64
>>    tests/acpi: Fill acpi table data for LoongArch
> 
> blobs no longer match (since cpu hotplug was merged after this series)
> so blobs need to be updated and series needs to be re-spun
yes, this patch need be re-spun since cpu hotplug is merged and RSDT 
table is replaced with XSDT table.

Will refresh the patch based on the latest version.

Regards
Bibo Mao
> 
>>    tests/qtest: Enable bios-tables-test for LoongArch
>>
>>   tests/data/acpi/loongarch64/virt/APIC         | Bin 0 -> 108 bytes
>>   .../data/acpi/loongarch64/virt/APIC.topology  | Bin 0 -> 213 bytes
>>   tests/data/acpi/loongarch64/virt/DSDT         | Bin 0 -> 3614 bytes
>>   tests/data/acpi/loongarch64/virt/DSDT.memhp   | Bin 0 -> 4951 bytes
>>   tests/data/acpi/loongarch64/virt/FACP         | Bin 0 -> 268 bytes
>>   tests/data/acpi/loongarch64/virt/MCFG         | Bin 0 -> 60 bytes
>>   tests/data/acpi/loongarch64/virt/PPTT         | Bin 0 -> 76 bytes
>>   .../data/acpi/loongarch64/virt/PPTT.topology  | Bin 0 -> 296 bytes
>>   tests/data/acpi/loongarch64/virt/SLIT         |   0
>>   tests/data/acpi/loongarch64/virt/SLIT.memhp   | Bin 0 -> 48 bytes
>>   tests/data/acpi/loongarch64/virt/SPCR         | Bin 0 -> 80 bytes
>>   tests/data/acpi/loongarch64/virt/SRAT         | Bin 0 -> 104 bytes
>>   tests/data/acpi/loongarch64/virt/SRAT.memhp   | Bin 0 -> 184 bytes
>>   .../data/acpi/loongarch64/virt/SRAT.topology  | Bin 0 -> 216 bytes
>>   .../bios-tables-test.loongarch64.iso.qcow2    | Bin 0 -> 12800 bytes
>>   tests/qtest/bios-tables-test.c                |  62 ++++++++++++++++++
>>   tests/qtest/meson.build                       |   3 +-
>>   tests/uefi-test-tools/Makefile                |   5 +-
>>   .../UefiTestToolsPkg/UefiTestToolsPkg.dsc     |   6 +-
>>   tests/uefi-test-tools/uefi-test-build.config  |  10 +++
>>   20 files changed, 82 insertions(+), 4 deletions(-)
>>   create mode 100644 tests/data/acpi/loongarch64/virt/APIC
>>   create mode 100644 tests/data/acpi/loongarch64/virt/APIC.topology
>>   create mode 100644 tests/data/acpi/loongarch64/virt/DSDT
>>   create mode 100644 tests/data/acpi/loongarch64/virt/DSDT.memhp
>>   create mode 100644 tests/data/acpi/loongarch64/virt/FACP
>>   create mode 100644 tests/data/acpi/loongarch64/virt/MCFG
>>   create mode 100644 tests/data/acpi/loongarch64/virt/PPTT
>>   create mode 100644 tests/data/acpi/loongarch64/virt/PPTT.topology
>>   create mode 100644 tests/data/acpi/loongarch64/virt/SLIT
>>   create mode 100644 tests/data/acpi/loongarch64/virt/SLIT.memhp
>>   create mode 100644 tests/data/acpi/loongarch64/virt/SPCR
>>   create mode 100644 tests/data/acpi/loongarch64/virt/SRAT
>>   create mode 100644 tests/data/acpi/loongarch64/virt/SRAT.memhp
>>   create mode 100644 tests/data/acpi/loongarch64/virt/SRAT.topology
>>   create mode 100644 tests/data/uefi-boot-images/bios-tables-test.loongarch64.iso.qcow2
>>
>>
>> base-commit: b69801dd6b1eb4d107f7c2f643adf0a4e3ec9124
[PATCH 4/6] tests/acpi: Add empty ACPI data files for LoongArch64
Posted by Bibo Mao 11 months, 2 weeks ago 
Add empty acpi table for LoongArch64 virt machine, it is only empty
file and there is no data in these files.

Signed-off-by: Bibo Mao <maobibo@loongson.cn>
---
 tests/data/acpi/loongarch64/virt/APIC | 0
 tests/data/acpi/loongarch64/virt/DSDT | 0
 tests/data/acpi/loongarch64/virt/FACP | 0
 tests/data/acpi/loongarch64/virt/MCFG | 0
 tests/data/acpi/loongarch64/virt/PPTT | 0
 tests/data/acpi/loongarch64/virt/SLIT | 0
 tests/data/acpi/loongarch64/virt/SPCR | 0
 tests/data/acpi/loongarch64/virt/SRAT | 0
 8 files changed, 0 insertions(+), 0 deletions(-)
 create mode 100644 tests/data/acpi/loongarch64/virt/APIC
 create mode 100644 tests/data/acpi/loongarch64/virt/DSDT
 create mode 100644 tests/data/acpi/loongarch64/virt/FACP
 create mode 100644 tests/data/acpi/loongarch64/virt/MCFG
 create mode 100644 tests/data/acpi/loongarch64/virt/PPTT
 create mode 100644 tests/data/acpi/loongarch64/virt/SLIT
 create mode 100644 tests/data/acpi/loongarch64/virt/SPCR
 create mode 100644 tests/data/acpi/loongarch64/virt/SRAT

diff --git a/tests/data/acpi/loongarch64/virt/APIC b/tests/data/acpi/loongarch64/virt/APIC
new file mode 100644
index 0000000000..e69de29bb2
diff --git a/tests/data/acpi/loongarch64/virt/DSDT b/tests/data/acpi/loongarch64/virt/DSDT
new file mode 100644
index 0000000000..e69de29bb2
diff --git a/tests/data/acpi/loongarch64/virt/FACP b/tests/data/acpi/loongarch64/virt/FACP
new file mode 100644
index 0000000000..e69de29bb2
diff --git a/tests/data/acpi/loongarch64/virt/MCFG b/tests/data/acpi/loongarch64/virt/MCFG
new file mode 100644
index 0000000000..e69de29bb2
diff --git a/tests/data/acpi/loongarch64/virt/PPTT b/tests/data/acpi/loongarch64/virt/PPTT
new file mode 100644
index 0000000000..e69de29bb2
diff --git a/tests/data/acpi/loongarch64/virt/SLIT b/tests/data/acpi/loongarch64/virt/SLIT
new file mode 100644
index 0000000000..e69de29bb2
diff --git a/tests/data/acpi/loongarch64/virt/SPCR b/tests/data/acpi/loongarch64/virt/SPCR
new file mode 100644
index 0000000000..e69de29bb2
diff --git a/tests/data/acpi/loongarch64/virt/SRAT b/tests/data/acpi/loongarch64/virt/SRAT
new file mode 100644
index 0000000000..e69de29bb2
-- 
2.39.3
Re: [PATCH 4/6] tests/acpi: Add empty ACPI data files for LoongArch64
Posted by Igor Mammedov 10 months, 1 week ago 
On Fri, 28 Feb 2025 17:27:27 +0800
Bibo Mao <maobibo@loongson.cn> wrote:

> Add empty acpi table for LoongArch64 virt machine, it is only empty
> file and there is no data in these files.

this patch after 3/6 doesn't make sense,
either drop.

Adding empty blobs, can be useful (as then you can get ACPI diff during test)
but only if you follow update acpi blos process as described in
bios-tables-test.c


as is, the next patch (5/6) should precede 3/6


> 
> Signed-off-by: Bibo Mao <maobibo@loongson.cn>
> ---
>  tests/data/acpi/loongarch64/virt/APIC | 0
>  tests/data/acpi/loongarch64/virt/DSDT | 0
>  tests/data/acpi/loongarch64/virt/FACP | 0
>  tests/data/acpi/loongarch64/virt/MCFG | 0
>  tests/data/acpi/loongarch64/virt/PPTT | 0
>  tests/data/acpi/loongarch64/virt/SLIT | 0
>  tests/data/acpi/loongarch64/virt/SPCR | 0
>  tests/data/acpi/loongarch64/virt/SRAT | 0
>  8 files changed, 0 insertions(+), 0 deletions(-)
>  create mode 100644 tests/data/acpi/loongarch64/virt/APIC
>  create mode 100644 tests/data/acpi/loongarch64/virt/DSDT
>  create mode 100644 tests/data/acpi/loongarch64/virt/FACP
>  create mode 100644 tests/data/acpi/loongarch64/virt/MCFG
>  create mode 100644 tests/data/acpi/loongarch64/virt/PPTT
>  create mode 100644 tests/data/acpi/loongarch64/virt/SLIT
>  create mode 100644 tests/data/acpi/loongarch64/virt/SPCR
>  create mode 100644 tests/data/acpi/loongarch64/virt/SRAT
> 
> diff --git a/tests/data/acpi/loongarch64/virt/APIC b/tests/data/acpi/loongarch64/virt/APIC
> new file mode 100644
> index 0000000000..e69de29bb2
> diff --git a/tests/data/acpi/loongarch64/virt/DSDT b/tests/data/acpi/loongarch64/virt/DSDT
> new file mode 100644
> index 0000000000..e69de29bb2
> diff --git a/tests/data/acpi/loongarch64/virt/FACP b/tests/data/acpi/loongarch64/virt/FACP
> new file mode 100644
> index 0000000000..e69de29bb2
> diff --git a/tests/data/acpi/loongarch64/virt/MCFG b/tests/data/acpi/loongarch64/virt/MCFG
> new file mode 100644
> index 0000000000..e69de29bb2
> diff --git a/tests/data/acpi/loongarch64/virt/PPTT b/tests/data/acpi/loongarch64/virt/PPTT
> new file mode 100644
> index 0000000000..e69de29bb2
> diff --git a/tests/data/acpi/loongarch64/virt/SLIT b/tests/data/acpi/loongarch64/virt/SLIT
> new file mode 100644
> index 0000000000..e69de29bb2
> diff --git a/tests/data/acpi/loongarch64/virt/SPCR b/tests/data/acpi/loongarch64/virt/SPCR
> new file mode 100644
> index 0000000000..e69de29bb2
> diff --git a/tests/data/acpi/loongarch64/virt/SRAT b/tests/data/acpi/loongarch64/virt/SRAT
> new file mode 100644
> index 0000000000..e69de29bb2
Re: [PATCH 4/6] tests/acpi: Add empty ACPI data files for LoongArch64
Posted by Bibo Mao 8 months, 3 weeks ago 

On 2025/4/1 下午9:48, Igor Mammedov wrote:
> On Fri, 28 Feb 2025 17:27:27 +0800
> Bibo Mao <maobibo@loongson.cn> wrote:
> 
>> Add empty acpi table for LoongArch64 virt machine, it is only empty
>> file and there is no data in these files.
> 
> this patch after 3/6 doesn't make sense,
> either drop.
> 
> Adding empty blobs, can be useful (as then you can get ACPI diff during test)
> but only if you follow update acpi blos process as described in
> bios-tables-test.c
> 
> 
> as is, the next patch (5/6) should precede 3/6
Hi Ignor,

With file tests/qtest/bios-tables-test.c, there is commit steps.

  How to add or update the tests or commit changes that affect ACPI tables:
  Contributor:
  1. add empty files for new tables, if any, under tests/data/acpi
  2. list any changed files in tests/qtest/bios-tables-test-allowed-diff.h
  3. commit the above *before* making changes that affect the tables

I will follow steps of above in next round, how do you think of it?

Regards
Bibo Mao
> 
> 
>>
>> Signed-off-by: Bibo Mao <maobibo@loongson.cn>
>> ---
>>   tests/data/acpi/loongarch64/virt/APIC | 0
>>   tests/data/acpi/loongarch64/virt/DSDT | 0
>>   tests/data/acpi/loongarch64/virt/FACP | 0
>>   tests/data/acpi/loongarch64/virt/MCFG | 0
>>   tests/data/acpi/loongarch64/virt/PPTT | 0
>>   tests/data/acpi/loongarch64/virt/SLIT | 0
>>   tests/data/acpi/loongarch64/virt/SPCR | 0
>>   tests/data/acpi/loongarch64/virt/SRAT | 0
>>   8 files changed, 0 insertions(+), 0 deletions(-)
>>   create mode 100644 tests/data/acpi/loongarch64/virt/APIC
>>   create mode 100644 tests/data/acpi/loongarch64/virt/DSDT
>>   create mode 100644 tests/data/acpi/loongarch64/virt/FACP
>>   create mode 100644 tests/data/acpi/loongarch64/virt/MCFG
>>   create mode 100644 tests/data/acpi/loongarch64/virt/PPTT
>>   create mode 100644 tests/data/acpi/loongarch64/virt/SLIT
>>   create mode 100644 tests/data/acpi/loongarch64/virt/SPCR
>>   create mode 100644 tests/data/acpi/loongarch64/virt/SRAT
>>
>> diff --git a/tests/data/acpi/loongarch64/virt/APIC b/tests/data/acpi/loongarch64/virt/APIC
>> new file mode 100644
>> index 0000000000..e69de29bb2
>> diff --git a/tests/data/acpi/loongarch64/virt/DSDT b/tests/data/acpi/loongarch64/virt/DSDT
>> new file mode 100644
>> index 0000000000..e69de29bb2
>> diff --git a/tests/data/acpi/loongarch64/virt/FACP b/tests/data/acpi/loongarch64/virt/FACP
>> new file mode 100644
>> index 0000000000..e69de29bb2
>> diff --git a/tests/data/acpi/loongarch64/virt/MCFG b/tests/data/acpi/loongarch64/virt/MCFG
>> new file mode 100644
>> index 0000000000..e69de29bb2
>> diff --git a/tests/data/acpi/loongarch64/virt/PPTT b/tests/data/acpi/loongarch64/virt/PPTT
>> new file mode 100644
>> index 0000000000..e69de29bb2
>> diff --git a/tests/data/acpi/loongarch64/virt/SLIT b/tests/data/acpi/loongarch64/virt/SLIT
>> new file mode 100644
>> index 0000000000..e69de29bb2
>> diff --git a/tests/data/acpi/loongarch64/virt/SPCR b/tests/data/acpi/loongarch64/virt/SPCR
>> new file mode 100644
>> index 0000000000..e69de29bb2
>> diff --git a/tests/data/acpi/loongarch64/virt/SRAT b/tests/data/acpi/loongarch64/virt/SRAT
>> new file mode 100644
>> index 0000000000..e69de29bb2
Re: [PATCH 4/6] tests/acpi: Add empty ACPI data files for LoongArch64
Posted by Bibo Mao 8 months, 3 weeks ago 

On 2025/4/1 下午9:48, Igor Mammedov wrote:
> On Fri, 28 Feb 2025 17:27:27 +0800
> Bibo Mao <maobibo@loongson.cn> wrote:
> 
>> Add empty acpi table for LoongArch64 virt machine, it is only empty
>> file and there is no data in these files.
> 
> this patch after 3/6 doesn't make sense,
> either drop.
Empty acpi table can be dropped.
> 
> Adding empty blobs, can be useful (as then you can get ACPI diff during test)
> but only if you follow update acpi blos process as described in
> bios-tables-test.c
> 
> 
> as is, the next patch (5/6) should precede 3/6
yes, it is strange about patch order. How about split patch 3/6 into 
smaller patches, one patch for one test case, and move specified acpi 
table into smaller patches.

Regards
Bibo Mao
> 
> 
>>
>> Signed-off-by: Bibo Mao <maobibo@loongson.cn>
>> ---
>>   tests/data/acpi/loongarch64/virt/APIC | 0
>>   tests/data/acpi/loongarch64/virt/DSDT | 0
>>   tests/data/acpi/loongarch64/virt/FACP | 0
>>   tests/data/acpi/loongarch64/virt/MCFG | 0
>>   tests/data/acpi/loongarch64/virt/PPTT | 0
>>   tests/data/acpi/loongarch64/virt/SLIT | 0
>>   tests/data/acpi/loongarch64/virt/SPCR | 0
>>   tests/data/acpi/loongarch64/virt/SRAT | 0
>>   8 files changed, 0 insertions(+), 0 deletions(-)
>>   create mode 100644 tests/data/acpi/loongarch64/virt/APIC
>>   create mode 100644 tests/data/acpi/loongarch64/virt/DSDT
>>   create mode 100644 tests/data/acpi/loongarch64/virt/FACP
>>   create mode 100644 tests/data/acpi/loongarch64/virt/MCFG
>>   create mode 100644 tests/data/acpi/loongarch64/virt/PPTT
>>   create mode 100644 tests/data/acpi/loongarch64/virt/SLIT
>>   create mode 100644 tests/data/acpi/loongarch64/virt/SPCR
>>   create mode 100644 tests/data/acpi/loongarch64/virt/SRAT
>>
>> diff --git a/tests/data/acpi/loongarch64/virt/APIC b/tests/data/acpi/loongarch64/virt/APIC
>> new file mode 100644
>> index 0000000000..e69de29bb2
>> diff --git a/tests/data/acpi/loongarch64/virt/DSDT b/tests/data/acpi/loongarch64/virt/DSDT
>> new file mode 100644
>> index 0000000000..e69de29bb2
>> diff --git a/tests/data/acpi/loongarch64/virt/FACP b/tests/data/acpi/loongarch64/virt/FACP
>> new file mode 100644
>> index 0000000000..e69de29bb2
>> diff --git a/tests/data/acpi/loongarch64/virt/MCFG b/tests/data/acpi/loongarch64/virt/MCFG
>> new file mode 100644
>> index 0000000000..e69de29bb2
>> diff --git a/tests/data/acpi/loongarch64/virt/PPTT b/tests/data/acpi/loongarch64/virt/PPTT
>> new file mode 100644
>> index 0000000000..e69de29bb2
>> diff --git a/tests/data/acpi/loongarch64/virt/SLIT b/tests/data/acpi/loongarch64/virt/SLIT
>> new file mode 100644
>> index 0000000000..e69de29bb2
>> diff --git a/tests/data/acpi/loongarch64/virt/SPCR b/tests/data/acpi/loongarch64/virt/SPCR
>> new file mode 100644
>> index 0000000000..e69de29bb2
>> diff --git a/tests/data/acpi/loongarch64/virt/SRAT b/tests/data/acpi/loongarch64/virt/SRAT
>> new file mode 100644
>> index 0000000000..e69de29bb2

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.