1. Patchew
  2. QEMU
  3. View series

[PATCH] tests/functional: Update the ppc64 pseries and pnv tests

Cédric Le Goater posted 1 patch 1 month ago 
tests/functional/test_ppc64_powernv.py | 6 +++---
tests/functional/test_ppc64_pseries.py | 6 +++---
2 files changed, 6 insertions(+), 6 deletions(-)
[PATCH] tests/functional: Update the ppc64 pseries and pnv tests
Posted by Cédric Le Goater 1 month ago 
The tests are using a now archived Fedora29 release. Switch to the
most recent Fedora41 release.

Signed-off-by: Cédric Le Goater <clg@redhat.com>
---
 tests/functional/test_ppc64_powernv.py | 6 +++---
 tests/functional/test_ppc64_pseries.py | 6 +++---
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/tests/functional/test_ppc64_powernv.py b/tests/functional/test_ppc64_powernv.py
index 685e2178ed78..a9da7905366e 100755
--- a/tests/functional/test_ppc64_powernv.py
+++ b/tests/functional/test_ppc64_powernv.py
@@ -18,9 +18,9 @@ class powernvMachine(LinuxKernelTest):
     good_message = 'VFS: Cannot open root device'
 
     ASSET_KERNEL = Asset(
-        ('https://archives.fedoraproject.org/pub/archive/fedora-secondary/'
-         'releases/29/Everything/ppc64le/os/ppc/ppc64/vmlinuz'),
-        '383c2f5c23bc0d9d32680c3924d3fd7ee25cc5ef97091ac1aa5e1d853422fc5f')
+        ('https://archives.fedoraproject.org/pub/fedora-secondary/'
+         'releases/41/Everything/ppc64le/os/ppc/ppc64/vmlinuz'),
+        'eca627adbe42437cacea169beeb4c3c12a5cfbca1a6b1ba5218d28139d2143c4')
 
     def do_test_linux_boot(self, command_line = KERNEL_COMMON_COMMAND_LINE):
         self.require_accelerator("tcg")
diff --git a/tests/functional/test_ppc64_pseries.py b/tests/functional/test_ppc64_pseries.py
index fdc404ed033d..92317cddead1 100755
--- a/tests/functional/test_ppc64_pseries.py
+++ b/tests/functional/test_ppc64_pseries.py
@@ -18,9 +18,9 @@ class pseriesMachine(QemuSystemTest):
     good_message = 'VFS: Cannot open root device'
 
     ASSET_KERNEL = Asset(
-        ('https://archives.fedoraproject.org/pub/archive/fedora-secondary/'
-         'releases/29/Everything/ppc64le/os/ppc/ppc64/vmlinuz'),
-        '383c2f5c23bc0d9d32680c3924d3fd7ee25cc5ef97091ac1aa5e1d853422fc5f')
+        ('https://archives.fedoraproject.org/pub/fedora-secondary/'
+         'releases/41/Everything/ppc64le/os/ppc/ppc64/vmlinuz'),
+        'eca627adbe42437cacea169beeb4c3c12a5cfbca1a6b1ba5218d28139d2143c4')
 
     def do_test_ppc64_linux_boot(self, kernel_command_line = KERNEL_COMMON_COMMAND_LINE):
         kernel_path = self.ASSET_KERNEL.fetch()
-- 
2.48.1
Re: [PATCH] tests/functional: Update the ppc64 pseries and pnv tests
Posted by Thomas Huth 1 month ago 
On 26/02/2025 07.54, Cédric Le Goater wrote:
> The tests are using a now archived Fedora29 release. Switch to the
> most recent Fedora41 release.
> 
> Signed-off-by: Cédric Le Goater <clg@redhat.com>
> ---
>   tests/functional/test_ppc64_powernv.py | 6 +++---
>   tests/functional/test_ppc64_pseries.py | 6 +++---
>   2 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/tests/functional/test_ppc64_powernv.py b/tests/functional/test_ppc64_powernv.py
> index 685e2178ed78..a9da7905366e 100755
> --- a/tests/functional/test_ppc64_powernv.py
> +++ b/tests/functional/test_ppc64_powernv.py
> @@ -18,9 +18,9 @@ class powernvMachine(LinuxKernelTest):
>       good_message = 'VFS: Cannot open root device'
>   
>       ASSET_KERNEL = Asset(
> -        ('https://archives.fedoraproject.org/pub/archive/fedora-secondary/'
> -         'releases/29/Everything/ppc64le/os/ppc/ppc64/vmlinuz'),
> -        '383c2f5c23bc0d9d32680c3924d3fd7ee25cc5ef97091ac1aa5e1d853422fc5f')
> +        ('https://archives.fedoraproject.org/pub/fedora-secondary/'
> +         'releases/41/Everything/ppc64le/os/ppc/ppc64/vmlinuz'),
> +        'eca627adbe42437cacea169beeb4c3c12a5cfbca1a6b1ba5218d28139d2143c4')

I think we should rather avoid the very latest and greatest Fedora URLs 
here... they will be invalid in a couple of months after Fedora 43 has been 
released. And if we keep switching the test assets all the time, this will 
make it more difficult to bisect regressions in the future.

  Thomas
Re: [PATCH] tests/functional: Update the ppc64 pseries and pnv tests
Posted by Daniel P. Berrangé 1 month ago 
On Wed, Feb 26, 2025 at 08:01:09AM +0100, Thomas Huth wrote:
> On 26/02/2025 07.54, Cédric Le Goater wrote:
> > The tests are using a now archived Fedora29 release. Switch to the
> > most recent Fedora41 release.
> > 
> > Signed-off-by: Cédric Le Goater <clg@redhat.com>
> > ---
> >   tests/functional/test_ppc64_powernv.py | 6 +++---
> >   tests/functional/test_ppc64_pseries.py | 6 +++---
> >   2 files changed, 6 insertions(+), 6 deletions(-)
> > 
> > diff --git a/tests/functional/test_ppc64_powernv.py b/tests/functional/test_ppc64_powernv.py
> > index 685e2178ed78..a9da7905366e 100755
> > --- a/tests/functional/test_ppc64_powernv.py
> > +++ b/tests/functional/test_ppc64_powernv.py
> > @@ -18,9 +18,9 @@ class powernvMachine(LinuxKernelTest):
> >       good_message = 'VFS: Cannot open root device'
> >       ASSET_KERNEL = Asset(
> > -        ('https://archives.fedoraproject.org/pub/archive/fedora-secondary/'
> > -         'releases/29/Everything/ppc64le/os/ppc/ppc64/vmlinuz'),
> > -        '383c2f5c23bc0d9d32680c3924d3fd7ee25cc5ef97091ac1aa5e1d853422fc5f')
> > +        ('https://archives.fedoraproject.org/pub/fedora-secondary/'
> > +         'releases/41/Everything/ppc64le/os/ppc/ppc64/vmlinuz'),
> > +        'eca627adbe42437cacea169beeb4c3c12a5cfbca1a6b1ba5218d28139d2143c4')
> 
> I think we should rather avoid the very latest and greatest Fedora URLs
> here... they will be invalid in a couple of months after Fedora 43 has been
> released. And if we keep switching the test assets all the time, this will
> make it more difficult to bisect regressions in the future.

Neither of the URLs here should change, as both are using the
archives.fedoraproject.org server which carries all historic
content.

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
Re: [PATCH] tests/functional: Update the ppc64 pseries and pnv tests
Posted by Cédric Le Goater 1 month ago 
Hello,

On 2/26/25 10:04, Daniel P. Berrangé wrote:
> On Wed, Feb 26, 2025 at 08:01:09AM +0100, Thomas Huth wrote:
>> On 26/02/2025 07.54, Cédric Le Goater wrote:
>>> The tests are using a now archived Fedora29 release. Switch to the
>>> most recent Fedora41 release.
>>>
>>> Signed-off-by: Cédric Le Goater <clg@redhat.com>
>>> ---
>>>    tests/functional/test_ppc64_powernv.py | 6 +++---
>>>    tests/functional/test_ppc64_pseries.py | 6 +++---
>>>    2 files changed, 6 insertions(+), 6 deletions(-)
>>>
>>> diff --git a/tests/functional/test_ppc64_powernv.py b/tests/functional/test_ppc64_powernv.py
>>> index 685e2178ed78..a9da7905366e 100755
>>> --- a/tests/functional/test_ppc64_powernv.py
>>> +++ b/tests/functional/test_ppc64_powernv.py
>>> @@ -18,9 +18,9 @@ class powernvMachine(LinuxKernelTest):
>>>        good_message = 'VFS: Cannot open root device'
>>>        ASSET_KERNEL = Asset(
>>> -        ('https://archives.fedoraproject.org/pub/archive/fedora-secondary/'
>>> -         'releases/29/Everything/ppc64le/os/ppc/ppc64/vmlinuz'),
>>> -        '383c2f5c23bc0d9d32680c3924d3fd7ee25cc5ef97091ac1aa5e1d853422fc5f')
>>> +        ('https://archives.fedoraproject.org/pub/fedora-secondary/'
>>> +         'releases/41/Everything/ppc64le/os/ppc/ppc64/vmlinuz'),
>>> +        'eca627adbe42437cacea169beeb4c3c12a5cfbca1a6b1ba5218d28139d2143c4')
>>
>> I think we should rather avoid the very latest and greatest Fedora URLs
>> here... they will be invalid in a couple of months after Fedora 43 has been
>> released. And if we keep switching the test assets all the time, this will
>> make it more difficult to bisect regressions in the future.
> 
> Neither of the URLs here should change, as both are using the
> archives.fedoraproject.org server which carries all historic
> content.

Indeed but the files below :

   https://archives.fedoraproject.org/pub/fedora-secondary/<rel>/

are moved under

   https://archives.fedoraproject.org/pub/archive/fedora-secondary/<rel>/

every 2 releases and QEMU tests will break :/

In my tests, I prefer to use the latest FW/Linux images because
HW support should be better, which is always good to exercise a
bit more the QEMU models.

That said, older images (f29) should keep on working too on PPC.

Thanks,

C.
Re: [PATCH] tests/functional: Update the ppc64 pseries and pnv tests
Posted by Cédric Le Goater 1 month ago 
On 2/26/25 08:01, Thomas Huth wrote:
> On 26/02/2025 07.54, Cédric Le Goater wrote:
>> The tests are using a now archived Fedora29 release. Switch to the
>> most recent Fedora41 release.
>>
>> Signed-off-by: Cédric Le Goater <clg@redhat.com>
>> ---
>>   tests/functional/test_ppc64_powernv.py | 6 +++---
>>   tests/functional/test_ppc64_pseries.py | 6 +++---
>>   2 files changed, 6 insertions(+), 6 deletions(-)
>>
>> diff --git a/tests/functional/test_ppc64_powernv.py b/tests/functional/test_ppc64_powernv.py
>> index 685e2178ed78..a9da7905366e 100755
>> --- a/tests/functional/test_ppc64_powernv.py
>> +++ b/tests/functional/test_ppc64_powernv.py
>> @@ -18,9 +18,9 @@ class powernvMachine(LinuxKernelTest):
>>       good_message = 'VFS: Cannot open root device'
>>       ASSET_KERNEL = Asset(
>> -        ('https://archives.fedoraproject.org/pub/archive/fedora-secondary/'
>> -         'releases/29/Everything/ppc64le/os/ppc/ppc64/vmlinuz'),
>> -        '383c2f5c23bc0d9d32680c3924d3fd7ee25cc5ef97091ac1aa5e1d853422fc5f')
>> +        ('https://archives.fedoraproject.org/pub/fedora-secondary/'
>> +         'releases/41/Everything/ppc64le/os/ppc/ppc64/vmlinuz'),
>> +        'eca627adbe42437cacea169beeb4c3c12a5cfbca1a6b1ba5218d28139d2143c4')
> 
> I think we should rather avoid the very latest and greatest Fedora URLs here... they will be invalid in a couple of months after Fedora 43 has been released. And if we keep switching the test assets all the time, this will make it more difficult to bisect regressions in the future.
> 
>   Thomas
> 

So we should point to the latest archive (fedora38) then ?


Thanks,

C.
Re: [PATCH] tests/functional: Update the ppc64 pseries and pnv tests
Posted by Thomas Huth 1 month ago 
On 26/02/2025 08.54, Cédric Le Goater wrote:
> On 2/26/25 08:01, Thomas Huth wrote:
>> On 26/02/2025 07.54, Cédric Le Goater wrote:
>>> The tests are using a now archived Fedora29 release. Switch to the
>>> most recent Fedora41 release.
>>>
>>> Signed-off-by: Cédric Le Goater <clg@redhat.com>
>>> ---
>>>   tests/functional/test_ppc64_powernv.py | 6 +++---
>>>   tests/functional/test_ppc64_pseries.py | 6 +++---
>>>   2 files changed, 6 insertions(+), 6 deletions(-)
>>>
>>> diff --git a/tests/functional/test_ppc64_powernv.py b/tests/functional/ 
>>> test_ppc64_powernv.py
>>> index 685e2178ed78..a9da7905366e 100755
>>> --- a/tests/functional/test_ppc64_powernv.py
>>> +++ b/tests/functional/test_ppc64_powernv.py
>>> @@ -18,9 +18,9 @@ class powernvMachine(LinuxKernelTest):
>>>       good_message = 'VFS: Cannot open root device'
>>>       ASSET_KERNEL = Asset(
>>> -        ('https://archives.fedoraproject.org/pub/archive/fedora-secondary/'
>>> -         'releases/29/Everything/ppc64le/os/ppc/ppc64/vmlinuz'),
>>> -        '383c2f5c23bc0d9d32680c3924d3fd7ee25cc5ef97091ac1aa5e1d853422fc5f')
>>> +        ('https://archives.fedoraproject.org/pub/fedora-secondary/'
>>> +         'releases/41/Everything/ppc64le/os/ppc/ppc64/vmlinuz'),
>>> +        'eca627adbe42437cacea169beeb4c3c12a5cfbca1a6b1ba5218d28139d2143c4')
>>
>> I think we should rather avoid the very latest and greatest Fedora URLs 
>> here... they will be invalid in a couple of months after Fedora 43 has 
>> been released. And if we keep switching the test assets all the time, this 
>> will make it more difficult to bisect regressions in the future.
>>
>>   Thomas
>>
> 
> So we should point to the latest archive (fedora38) then ?

Either that, or simply keep the f29 kernel ... what do we gain by switching 
to a newer one here? Is it testing more hardware?

  Thomas
Re: [PATCH] tests/functional: Update the ppc64 pseries and pnv tests
Posted by Cédric Le Goater 1 month ago 
On 2/26/25 09:11, Thomas Huth wrote:
> On 26/02/2025 08.54, Cédric Le Goater wrote:
>> On 2/26/25 08:01, Thomas Huth wrote:
>>> On 26/02/2025 07.54, Cédric Le Goater wrote:
>>>> The tests are using a now archived Fedora29 release. Switch to the
>>>> most recent Fedora41 release.
>>>>
>>>> Signed-off-by: Cédric Le Goater <clg@redhat.com>
>>>> ---
>>>>   tests/functional/test_ppc64_powernv.py | 6 +++---
>>>>   tests/functional/test_ppc64_pseries.py | 6 +++---
>>>>   2 files changed, 6 insertions(+), 6 deletions(-)
>>>>
>>>> diff --git a/tests/functional/test_ppc64_powernv.py b/tests/functional/ test_ppc64_powernv.py
>>>> index 685e2178ed78..a9da7905366e 100755
>>>> --- a/tests/functional/test_ppc64_powernv.py
>>>> +++ b/tests/functional/test_ppc64_powernv.py
>>>> @@ -18,9 +18,9 @@ class powernvMachine(LinuxKernelTest):
>>>>       good_message = 'VFS: Cannot open root device'
>>>>       ASSET_KERNEL = Asset(
>>>> -        ('https://archives.fedoraproject.org/pub/archive/fedora-secondary/'
>>>> -         'releases/29/Everything/ppc64le/os/ppc/ppc64/vmlinuz'),
>>>> -        '383c2f5c23bc0d9d32680c3924d3fd7ee25cc5ef97091ac1aa5e1d853422fc5f')
>>>> +        ('https://archives.fedoraproject.org/pub/fedora-secondary/'
>>>> +         'releases/41/Everything/ppc64le/os/ppc/ppc64/vmlinuz'),
>>>> +        'eca627adbe42437cacea169beeb4c3c12a5cfbca1a6b1ba5218d28139d2143c4')
>>>
>>> I think we should rather avoid the very latest and greatest Fedora URLs here... they will be invalid in a couple of months after Fedora 43 has been released. And if we keep switching the test assets all the time, this will make it more difficult to bisect regressions in the future.
>>>
>>>   Thomas
>>>
>>
>> So we should point to the latest archive (fedora38) then ?
> 
> Either that, or simply keep the f29 kernel ... what do we gain by switching to a newer one here? Is it testing more hardware?


Yes. Usually HW support is added gradually to the kernel and
the later one offers better support.

Any how, that's fine, f29 works good enough.

Thanks,

C.




>   Thomas
>

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.