[PATCH 00/10] qapi: misc testing and doc patches

John Snow posted 10 patches 1 month, 1 week ago
docs/devel/codebase.rst        |   6 +-
docs/glossary.rst              |  10 +--
docs/sphinx/qapidoc.py         |  18 ++---
python/tests/qapi-flake8.sh    |   2 +
python/tests/qapi-isort.sh     |   2 +
python/tests/qapi-mypy.sh      |   2 +
python/tests/qapi-pylint.sh    |   4 ++
scripts/qapi/.flake8           |   3 -
scripts/qapi/.isort.cfg        |   7 --
scripts/qapi/mypy.ini          |   4 --
scripts/qapi/parser.py         | 124 +++++++++++++++++++++++++--------
scripts/qapi/pylintrc          |   1 +
scripts/qapi/source.py         |   4 +-
tests/qapi-schema/doc-good.out |  10 +--
tests/qapi-schema/test-qapi.py |   2 +-
15 files changed, 128 insertions(+), 71 deletions(-)
create mode 100755 python/tests/qapi-flake8.sh
create mode 100755 python/tests/qapi-isort.sh
create mode 100755 python/tests/qapi-mypy.sh
create mode 100755 python/tests/qapi-pylint.sh
delete mode 100644 scripts/qapi/.flake8
delete mode 100644 scripts/qapi/.isort.cfg
delete mode 100644 scripts/qapi/mypy.ini
[PATCH 00/10] qapi: misc testing and doc patches
Posted by John Snow 1 month, 1 week ago
GitLab: https://gitlab.com/jsnow/qemu/-/pipelines/1684045409

This is a series of random qapi and documentation patches;

Patches 1-3: Formalize QAPI python testing (finally ...)
Patches 4-10: Miscellaneous patches and fixes related to the
documentation overhaul project; but were standalone enough that they
could be excised from a fairly lengthy series ...

Markus: I think everything here is suitable for merging, even though
some of it might lack a little context. The more I pull out of that big
series, the easier that series will be to review :)

Please stage as much as you feel comfortable doing, you can skip any
individual patch at your discretion.

John Snow (10):
  qapi: update pylintrc config
  python: add qapi static analysis tests
  qapi: delete un-needed python static analysis configs
  docs/qapidoc: support header-less freeform sections
  qapi/parser: adjust info location for doc body section
  docs/qapidoc: remove example section support
  qapi: expand tags to all doc sections
  qapi/schema: add __repr__ to QAPIDoc.Section
  qapi/source: allow multi-line QAPISourceInfo advancing
  docs: disambiguate cross-references

 docs/devel/codebase.rst        |   6 +-
 docs/glossary.rst              |  10 +--
 docs/sphinx/qapidoc.py         |  18 ++---
 python/tests/qapi-flake8.sh    |   2 +
 python/tests/qapi-isort.sh     |   2 +
 python/tests/qapi-mypy.sh      |   2 +
 python/tests/qapi-pylint.sh    |   4 ++
 scripts/qapi/.flake8           |   3 -
 scripts/qapi/.isort.cfg        |   7 --
 scripts/qapi/mypy.ini          |   4 --
 scripts/qapi/parser.py         | 124 +++++++++++++++++++++++++--------
 scripts/qapi/pylintrc          |   1 +
 scripts/qapi/source.py         |   4 +-
 tests/qapi-schema/doc-good.out |  10 +--
 tests/qapi-schema/test-qapi.py |   2 +-
 15 files changed, 128 insertions(+), 71 deletions(-)
 create mode 100755 python/tests/qapi-flake8.sh
 create mode 100755 python/tests/qapi-isort.sh
 create mode 100755 python/tests/qapi-mypy.sh
 create mode 100755 python/tests/qapi-pylint.sh
 delete mode 100644 scripts/qapi/.flake8
 delete mode 100644 scripts/qapi/.isort.cfg
 delete mode 100644 scripts/qapi/mypy.ini

-- 
2.48.1

Re: [PATCH 00/10] qapi: misc testing and doc patches
Posted by Markus Armbruster 1 month ago
John Snow <jsnow@redhat.com> writes:

> GitLab: https://gitlab.com/jsnow/qemu/-/pipelines/1684045409
>
> This is a series of random qapi and documentation patches;
>
> Patches 1-3: Formalize QAPI python testing (finally ...)
> Patches 4-10: Miscellaneous patches and fixes related to the
> documentation overhaul project; but were standalone enough that they
> could be excised from a fairly lengthy series ...
>
> Markus: I think everything here is suitable for merging, even though
> some of it might lack a little context. The more I pull out of that big
> series, the easier that series will be to review :)
>
> Please stage as much as you feel comfortable doing, you can skip any
> individual patch at your discretion.

I'm queuing the no-brainers immediately: PATCH 01,02,04,06

I had a question on PATCH 03, and I'm holding the patch for now.

I'm not sure I like PATCH 05 without a case where it shows improvement.
I tried to find one, but no luck, yet.  Holding for now.

I still need to review PATCH 07 in detail.  Holding for now.

PATCH 08 depends on it.  Holding for now.

PATCH 09 has no use, yet.  I'd prefer you resubmit it together with
something that uses it, at your convenience.

Similar for PATCH 10.

I expect to queue the patches I'm holding, i.e. 03,05,07,08, in due
time.

Thanks!