hw/net/fsl_etsec: Set eTSEC device description and category

[PATCH] hw/net/fsl_etsec: Set eTSEC device description and category

Posted by BALATON Zoltan 1 month, 1 week ago

Add description and set category for eTSEC device so it shows up
better in -device help.

Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
---
 hw/net/fsl_etsec/etsec.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/hw/net/fsl_etsec/etsec.c b/hw/net/fsl_etsec/etsec.c
index 3ce4fa2662..adde644892 100644
--- a/hw/net/fsl_etsec/etsec.c
+++ b/hw/net/fsl_etsec/etsec.c
@@ -423,8 +423,10 @@ static void etsec_class_init(ObjectClass *klass, void *data)
     DeviceClass *dc = DEVICE_CLASS(klass);
 
     dc->realize = etsec_realize;
+    dc->desc = "Freescale Enhanced Three-Speed Ethernet Controller";
     device_class_set_legacy_reset(dc, etsec_reset);
     device_class_set_props(dc, etsec_properties);
+    set_bit(DEVICE_CATEGORY_NETWORK, dc->categories);
 }
 
 static const TypeInfo etsec_types[] = {
-- 
2.30.9

Re: [PATCH] hw/net/fsl_etsec: Set eTSEC device description and category

Posted by Philippe Mathieu-Daudé 1 month ago

On 18/2/25 16:54, BALATON Zoltan wrote:
> Add description and set category for eTSEC device so it shows up
> better in -device help.
> 
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> ---
>   hw/net/fsl_etsec/etsec.c | 2 ++
>   1 file changed, 2 insertions(+)

Patch queued, thanks!

Re: [PATCH] hw/net/fsl_etsec: Set eTSEC device description and category

Posted by Bernhard Beschow 1 month ago


Am 18. Februar 2025 15:54:07 UTC schrieb BALATON Zoltan <balaton@eik.bme.hu>:
>Add description and set category for eTSEC device so it shows up
>better in -device help.
>
>Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
>---
> hw/net/fsl_etsec/etsec.c | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/hw/net/fsl_etsec/etsec.c b/hw/net/fsl_etsec/etsec.c
>index 3ce4fa2662..adde644892 100644
>--- a/hw/net/fsl_etsec/etsec.c
>+++ b/hw/net/fsl_etsec/etsec.c
>@@ -423,8 +423,10 @@ static void etsec_class_init(ObjectClass *klass, void *data)
>     DeviceClass *dc = DEVICE_CLASS(klass);
> 
>     dc->realize = etsec_realize;
>+    dc->desc = "Freescale Enhanced Three-Speed Ethernet Controller";
>     device_class_set_legacy_reset(dc, etsec_reset);
>     device_class_set_props(dc, etsec_properties);
>+    set_bit(DEVICE_CATEGORY_NETWORK, dc->categories);
> }
> 
> static const TypeInfo etsec_types[] = {

Reviewed-by: Bernhard Beschow <shentey@gmail.com>

Re: [PATCH] hw/net/fsl_etsec: Set eTSEC device description and category

Posted by BALATON Zoltan 1 month ago

On Tue, 18 Feb 2025, BALATON Zoltan wrote:
> Add description and set category for eTSEC device so it shows up
> better in -device help.

Ping?

> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> ---
> hw/net/fsl_etsec/etsec.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/net/fsl_etsec/etsec.c b/hw/net/fsl_etsec/etsec.c
> index 3ce4fa2662..adde644892 100644
> --- a/hw/net/fsl_etsec/etsec.c
> +++ b/hw/net/fsl_etsec/etsec.c
> @@ -423,8 +423,10 @@ static void etsec_class_init(ObjectClass *klass, void *data)
>     DeviceClass *dc = DEVICE_CLASS(klass);
>
>     dc->realize = etsec_realize;
> +    dc->desc = "Freescale Enhanced Three-Speed Ethernet Controller";
>     device_class_set_legacy_reset(dc, etsec_reset);
>     device_class_set_props(dc, etsec_properties);
> +    set_bit(DEVICE_CATEGORY_NETWORK, dc->categories);
> }
>
> static const TypeInfo etsec_types[] = {
>