[v2] hw/arm: Explicit number of GIC external IRQs for Cortex A9/A15 MPCore

[PATCH v2 0/8] hw/arm: Explicit number of GIC external IRQs for Cortex A9/A15 MPCore

Posted by Philippe Mathieu-Daudé 1 month, 2 weeks ago

Some boards based on Cortex-A9MP / Cortex-A15MP do not explicit
the number of external GIC IRQs, using some (implicit) default value,
not always trivial to figure out. Change that by removing the default
value, requiring MPCore objects to be created with the "num-irq" set.

Since v1:
- Remove generic comments (Peter)

Philippe Mathieu-Daudé (8):
  hw/arm/exynos4210: Replace magic 32 by proper 'GIC_INTERNAL'
    definition
  hw/arm/exynos4210: Specify explicitly the GIC has 64 external IRQs
  hw/arm/realview: Specify explicitly the GIC has 64 external IRQs
  hw/arm/xilinx_zynq: Replace IRQ_OFFSET -> GIC_INTERNAL
  hw/arm/xilinx_zynq: Specify explicitly the GIC has 64 external IRQs
  hw/arm/vexpress: Specify explicitly the GIC has 64 external IRQs
  hw/arm/highbank: Specify explicitly the GIC has 128 external IRQs
  hw/cpu/arm_mpcore: Remove default values for GIC external IRQs

 hw/arm/exynos4210.c  | 10 ++++++++--
 hw/arm/highbank.c    |  8 ++++----
 hw/arm/realview.c    | 11 +++++++++--
 hw/arm/vexpress.c    |  7 +++++--
 hw/arm/xilinx_zynq.c | 43 ++++++++++++++++++++++---------------------
 hw/cpu/a15mpcore.c   | 18 ++++++++++++------
 hw/cpu/a9mpcore.c    | 18 ++++++++++++------
 7 files changed, 72 insertions(+), 43 deletions(-)

-- 
2.47.1

Re: [PATCH v2 0/8] hw/arm: Explicit number of GIC external IRQs for Cortex A9/A15 MPCore

Posted by Peter Maydell 1 month, 2 weeks ago

On Wed, 12 Feb 2025 at 15:43, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
>
> Some boards based on Cortex-A9MP / Cortex-A15MP do not explicit
> the number of external GIC IRQs, using some (implicit) default value,
> not always trivial to figure out. Change that by removing the default
> value, requiring MPCore objects to be created with the "num-irq" set.
>
> Since v1:
> - Remove generic comments (Peter)
>
> Philippe Mathieu-Daudé (8):
>   hw/arm/exynos4210: Replace magic 32 by proper 'GIC_INTERNAL'
>     definition
>   hw/arm/exynos4210: Specify explicitly the GIC has 64 external IRQs
>   hw/arm/realview: Specify explicitly the GIC has 64 external IRQs
>   hw/arm/xilinx_zynq: Replace IRQ_OFFSET -> GIC_INTERNAL
>   hw/arm/xilinx_zynq: Specify explicitly the GIC has 64 external IRQs
>   hw/arm/vexpress: Specify explicitly the GIC has 64 external IRQs
>   hw/arm/highbank: Specify explicitly the GIC has 128 external IRQs
>   hw/cpu/arm_mpcore: Remove default values for GIC external IRQs



Applied to target-arm.next, thanks.

-- PMM