[v2] migration: Fix issues during qmp_migrate_cancel

[PATCH v2 9/9] migration: Update migrate_cancel documentation

Posted by Fabiano Rosas 1 month, 3 weeks ago

Update the migrate_cancel command documentation with a few words about
postcopy and the expected state of the machine after migration.

Signed-off-by: Fabiano Rosas <farosas@suse.de>
---
 qapi/migration.json | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/qapi/migration.json b/qapi/migration.json
index 43babd1df4..8b9c53595c 100644
--- a/qapi/migration.json
+++ b/qapi/migration.json
@@ -1524,7 +1524,9 @@
 ##
 # @migrate_cancel:
 #
-# Cancel the current executing migration process.
+# Cancel the currently executing migration process.  Allows a new
+# migration to be started right after.  When postcopy-ram is in use,
+# cancelling is not allowed after the postcopy phase has started.
 #
 # .. note:: This command succeeds even if there is no migration
 #    process running.
-- 
2.35.3

Re: [PATCH v2 9/9] migration: Update migrate_cancel documentation

Posted by Peter Xu 1 month, 3 weeks ago

On Tue, Feb 11, 2025 at 12:01:36PM -0300, Fabiano Rosas wrote:
> Update the migrate_cancel command documentation with a few words about
> postcopy and the expected state of the machine after migration.
> 
> Signed-off-by: Fabiano Rosas <farosas@suse.de>

Reviewed-by: Peter Xu <peterx@redhat.com>

-- 
Peter Xu

Re: [PATCH v2 9/9] migration: Update migrate_cancel documentation

Posted by Markus Armbruster 1 month, 3 weeks ago

Fabiano Rosas <farosas@suse.de> writes:

> Update the migrate_cancel command documentation with a few words about
> postcopy and the expected state of the machine after migration.
>
> Signed-off-by: Fabiano Rosas <farosas@suse.de>
> ---
>  qapi/migration.json | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/qapi/migration.json b/qapi/migration.json
> index 43babd1df4..8b9c53595c 100644
> --- a/qapi/migration.json
> +++ b/qapi/migration.json
> @@ -1524,7 +1524,9 @@
>  ##
>  # @migrate_cancel:
>  #
> -# Cancel the current executing migration process.
> +# Cancel the currently executing migration process.  Allows a new
> +# migration to be started right after.  When postcopy-ram is in use,
> +# cancelling is not allowed after the postcopy phase has started.
>  #
>  # .. note:: This command succeeds even if there is no migration
>  #    process running.

Acked-by: Markus Armbruster <armbru@redhat.com>