cryptodev/vhost: allocate CryptoDevBackendVhost using g_mem0()

[PATCH] cryptodev/vhost: allocate CryptoDevBackendVhost using g_mem0()

Stefano Garzarella posted 1 patch 12 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20250211135523.101203-1-sgarzare@redhat.com

Maintainers: "Michael S. Tsirkin" <mst@redhat.com>, Stefano Garzarella <sgarzare@redhat.com>, "Gonglei (Arei)" <arei.gonglei@huawei.com>, Zhenwei Pi <pizhenwei@bytedance.com>

backends/cryptodev-vhost.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH] cryptodev/vhost: allocate CryptoDevBackendVhost using g_mem0()

Posted by Stefano Garzarella 12 months ago

The function `vhost_dev_init()` expects the `struct vhost_dev`
(passed as a parameter) to be fully initialized. This is important
because some parts of the code check whether `vhost_dev->config_ops`
is NULL to determine if it has been set (e.g. later via
`vhost_dev_set_config_notifier`).

To ensure this initialization, it’s better to allocate the entire
`CryptoDevBackendVhost` structure (which includes `vhost_dev`) using
`g_mem0()`, following the same approach used for other vhost devices,
such as in `vhost_net_init()`.

Fixes: 042cea274c ("cryptodev: add vhost-user as a new cryptodev backend")
Cc: qemu-stable@nongnu.org
Reported-by: myluo24@m.fudan.edu.cn
Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
---
 backends/cryptodev-vhost.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/backends/cryptodev-vhost.c b/backends/cryptodev-vhost.c
index 8718c97326..943680a23a 100644
--- a/backends/cryptodev-vhost.c
+++ b/backends/cryptodev-vhost.c
@@ -53,7 +53,7 @@ cryptodev_vhost_init(
     CryptoDevBackendVhost *crypto;
     Error *local_err = NULL;
 
-    crypto = g_new(CryptoDevBackendVhost, 1);
+    crypto = g_new0(CryptoDevBackendVhost, 1);
     crypto->dev.max_queues = 1;
     crypto->dev.nvqs = 1;
     crypto->dev.vqs = crypto->vqs;
-- 
2.48.1

Re: [PATCH] cryptodev/vhost: allocate CryptoDevBackendVhost using g_mem0()

Posted by zhenwei pi 12 months ago

Acked-by: zhenwei pi <pizhenwei@bytedance.com>

On 2/11/25 21:55, Stefano Garzarella wrote:
> The function `vhost_dev_init()` expects the `struct vhost_dev`
> (passed as a parameter) to be fully initialized. This is important
> because some parts of the code check whether `vhost_dev->config_ops`
> is NULL to determine if it has been set (e.g. later via
> `vhost_dev_set_config_notifier`).
> 
> To ensure this initialization, it’s better to allocate the entire
> `CryptoDevBackendVhost` structure (which includes `vhost_dev`) using
> `g_mem0()`, following the same approach used for other vhost devices,
> such as in `vhost_net_init()`.
> 
> Fixes: 042cea274c ("cryptodev: add vhost-user as a new cryptodev backend")
> Cc: qemu-stable@nongnu.org
> Reported-by: myluo24@m.fudan.edu.cn
> Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
> ---
>   backends/cryptodev-vhost.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/backends/cryptodev-vhost.c b/backends/cryptodev-vhost.c
> index 8718c97326..943680a23a 100644
> --- a/backends/cryptodev-vhost.c
> +++ b/backends/cryptodev-vhost.c
> @@ -53,7 +53,7 @@ cryptodev_vhost_init(
>       CryptoDevBackendVhost *crypto;
>       Error *local_err = NULL;
>   
> -    crypto = g_new(CryptoDevBackendVhost, 1);
> +    crypto = g_new0(CryptoDevBackendVhost, 1);
>       crypto->dev.max_queues = 1;
>       crypto->dev.nvqs = 1;
>       crypto->dev.vqs = crypto->vqs;