[v2] accel: Only include qdev-realized vCPUs in global &cpus_queue

[PATCH v2 01/10] bsd-user: drop not longer used target_reset_cpu()

Posted by Igor Mammedov 1 month, 3 weeks ago

target_reset_cpu() static inlines have no user,
remove them.

Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
CC: Warner Losh <imp@bsdimp.com>
CC: Kyle Evans <kevans@freebsd.org>
---
 bsd-user/aarch64/target_arch_cpu.h | 5 -----
 bsd-user/arm/target_arch_cpu.h     | 4 ----
 bsd-user/i386/target_arch_cpu.h    | 5 -----
 bsd-user/riscv/target_arch_cpu.h   | 4 ----
 bsd-user/x86_64/target_arch_cpu.h  | 5 -----
 5 files changed, 23 deletions(-)

diff --git a/bsd-user/aarch64/target_arch_cpu.h b/bsd-user/aarch64/target_arch_cpu.h
index 87fbf6d677..46a448e93f 100644
--- a/bsd-user/aarch64/target_arch_cpu.h
+++ b/bsd-user/aarch64/target_arch_cpu.h
@@ -181,9 +181,4 @@ static inline void target_cpu_clone_regs(CPUARMState *env, target_ulong newsp)
     pstate_write(env, 0);
 }
 
-static inline void target_cpu_reset(CPUArchState *env)
-{
-}
-
-
 #endif /* TARGET_ARCH_CPU_H */
diff --git a/bsd-user/arm/target_arch_cpu.h b/bsd-user/arm/target_arch_cpu.h
index bc2eaa0bf4..b9583b0f92 100644
--- a/bsd-user/arm/target_arch_cpu.h
+++ b/bsd-user/arm/target_arch_cpu.h
@@ -206,8 +206,4 @@ static inline void target_cpu_clone_regs(CPUARMState *env, target_ulong newsp)
     env->regs[0] = 0;
 }
 
-static inline void target_cpu_reset(CPUArchState *env)
-{
-}
-
 #endif /* TARGET_ARCH_CPU_H */
diff --git a/bsd-user/i386/target_arch_cpu.h b/bsd-user/i386/target_arch_cpu.h
index 5d4c931dec..371e702799 100644
--- a/bsd-user/i386/target_arch_cpu.h
+++ b/bsd-user/i386/target_arch_cpu.h
@@ -194,9 +194,4 @@ static inline void target_cpu_clone_regs(CPUX86State *env, target_ulong newsp)
     env->regs[R_EAX] = 0;
 }
 
-static inline void target_cpu_reset(CPUArchState *env)
-{
-    cpu_reset(env_cpu(env));
-}
-
 #endif /* TARGET_ARCH_CPU_H */
diff --git a/bsd-user/riscv/target_arch_cpu.h b/bsd-user/riscv/target_arch_cpu.h
index ef92f00480..d3cc5adbf4 100644
--- a/bsd-user/riscv/target_arch_cpu.h
+++ b/bsd-user/riscv/target_arch_cpu.h
@@ -141,8 +141,4 @@ static inline void target_cpu_clone_regs(CPURISCVState *env, target_ulong newsp)
     env->gpr[xT0] = 0;
 }
 
-static inline void target_cpu_reset(CPUArchState *env)
-{
-}
-
 #endif /* TARGET_ARCH_CPU_H */
diff --git a/bsd-user/x86_64/target_arch_cpu.h b/bsd-user/x86_64/target_arch_cpu.h
index f82042e30a..8ec5c65fab 100644
--- a/bsd-user/x86_64/target_arch_cpu.h
+++ b/bsd-user/x86_64/target_arch_cpu.h
@@ -169,9 +169,4 @@ static inline void target_cpu_clone_regs(CPUX86State *env, target_ulong newsp)
     env->regs[R_EAX] = 0;
 }
 
-static inline void target_cpu_reset(CPUArchState *env)
-{
-    cpu_reset(env_cpu(env));
-}
-
 #endif /* TARGET_ARCH_CPU_H */
-- 
2.43.0

Re: [PATCH v2 01/10] bsd-user: drop not longer used target_reset_cpu()

Posted by Warner Losh 1 month ago

On Fri, Feb 7, 2025 at 9:21 AM Igor Mammedov <imammedo@redhat.com> wrote:

> target_reset_cpu() static inlines have no user,
> remove them.
>
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> ---
> CC: Warner Losh <imp@bsdimp.com>
> CC: Kyle Evans <kevans@freebsd.org>
> ---
>  bsd-user/aarch64/target_arch_cpu.h | 5 -----
>  bsd-user/arm/target_arch_cpu.h     | 4 ----
>  bsd-user/i386/target_arch_cpu.h    | 5 -----
>  bsd-user/riscv/target_arch_cpu.h   | 4 ----
>  bsd-user/x86_64/target_arch_cpu.h  | 5 -----
>  5 files changed, 23 deletions(-)
>

Reviewed-by: Warner Losh <imp@bsdimp.com>

Warner


> diff --git a/bsd-user/aarch64/target_arch_cpu.h
> b/bsd-user/aarch64/target_arch_cpu.h
> index 87fbf6d677..46a448e93f 100644
> --- a/bsd-user/aarch64/target_arch_cpu.h
> +++ b/bsd-user/aarch64/target_arch_cpu.h
> @@ -181,9 +181,4 @@ static inline void target_cpu_clone_regs(CPUARMState
> *env, target_ulong newsp)
>      pstate_write(env, 0);
>  }
>
> -static inline void target_cpu_reset(CPUArchState *env)
> -{
> -}
> -
> -
>  #endif /* TARGET_ARCH_CPU_H */
> diff --git a/bsd-user/arm/target_arch_cpu.h
> b/bsd-user/arm/target_arch_cpu.h
> index bc2eaa0bf4..b9583b0f92 100644
> --- a/bsd-user/arm/target_arch_cpu.h
> +++ b/bsd-user/arm/target_arch_cpu.h
> @@ -206,8 +206,4 @@ static inline void target_cpu_clone_regs(CPUARMState
> *env, target_ulong newsp)
>      env->regs[0] = 0;
>  }
>
> -static inline void target_cpu_reset(CPUArchState *env)
> -{
> -}
> -
>  #endif /* TARGET_ARCH_CPU_H */
> diff --git a/bsd-user/i386/target_arch_cpu.h
> b/bsd-user/i386/target_arch_cpu.h
> index 5d4c931dec..371e702799 100644
> --- a/bsd-user/i386/target_arch_cpu.h
> +++ b/bsd-user/i386/target_arch_cpu.h
> @@ -194,9 +194,4 @@ static inline void target_cpu_clone_regs(CPUX86State
> *env, target_ulong newsp)
>      env->regs[R_EAX] = 0;
>  }
>
> -static inline void target_cpu_reset(CPUArchState *env)
> -{
> -    cpu_reset(env_cpu(env));
> -}
> -
>  #endif /* TARGET_ARCH_CPU_H */
> diff --git a/bsd-user/riscv/target_arch_cpu.h
> b/bsd-user/riscv/target_arch_cpu.h
> index ef92f00480..d3cc5adbf4 100644
> --- a/bsd-user/riscv/target_arch_cpu.h
> +++ b/bsd-user/riscv/target_arch_cpu.h
> @@ -141,8 +141,4 @@ static inline void target_cpu_clone_regs(CPURISCVState
> *env, target_ulong newsp)
>      env->gpr[xT0] = 0;
>  }
>
> -static inline void target_cpu_reset(CPUArchState *env)
> -{
> -}
> -
>  #endif /* TARGET_ARCH_CPU_H */
> diff --git a/bsd-user/x86_64/target_arch_cpu.h
> b/bsd-user/x86_64/target_arch_cpu.h
> index f82042e30a..8ec5c65fab 100644
> --- a/bsd-user/x86_64/target_arch_cpu.h
> +++ b/bsd-user/x86_64/target_arch_cpu.h
> @@ -169,9 +169,4 @@ static inline void target_cpu_clone_regs(CPUX86State
> *env, target_ulong newsp)
>      env->regs[R_EAX] = 0;
>  }
>
> -static inline void target_cpu_reset(CPUArchState *env)
> -{
> -    cpu_reset(env_cpu(env));
> -}
> -
>  #endif /* TARGET_ARCH_CPU_H */
> --
> 2.43.0
>
>

Re: [PATCH v2 01/10] bsd-user: drop not longer used target_reset_cpu()

Posted by Alex Bennée 1 month, 1 week ago

Igor Mammedov <imammedo@redhat.com> writes:

> target_reset_cpu() static inlines have no user,
> remove them.
>
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> ---
> CC: Warner Losh <imp@bsdimp.com>
> CC: Kyle Evans <kevans@freebsd.org>

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro