[v1] target/riscv: declarative CPU definitions

[PATCH 01/22] target/riscv: remove unused macro DEFINE_CPU

Posted by Paolo Bonzini 1 month, 3 weeks ago

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 target/riscv/cpu.c | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c
index 3d4bd157d2c..ed9da692030 100644
--- a/target/riscv/cpu.c
+++ b/target/riscv/cpu.c
@@ -3051,15 +3051,6 @@ void riscv_isa_write_fdt(RISCVCPU *cpu, void *fdt, char *nodename)
 }
 #endif
 
-#define DEFINE_CPU(type_name, misa_mxl_max, initfn)         \
-    {                                                       \
-        .name = (type_name),                                \
-        .parent = TYPE_RISCV_CPU,                           \
-        .instance_init = (initfn),                          \
-        .class_init = riscv_cpu_class_init,                 \
-        .class_data = (void *)(misa_mxl_max)                \
-    }
-
 #define DEFINE_DYNAMIC_CPU(type_name, misa_mxl_max, initfn) \
     {                                                       \
         .name = (type_name),                                \
-- 
2.48.1

Re: [PATCH 01/22] target/riscv: remove unused macro DEFINE_CPU

Posted by Alistair Francis 1 month, 3 weeks ago

On Fri, Feb 7, 2025 at 4:29 AM Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Reviewed-by: Alistair Francis <alistair.francis@wdc.com>

Alistair

> ---
>  target/riscv/cpu.c | 9 ---------
>  1 file changed, 9 deletions(-)
>
> diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c
> index 3d4bd157d2c..ed9da692030 100644
> --- a/target/riscv/cpu.c
> +++ b/target/riscv/cpu.c
> @@ -3051,15 +3051,6 @@ void riscv_isa_write_fdt(RISCVCPU *cpu, void *fdt, char *nodename)
>  }
>  #endif
>
> -#define DEFINE_CPU(type_name, misa_mxl_max, initfn)         \
> -    {                                                       \
> -        .name = (type_name),                                \
> -        .parent = TYPE_RISCV_CPU,                           \
> -        .instance_init = (initfn),                          \
> -        .class_init = riscv_cpu_class_init,                 \
> -        .class_data = (void *)(misa_mxl_max)                \
> -    }
> -
>  #define DEFINE_DYNAMIC_CPU(type_name, misa_mxl_max, initfn) \
>      {                                                       \
>          .name = (type_name),                                \
> --
> 2.48.1
>
>