[PATCH v2 2/2] target/sparc: Fix register selection for all F*TOx and FxTO* instructions

Mikael Szreder posted 2 patches 1 year ago
[PATCH v2 2/2] target/sparc: Fix register selection for all F*TOx and FxTO* instructions
Posted by Mikael Szreder 1 year ago
Fixed a mistake I made in the FqTOx instruction.
Fixed issues in the FsTOx, FxTOs, FxTOd, FxTOq instructions.

Fixes: 0bba7572d40d ("target/sparc: Perform DFPREG/QFPREG in decodetree")
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2802
Signed-off-by: Mikael Szreder <git@miszr.win>
---
 target/sparc/insns.decode | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/target/sparc/insns.decode b/target/sparc/insns.decode
index 694a28d88c..cfcdf6690e 100644
--- a/target/sparc/insns.decode
+++ b/target/sparc/insns.decode
@@ -321,12 +321,12 @@ FdMULq      10 ..... 110100 ..... 0 0110 1110 .....        @q_d_d
 FNHADDs     10 ..... 110100 ..... 0 0111 0001 .....        @r_r_r
 FNHADDd     10 ..... 110100 ..... 0 0111 0010 .....        @d_d_d
 FNsMULd     10 ..... 110100 ..... 0 0111 1001 .....        @d_r_r
-FsTOx       10 ..... 110100 00000 0 1000 0001 .....        @r_r2
+FsTOx       10 ..... 110100 00000 0 1000 0001 .....        @d_r2
 FdTOx       10 ..... 110100 00000 0 1000 0010 .....        @d_d2
-FqTOx       10 ..... 110100 00000 0 1000 0011 .....        @q_q2
-FxTOs       10 ..... 110100 00000 0 1000 0100 .....        @r_r2
-FxTOd       10 ..... 110100 00000 0 1000 1000 .....        @d_r2
-FxTOq       10 ..... 110100 00000 0 1000 1100 .....        @q_r2
+FqTOx       10 ..... 110100 00000 0 1000 0011 .....        @d_q2
+FxTOs       10 ..... 110100 00000 0 1000 0100 .....        @r_d2
+FxTOd       10 ..... 110100 00000 0 1000 1000 .....        @d_d2
+FxTOq       10 ..... 110100 00000 0 1000 1100 .....        @q_d2
 FiTOs       10 ..... 110100 00000 0 1100 0100 .....        @r_r2
 FdTOs       10 ..... 110100 00000 0 1100 0110 .....        @r_d2
 FqTOs       10 ..... 110100 00000 0 1100 0111 .....        @r_q2
-- 
2.48.1
Re: [PATCH v2 2/2] target/sparc: Fix register selection for all F*TOx and FxTO* instructions
Posted by Artyom Tarasenko 12 months ago
On Wed, Feb 5, 2025 at 10:03 AM Mikael Szreder <git@miszr.win> wrote:
>
> Fixed a mistake I made in the FqTOx instruction.
> Fixed issues in the FsTOx, FxTOs, FxTOd, FxTOq instructions.
>
> Fixes: 0bba7572d40d ("target/sparc: Perform DFPREG/QFPREG in decodetree")
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2802
> Signed-off-by: Mikael Szreder <git@miszr.win>

Acked-by: Artyom Tarasenko <atar4qemu@gmail.com>

> ---
>  target/sparc/insns.decode | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/target/sparc/insns.decode b/target/sparc/insns.decode
> index 694a28d88c..cfcdf6690e 100644
> --- a/target/sparc/insns.decode
> +++ b/target/sparc/insns.decode
> @@ -321,12 +321,12 @@ FdMULq      10 ..... 110100 ..... 0 0110 1110 .....        @q_d_d
>  FNHADDs     10 ..... 110100 ..... 0 0111 0001 .....        @r_r_r
>  FNHADDd     10 ..... 110100 ..... 0 0111 0010 .....        @d_d_d
>  FNsMULd     10 ..... 110100 ..... 0 0111 1001 .....        @d_r_r
> -FsTOx       10 ..... 110100 00000 0 1000 0001 .....        @r_r2
> +FsTOx       10 ..... 110100 00000 0 1000 0001 .....        @d_r2
>  FdTOx       10 ..... 110100 00000 0 1000 0010 .....        @d_d2
> -FqTOx       10 ..... 110100 00000 0 1000 0011 .....        @q_q2
> -FxTOs       10 ..... 110100 00000 0 1000 0100 .....        @r_r2
> -FxTOd       10 ..... 110100 00000 0 1000 1000 .....        @d_r2
> -FxTOq       10 ..... 110100 00000 0 1000 1100 .....        @q_r2
> +FqTOx       10 ..... 110100 00000 0 1000 0011 .....        @d_q2
> +FxTOs       10 ..... 110100 00000 0 1000 0100 .....        @r_d2
> +FxTOd       10 ..... 110100 00000 0 1000 1000 .....        @d_d2
> +FxTOq       10 ..... 110100 00000 0 1000 1100 .....        @q_d2
>  FiTOs       10 ..... 110100 00000 0 1100 0100 .....        @r_r2
>  FdTOs       10 ..... 110100 00000 0 1100 0110 .....        @r_d2
>  FqTOs       10 ..... 110100 00000 0 1100 0111 .....        @r_q2
> --
> 2.48.1
>