tests/qtest/vhost-user-test: Use modern virtio for vhost-user tests

[PATCH] tests/qtest/vhost-user-test: Use modern virtio for vhost-user tests

Posted by Thomas Huth 1 year ago

All other vhost-user tests here use modern virtio, too, so let's
adjust the vhost-user-net test accordingly.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 tests/qtest/vhost-user-test.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tests/qtest/vhost-user-test.c b/tests/qtest/vhost-user-test.c
index 76d142a158..bd977ef28d 100644
--- a/tests/qtest/vhost-user-test.c
+++ b/tests/qtest/vhost-user-test.c
@@ -1043,7 +1043,8 @@ static void test_multiqueue(void *obj, void *arg, QGuestAllocator *alloc)
 
 static uint64_t vu_net_get_features(TestServer *s)
 {
-    uint64_t features = 0x1ULL << VHOST_F_LOG_ALL |
+    uint64_t features = 0x1ULL << VIRTIO_F_VERSION_1 |
+        0x1ULL << VHOST_F_LOG_ALL |
         0x1ULL << VHOST_USER_F_PROTOCOL_FEATURES;
 
     if (s->queues > 1) {
-- 
2.48.1

Re: [PATCH] tests/qtest/vhost-user-test: Use modern virtio for vhost-user tests

Posted by Stefano Garzarella 12 months ago

On Mon, Feb 03, 2025 at 01:43:46PM +0100, Thomas Huth wrote:
>All other vhost-user tests here use modern virtio, too, so let's
>adjust the vhost-user-net test accordingly.
>
>Signed-off-by: Thomas Huth <thuth@redhat.com>
>---
> tests/qtest/vhost-user-test.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)

Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>

>
>diff --git a/tests/qtest/vhost-user-test.c b/tests/qtest/vhost-user-test.c
>index 76d142a158..bd977ef28d 100644
>--- a/tests/qtest/vhost-user-test.c
>+++ b/tests/qtest/vhost-user-test.c
>@@ -1043,7 +1043,8 @@ static void test_multiqueue(void *obj, void *arg, QGuestAllocator *alloc)
>
> static uint64_t vu_net_get_features(TestServer *s)
> {
>-    uint64_t features = 0x1ULL << VHOST_F_LOG_ALL |
>+    uint64_t features = 0x1ULL << VIRTIO_F_VERSION_1 |
>+        0x1ULL << VHOST_F_LOG_ALL |
>         0x1ULL << VHOST_USER_F_PROTOCOL_FEATURES;
>
>     if (s->queues > 1) {
>-- 
>2.48.1
>

Re: [PATCH] tests/qtest/vhost-user-test: Use modern virtio for vhost-user tests

Posted by Fabiano Rosas 1 year ago

Thomas Huth <thuth@redhat.com> writes:

> All other vhost-user tests here use modern virtio, too, so let's
> adjust the vhost-user-net test accordingly.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  tests/qtest/vhost-user-test.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tests/qtest/vhost-user-test.c b/tests/qtest/vhost-user-test.c
> index 76d142a158..bd977ef28d 100644
> --- a/tests/qtest/vhost-user-test.c
> +++ b/tests/qtest/vhost-user-test.c
> @@ -1043,7 +1043,8 @@ static void test_multiqueue(void *obj, void *arg, QGuestAllocator *alloc)
>  
>  static uint64_t vu_net_get_features(TestServer *s)
>  {
> -    uint64_t features = 0x1ULL << VHOST_F_LOG_ALL |
> +    uint64_t features = 0x1ULL << VIRTIO_F_VERSION_1 |
> +        0x1ULL << VHOST_F_LOG_ALL |
>          0x1ULL << VHOST_USER_F_PROTOCOL_FEATURES;
>  
>      if (s->queues > 1) {

Reviewed-by: Fabiano Rosas <farosas@suse.de>