[v2] vfio: Improve error reporting when MMIO region mapping fails

[PATCH v2 2/9] vfio/pci: Replace "iommu_device" by "vIOMMU"

Posted by Cédric Le Goater 2 months ago

This is to be consistent with other reported errors related to vIOMMU
devices.

Signed-off-by: Cédric Le Goater <clg@redhat.com>
---
 hw/vfio/pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
index 1b90c78c5a1927b1553c59de7a470544bc07788a..90570e9e4ee571d3ec5a7f7b302b1e7e7f0c9a33 100644
--- a/hw/vfio/pci.c
+++ b/hw/vfio/pci.c
@@ -3116,7 +3116,7 @@ static void vfio_realize(PCIDevice *pdev, Error **errp)
 
     if (!vbasedev->mdev &&
         !pci_device_set_iommu_device(pdev, vbasedev->hiod, errp)) {
-        error_prepend(errp, "Failed to set iommu_device: ");
+        error_prepend(errp, "Failed to set vIOMMU: ");
         goto out_teardown;
     }
 
-- 
2.48.1

Re: [PATCH v2 2/9] vfio/pci: Replace "iommu_device" by "vIOMMU"

Posted by Philippe Mathieu-Daudé 1 month, 3 weeks ago

On 30/1/25 14:43, Cédric Le Goater wrote:
> This is to be consistent with other reported errors related to vIOMMU
> devices.
> 
> Signed-off-by: Cédric Le Goater <clg@redhat.com>
> ---
>   hw/vfio/pci.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>