On 1/28/25 06:21, Philippe Mathieu-Daudé wrote:
> Previous commit passed all our CI tests, this assertion being
> never triggered. Remove it as dead code.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> accel/kvm/kvm-all.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c
> index cb56d120a91..814b1a53eb8 100644
> --- a/accel/kvm/kvm-all.c
> +++ b/accel/kvm/kvm-all.c
> @@ -830,13 +830,6 @@ static uint32_t kvm_dirty_ring_reap_one(KVMState *s, CPUState *cpu)
> uint32_t ring_size = s->kvm_dirty_ring_size;
> uint32_t count = 0, fetch = cpu->kvm_fetch_index;
>
> - /*
> - * It's not possible that we race with vcpu creation code where the vcpu is
> - * put onto the vcpus list but not yet initialized the dirty ring
> - * structures.
> - */
> - assert(cpu->created);
> -
> assert(dirty_gfns && ring_size);
> trace_kvm_dirty_ring_reap_vcpu(cpu->cpu_index);
>
I'd be ok squashing this, but also ok with retaining the patch separate for the CI comment.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~