[v2] target/ppc: Move TCG code from excp_helper.c to tcg-excp_helper.c

[PATCH v2 00/15] target/ppc: Move TCG code from excp_helper.c to tcg-excp_helper.c

Posted by Philippe Mathieu-Daudé 2 months, 1 week ago

Since v1:
- Keep ppc_tcg_hv_emu() within TARGET_PPC64 (patch #10)

Hi,

This series is a simply a cleanup restricting TCG specific
exception-related code to TCG, by moving code to a new unit
named 'tcg-excp_helper.c'.

I ended doing it as a preliminary cleanup for the "Extract
TCG state from CPUState".

Diffstat shows 1K lines moved, but the patches are trivial
to review using 'git-diff --color-moved=dimmed-zebra' option.

Branch published as:
 https://gitlab.com/philmd/qemu/-/tree/ppc_excp_extract_tcg

Regards,

Phil.

Philippe Mathieu-Daudé (15):
  hw/ppc/spapr: Restrict CONFER hypercall to TCG
  hw/ppc/spapr: Restrict part of PAGE_INIT hypercall to TCG
  target/ppc: Make ppc_ldl_code() declaration public
  target/ppc: Move TCG specific exception handlers to tcg-excp_helper.c
  target/ppc: Move ppc_ldl_code() to tcg-excp_helper.c
  target/ppc: Ensure powerpc_checkstop() is only called under TCG
  target/ppc: Restrict powerpc_checkstop() to TCG
  target/ppc: Remove raise_exception_ra()
  target/ppc: Restrict exception helpers to TCG
  target/ppc: Restrict ppc_tcg_hv_emu() to TCG
  target/ppc: Restrict various common helpers to TCG
  target/ppc: Fix style in excp_helper.c
  target/ppc: Make powerpc_excp() prototype public
  target/ppc: Restrict ATTN / SCV / PMINSN helpers to TCG
  target/ppc: Restrict various system helpers to TCG

 target/ppc/cpu.h             |   5 -
 target/ppc/internal.h        |  11 +-
 hw/ppc/spapr_hcall.c         |   6 +-
 target/ppc/excp_helper.c     | 943 +----------------------------------
 target/ppc/tcg-excp_helper.c | 924 ++++++++++++++++++++++++++++++++++
 target/ppc/meson.build       |   1 +
 6 files changed, 955 insertions(+), 935 deletions(-)
 create mode 100644 target/ppc/tcg-excp_helper.c

-- 
2.47.1

Re: [PATCH v2 00/15] target/ppc: Move TCG code from excp_helper.c to tcg-excp_helper.c

Posted by Nicholas Piggin 3 weeks, 3 days ago

On Mon Jan 27, 2025 at 8:26 PM AEST, Philippe Mathieu-Daudé wrote:
> Since v1:
> - Keep ppc_tcg_hv_emu() within TARGET_PPC64 (patch #10)
>
> Hi,
>
> This series is a simply a cleanup restricting TCG specific
> exception-related code to TCG, by moving code to a new unit
> named 'tcg-excp_helper.c'.
>
> I ended doing it as a preliminary cleanup for the "Extract
> TCG state from CPUState".
>
> Diffstat shows 1K lines moved, but the patches are trivial
> to review using 'git-diff --color-moved=dimmed-zebra' option.
>
> Branch published as:
>  https://gitlab.com/philmd/qemu/-/tree/ppc_excp_extract_tcg
>
> Regards,
>
> Phil.

I pulled this in and just added some minor changelog and comment
and subject line tweaks noticed in review.

Patch 2 was already merged, patch 10 I left out because it had a
few possible issues (but it generally looks good if you plan to
resubmit it some time).

Thanks very much, it's a nice cleanup. Sorry I have been slow
with things...

Thanks,
Nick

>
> Philippe Mathieu-Daudé (15):
>   hw/ppc/spapr: Restrict CONFER hypercall to TCG
>   hw/ppc/spapr: Restrict part of PAGE_INIT hypercall to TCG
>   target/ppc: Make ppc_ldl_code() declaration public
>   target/ppc: Move TCG specific exception handlers to tcg-excp_helper.c
>   target/ppc: Move ppc_ldl_code() to tcg-excp_helper.c
>   target/ppc: Ensure powerpc_checkstop() is only called under TCG
>   target/ppc: Restrict powerpc_checkstop() to TCG
>   target/ppc: Remove raise_exception_ra()
>   target/ppc: Restrict exception helpers to TCG
>   target/ppc: Restrict ppc_tcg_hv_emu() to TCG
>   target/ppc: Restrict various common helpers to TCG
>   target/ppc: Fix style in excp_helper.c
>   target/ppc: Make powerpc_excp() prototype public
>   target/ppc: Restrict ATTN / SCV / PMINSN helpers to TCG
>   target/ppc: Restrict various system helpers to TCG
>
>  target/ppc/cpu.h             |   5 -
>  target/ppc/internal.h        |  11 +-
>  hw/ppc/spapr_hcall.c         |   6 +-
>  target/ppc/excp_helper.c     | 943 +----------------------------------
>  target/ppc/tcg-excp_helper.c | 924 ++++++++++++++++++++++++++++++++++
>  target/ppc/meson.build       |   1 +
>  6 files changed, 955 insertions(+), 935 deletions(-)
>  create mode 100644 target/ppc/tcg-excp_helper.c

Re: [PATCH v2 00/15] target/ppc: Move TCG code from excp_helper.c to tcg-excp_helper.c

Posted by Philippe Mathieu-Daudé 3 weeks, 3 days ago

On 11/3/25 07:22, Nicholas Piggin wrote:
> On Mon Jan 27, 2025 at 8:26 PM AEST, Philippe Mathieu-Daudé wrote:

>> This series is a simply a cleanup restricting TCG specific
>> exception-related code to TCG, by moving code to a new unit
>> named 'tcg-excp_helper.c'.


> I pulled this in and just added some minor changelog and comment
> and subject line tweaks noticed in review.
> 
> Patch 2 was already merged, patch 10 I left out because it had a
> few possible issues (but it generally looks good if you plan to
> resubmit it some time).

Thank you Nick, I will!

> 
> Thanks very much, it's a nice cleanup. Sorry I have been slow
> with things...
> 
> Thanks,
> Nick