[v2] hw/usb/hcd-ehci: Fix debug printf format string

[PATCH v2] hw/usb/hcd-ehci: Fix debug printf format string

BALATON Zoltan posted 1 patch 2 months, 1 week ago

Diff against v1 v3
Download mbox

There is a newer version of this series

hw/usb/hcd-ehci.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

Expand all Fold all

[PATCH v2] hw/usb/hcd-ehci: Fix debug printf format string

Posted by BALATON Zoltan 2 months, 1 week ago

The variable is uint64_t so needs %ld instead of %d.

Fixes: 3ae7eb88c47 ("ehci: fix overflow in frame timer code")
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
---
 hw/usb/hcd-ehci.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c
index 6c4c14c895..b090f25365 100644
--- a/hw/usb/hcd-ehci.c
+++ b/hw/usb/hcd-ehci.c
@@ -2287,7 +2287,8 @@ static void ehci_work_bh(void *opaque)
             ehci_update_frindex(ehci, skipped_uframes);
             ehci->last_run_ns += UFRAME_TIMER_NS * skipped_uframes;
             uframes -= skipped_uframes;
-            DPRINTF("WARNING - EHCI skipped %d uframes\n", skipped_uframes);
+            DPRINTF("WARNING - EHCI skipped %"PRIu64" uframes\n",
+                    skipped_uframes);
         }
 
         for (i = 0; i < uframes; i++) {
-- 
2.30.9

Re: [PATCH v2] hw/usb/hcd-ehci: Fix debug printf format string

Posted by Peter Maydell 2 months, 1 week ago

On Fri, 24 Jan 2025 at 02:53, BALATON Zoltan <balaton@eik.bme.hu> wrote:
>
> The variable is uint64_t so needs %ld instead of %d.
>
> Fixes: 3ae7eb88c47 ("ehci: fix overflow in frame timer code")
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> ---
>  hw/usb/hcd-ehci.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM