announce_self that sends a RARP packet after migration
or with announce_self QMP/HMP command doesn't work with
vhost because of the vnet headers.

announce_self is the only user of QEMU_NET_PACKET_FLAG_RAW and
this flag is not correctly managed.

This series fix a problem with this flag in filter-dump and in
qemu_deliver_packet_iov().

Laurent Vivier (2):
  net: Fix announce_self
  net/dump: Correctly compute Ethernet packet offset

 net/dump.c | 3 ++-
 net/net.c  | 1 +
 2 files changed, 3 insertions(+), 1 deletion(-)

-- 
2.47.1

17.01.2025 14:17, Laurent Vivier wrote:
> announce_self that sends a RARP packet after migration
> or with announce_self QMP/HMP command doesn't work with
> vhost because of the vnet headers.
> 
> announce_self is the only user of QEMU_NET_PACKET_FLAG_RAW and
> this flag is not correctly managed.
> 
> This series fix a problem with this flag in filter-dump and in
> qemu_deliver_packet_iov().
> 
> Laurent Vivier (2):
>    net: Fix announce_self
>    net/dump: Correctly compute Ethernet packet offset
> 
>   net/dump.c | 3 ++-
>   net/net.c  | 1 +
>   2 files changed, 3 insertions(+), 1 deletion(-)

Reviewed-by: Michael Tokarev <mjt@tls.msk.ru>

Applied to trivial-patches and queued for qemu-stable.

Thanks,

/mjt

On 18/01/2025 21:20, Michael Tokarev wrote:
> 17.01.2025 14:17, Laurent Vivier wrote:
>> announce_self that sends a RARP packet after migration
>> or with announce_self QMP/HMP command doesn't work with
>> vhost because of the vnet headers.
>>
>> announce_self is the only user of QEMU_NET_PACKET_FLAG_RAW and
>> this flag is not correctly managed.
>>
>> This series fix a problem with this flag in filter-dump and in
>> qemu_deliver_packet_iov().
>>
>> Laurent Vivier (2):
>>    net: Fix announce_self
>>    net/dump: Correctly compute Ethernet packet offset
>>
>>   net/dump.c | 3 ++-
>>   net/net.c  | 1 +
>>   2 files changed, 3 insertions(+), 1 deletion(-)
> 
> Reviewed-by: Michael Tokarev <mjt@tls.msk.ru>
> 
> Applied to trivial-patches and queued for qemu-stable.
> 

When do you plan to send the PR for them?

Thanks,
Laurent

30.01.2025 12:29, Laurent Vivier wrote:
> When do you plan to send the PR for them?

Um, sorry for the delay.  Will do ASAP.

Thank you for the reminder!

/mjt

CC: qemu-stable and qemu-trivial.

On 17/01/2025 12:17, Laurent Vivier wrote:
> announce_self that sends a RARP packet after migration
> or with announce_self QMP/HMP command doesn't work with
> vhost because of the vnet headers.
> 
> announce_self is the only user of QEMU_NET_PACKET_FLAG_RAW and
> this flag is not correctly managed.
> 
> This series fix a problem with this flag in filter-dump and in
> qemu_deliver_packet_iov().
> 
> Laurent Vivier (2):
>    net: Fix announce_self
>    net/dump: Correctly compute Ethernet packet offset
> 
>   net/dump.c | 3 ++-
>   net/net.c  | 1 +
>   2 files changed, 3 insertions(+), 1 deletion(-)
>

17.01.2025 17:05, Laurent Vivier wrote:
> CC: qemu-stable and qemu-trivial.
> 
> On 17/01/2025 12:17, Laurent Vivier wrote:
>> announce_self that sends a RARP packet after migration
>> or with announce_self QMP/HMP command doesn't work with
>> vhost because of the vnet headers.
>>
>> announce_self is the only user of QEMU_NET_PACKET_FLAG_RAW and
>> this flag is not correctly managed.
>>
>> This series fix a problem with this flag in filter-dump and in
>> qemu_deliver_packet_iov().
>>
>> Laurent Vivier (2):
>>    net: Fix announce_self
>>    net/dump: Correctly compute Ethernet packet offset

Is this one - "Correctly compute Ethernet packet offset" - needed for
older stable series too, like 8.2 and 7.2 (currently active ones)?

Since it doesn't apply without 4b52d63249 (tap: Remove qemu_using_vnet_hdr()).

Thanks,

/mjt

Le 01/02/2025 à 20:36, Michael Tokarev a écrit :
> 17.01.2025 17:05, Laurent Vivier wrote:
>> CC: qemu-stable and qemu-trivial.
>>
>> On 17/01/2025 12:17, Laurent Vivier wrote:
>>> announce_self that sends a RARP packet after migration
>>> or with announce_self QMP/HMP command doesn't work with
>>> vhost because of the vnet headers.
>>>
>>> announce_self is the only user of QEMU_NET_PACKET_FLAG_RAW and
>>> this flag is not correctly managed.
>>>
>>> This series fix a problem with this flag in filter-dump and in
>>> qemu_deliver_packet_iov().
>>>
>>> Laurent Vivier (2):
>>>    net: Fix announce_self
>>>    net/dump: Correctly compute Ethernet packet offset
> 
> Is this one - "Correctly compute Ethernet packet offset" - needed for
> older stable series too, like 8.2 and 7.2 (currently active ones)?
> 
> Since it doesn't apply without 4b52d63249 (tap: Remove qemu_using_vnet_hdr()).

It fixes 481c52320a26 ("net: Strip virtio-net header when dumping") that is only in 8.0.
But I'm not sure the bug exists without 4b52d63249 (tap: Remove qemu_using_vnet_hdr()), so it should 
be tested first.

Thanks,
Laurent