hw/arm/stellaris: Fix overwritten IRQs and cleanups

[PATCH 1/9] hw/arm/stellaris: Link each board schematic

Posted by Philippe Mathieu-Daudé 2 months, 3 weeks ago

Board schematic is useful to corroborate GPIOs/IRQs wiring.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 hw/arm/stellaris.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/hw/arm/stellaris.c b/hw/arm/stellaris.c
index 1bba96df14e..9b414ff9069 100644
--- a/hw/arm/stellaris.c
+++ b/hw/arm/stellaris.c
@@ -1379,6 +1379,10 @@ static void lm3s6965evb_init(MachineState *machine)
     stellaris_init(machine, &stellaris_boards[1]);
 }
 
+/*
+ * Stellaris LM3S811 Evaluation Board Schematics:
+ * http://www.ti.com/lit/ug/symlink/spmu030.pdf
+ */
 static void lm3s811evb_class_init(ObjectClass *oc, void *data)
 {
     MachineClass *mc = MACHINE_CLASS(oc);
@@ -1395,6 +1399,10 @@ static const TypeInfo lm3s811evb_type = {
     .class_init = lm3s811evb_class_init,
 };
 
+/*
+ * Stellaris: LM3S6965 Evaluation Board Schematics:
+ * http://www.ti.com/lit/ug/symlink/spmu029.pdf
+ */
 static void lm3s6965evb_class_init(ObjectClass *oc, void *data)
 {
     MachineClass *mc = MACHINE_CLASS(oc);
-- 
2.47.1

Re: [PATCH 1/9] hw/arm/stellaris: Link each board schematic

Posted by Peter Maydell 2 months, 1 week ago

On Fri, 10 Jan 2025 at 16:02, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
>
> Board schematic is useful to corroborate GPIOs/IRQs wiring.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>  hw/arm/stellaris.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/hw/arm/stellaris.c b/hw/arm/stellaris.c
> index 1bba96df14e..9b414ff9069 100644
> --- a/hw/arm/stellaris.c
> +++ b/hw/arm/stellaris.c
> @@ -1379,6 +1379,10 @@ static void lm3s6965evb_init(MachineState *machine)
>      stellaris_init(machine, &stellaris_boards[1]);
>  }
>
> +/*
> + * Stellaris LM3S811 Evaluation Board Schematics:
> + * http://www.ti.com/lit/ug/symlink/spmu030.pdf
> + */
>  static void lm3s811evb_class_init(ObjectClass *oc, void *data)
>  {
>      MachineClass *mc = MACHINE_CLASS(oc);
> @@ -1395,6 +1399,10 @@ static const TypeInfo lm3s811evb_type = {
>      .class_init = lm3s811evb_class_init,
>  };
>
> +/*
> + * Stellaris: LM3S6965 Evaluation Board Schematics:
> + * http://www.ti.com/lit/ug/symlink/spmu029.pdf
> + */

I think we should prefer https:// (I checked, and both work);
otherwise

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM