testing/next: functional tests, qtest clocks, vm and keymaps (pre-PR-FINAL)

[PATCH v4 21/32] tests/functional: remove unused kernel_command_line

Posted by Alex Bennée 2 months, 4 weeks ago

The Alpine test boots from the CDROM so we don't --append a command
line. Drop the unused code.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 tests/functional/test_aarch64_virt.py | 2 --
 1 file changed, 2 deletions(-)

diff --git a/tests/functional/test_aarch64_virt.py b/tests/functional/test_aarch64_virt.py
index 2d9995a95d..b3d3b0ee51 100755
--- a/tests/functional/test_aarch64_virt.py
+++ b/tests/functional/test_aarch64_virt.py
@@ -41,8 +41,6 @@ def test_alpine_virt_tcg_gic_max(self):
 
         self.set_machine('virt')
         self.vm.set_console()
-        kernel_command_line = (self.KERNEL_COMMON_COMMAND_LINE +
-                               'console=ttyAMA0')
         self.require_accelerator("tcg")
 
         self.vm.add_args("-accel", "tcg")
-- 
2.39.5

Re: [PATCH v4 21/32] tests/functional: remove unused kernel_command_line

Posted by Thomas Huth 2 months, 4 weeks ago

On 08/01/2025 13.10, Alex Bennée wrote:
> The Alpine test boots from the CDROM so we don't --append a command
> line. Drop the unused code.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>   tests/functional/test_aarch64_virt.py | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/tests/functional/test_aarch64_virt.py b/tests/functional/test_aarch64_virt.py
> index 2d9995a95d..b3d3b0ee51 100755
> --- a/tests/functional/test_aarch64_virt.py
> +++ b/tests/functional/test_aarch64_virt.py
> @@ -41,8 +41,6 @@ def test_alpine_virt_tcg_gic_max(self):
>   
>           self.set_machine('virt')
>           self.vm.set_console()
> -        kernel_command_line = (self.KERNEL_COMMON_COMMAND_LINE +
> -                               'console=ttyAMA0')
>           self.require_accelerator("tcg")
>   
>           self.vm.add_args("-accel", "tcg")

Reviewed-by: Thomas Huth <thuth@redhat.com>