[v3] Add new PowerPC Special Purpose Registers

[PATCH v3 0/2] Add new PowerPC Special Purpose Registers

Posted by dan tan 2 months, 4 weeks ago

From: dan tan <dantan@linux.ibm.com>

*** BLURB HERE ***
Version 3 summary:
    RWMR (Region Weighted Mode Register) -
        - change the register to generic read/write from nop/write

Version 2 summary:
    (DAWR1,DAWRX1):
        - spec reference: https://files.openpower.foundation/s/EgCy7C43p2NSRfR
        - corrected commit message format
        - combine DAWR(0/1) handling into a single function
        - add DAWR1 & DAWRX1 to init_proc_POWER10() only.

    RWMR (Region Weighted Mode Register) -
        - corrected the previous definition as ITV1
        - spec reference:
            https://ibm.ent.box.com/s/tmklq90ze7aj8f4n32er1mu3sy9u8k3k (Power9)
        - it appears that part of the previous upstream request SPRs
          (SPR_POWER_MMCR3, SPR_POWER_SIER2, SPR_POWER_SIER3) are
          already in the current master. Therefore, removed those
          from this request.

dan tan (2):
  ppc/pnv: Add new PowerPC Special Purpose Registers (DAWR1,DAWRX1)
  ppc/pnv: Add new PowerPC Special Purpose Registers (RWMR)

 include/hw/ppc/spapr.h   |  2 +-
 target/ppc/cpu.h         |  8 +++--
 target/ppc/helper.h      |  4 +--
 target/ppc/spr_common.h  |  2 ++
 hw/ppc/spapr_hcall.c     | 24 ++++++++------
 target/ppc/cpu.c         | 69 ++++++++++++++++++++++++++--------------
 target/ppc/cpu_init.c    | 20 ++++++++++++
 target/ppc/excp_helper.c | 11 ++++++-
 target/ppc/machine.c     |  5 ++-
 target/ppc/misc_helper.c |  8 ++---
 target/ppc/translate.c   | 21 ++++++++++--
 11 files changed, 127 insertions(+), 47 deletions(-)

-- 
2.39.5

Re: [PATCH v3 0/2] Add new PowerPC Special Purpose Registers

Posted by Harsh Prateek Bora 2 months, 3 weeks ago

+ Shivaprasad (had posted patches for DAWR1/DAWRX1 earlier)

https://lore.kernel.org/qemu-devel/170679876639.188422.11634974895844092362.stgit@ltc-boston1.aus.stglabs.ibm.com/

On 1/8/25 02:21, dan tan wrote:
> From: dan tan <dantan@linux.ibm.com>
> 
> *** BLURB HERE ***
> Version 3 summary:
>      RWMR (Region Weighted Mode Register) -
>          - change the register to generic read/write from nop/write
> 
> Version 2 summary:
>      (DAWR1,DAWRX1):
>          - spec reference: https://files.openpower.foundation/s/EgCy7C43p2NSRfR
>          - corrected commit message format
>          - combine DAWR(0/1) handling into a single function
>          - add DAWR1 & DAWRX1 to init_proc_POWER10() only.
> 
>      RWMR (Region Weighted Mode Register) -
>          - corrected the previous definition as ITV1
>          - spec reference:
>              https://ibm.ent.box.com/s/tmklq90ze7aj8f4n32er1mu3sy9u8k3k (Power9)
>          - it appears that part of the previous upstream request SPRs
>            (SPR_POWER_MMCR3, SPR_POWER_SIER2, SPR_POWER_SIER3) are
>            already in the current master. Therefore, removed those
>            from this request.
> 
> dan tan (2):
>    ppc/pnv: Add new PowerPC Special Purpose Registers (DAWR1,DAWRX1)
>    ppc/pnv: Add new PowerPC Special Purpose Registers (RWMR)
> 
>   include/hw/ppc/spapr.h   |  2 +-
>   target/ppc/cpu.h         |  8 +++--
>   target/ppc/helper.h      |  4 +--
>   target/ppc/spr_common.h  |  2 ++
>   hw/ppc/spapr_hcall.c     | 24 ++++++++------
>   target/ppc/cpu.c         | 69 ++++++++++++++++++++++++++--------------
>   target/ppc/cpu_init.c    | 20 ++++++++++++
>   target/ppc/excp_helper.c | 11 ++++++-
>   target/ppc/machine.c     |  5 ++-
>   target/ppc/misc_helper.c |  8 ++---
>   target/ppc/translate.c   | 21 ++++++++++--
>   11 files changed, 127 insertions(+), 47 deletions(-)
>

Re: [PATCH v3 0/2] Add new PowerPC Special Purpose Registers

Posted by dan tan 2 months, 3 weeks ago

Hi Harsh,

Thank you for pointing that out!
I will withdraw my submission.

regards,
--
email:dantan@linux.ibm.com


On 2025-01-08 00:17, Harsh Prateek Bora wrote:
> + Shivaprasad (had posted patches for DAWR1/DAWRX1 earlier)
> 
> https://lore.kernel.org/qemu-devel/170679876639.188422.11634974895844092362.stgit@ltc-boston1.aus.stglabs.ibm.com/
> 
> On 1/8/25 02:21, dan tan wrote:
>> From: dan tan <dantan@linux.ibm.com>
>> 
>> *** BLURB HERE ***
>> Version 3 summary:
>>      RWMR (Region Weighted Mode Register) -
>>          - change the register to generic read/write from nop/write
>> 
>> Version 2 summary:
>>      (DAWR1,DAWRX1):
>>          - spec reference: 
>> https://files.openpower.foundation/s/EgCy7C43p2NSRfR
>>          - corrected commit message format
>>          - combine DAWR(0/1) handling into a single function
>>          - add DAWR1 & DAWRX1 to init_proc_POWER10() only.
>> 
>>      RWMR (Region Weighted Mode Register) -
>>          - corrected the previous definition as ITV1
>>          - spec reference:
>>              
>> https://ibm.ent.box.com/s/tmklq90ze7aj8f4n32er1mu3sy9u8k3k (Power9)
>>          - it appears that part of the previous upstream request SPRs
>>            (SPR_POWER_MMCR3, SPR_POWER_SIER2, SPR_POWER_SIER3) are
>>            already in the current master. Therefore, removed those
>>            from this request.
>> 
>> dan tan (2):
>>    ppc/pnv: Add new PowerPC Special Purpose Registers (DAWR1,DAWRX1)
>>    ppc/pnv: Add new PowerPC Special Purpose Registers (RWMR)
>> 
>>   include/hw/ppc/spapr.h   |  2 +-
>>   target/ppc/cpu.h         |  8 +++--
>>   target/ppc/helper.h      |  4 +--
>>   target/ppc/spr_common.h  |  2 ++
>>   hw/ppc/spapr_hcall.c     | 24 ++++++++------
>>   target/ppc/cpu.c         | 69 
>> ++++++++++++++++++++++++++--------------
>>   target/ppc/cpu_init.c    | 20 ++++++++++++
>>   target/ppc/excp_helper.c | 11 ++++++-
>>   target/ppc/machine.c     |  5 ++-
>>   target/ppc/misc_helper.c |  8 ++---
>>   target/ppc/translate.c   | 21 ++++++++++--
>>   11 files changed, 127 insertions(+), 47 deletions(-)
>>