Register an event notifier handler to process AP configuration
change events by queuing the event and generating a CRW to let
the guest know its AP configuration has changed
Signed-off-by: Rorie Reyes <rreyes@linux.ibm.com>
Reviewed-by: Anthony Krowiak <akrowiak@linux.ibm.com>
Tested-by: Anthony Krowiak <akrowiak@linux.ibm.com>
---
hw/vfio/ap.c | 27 +++++++++++++++++++++++++++
1 file changed, 27 insertions(+)
diff --git a/hw/vfio/ap.c b/hw/vfio/ap.c
index 30b08ad375..533cadb2dd 100644
--- a/hw/vfio/ap.c
+++ b/hw/vfio/ap.c
@@ -18,6 +18,7 @@
#include "hw/vfio/vfio-common.h"
#include "system/iommufd.h"
#include "hw/s390x/ap-device.h"
+#include "hw/s390x/css.h"
#include "qemu/error-report.h"
#include "qemu/event_notifier.h"
#include "qemu/main-loop.h"
@@ -37,6 +38,7 @@ struct VFIOAPDevice {
APDevice apdev;
VFIODevice vdev;
EventNotifier req_notifier;
+ EventNotifier cfg_notifier;
};
OBJECT_DECLARE_SIMPLE_TYPE(VFIOAPDevice, VFIO_AP_DEVICE)
@@ -70,6 +72,18 @@ static void vfio_ap_req_notifier_handler(void *opaque)
}
}
+static void vfio_ap_cfg_chg_notifier_handler(void *opaque)
+{
+ VFIOAPDevice *vapdev = opaque;
+
+ if (!event_notifier_test_and_clear(&vapdev->cfg_notifier)) {
+ warn_report("Event notifier not initialized");
+ return;
+ }
+
+ css_generate_css_crws(0);
+}
+
static bool vfio_ap_register_irq_notifier(VFIOAPDevice *vapdev,
unsigned int irq, Error **errp)
{
@@ -85,6 +99,10 @@ static bool vfio_ap_register_irq_notifier(VFIOAPDevice *vapdev,
notifier = &vapdev->req_notifier;
fd_read = vfio_ap_req_notifier_handler;
break;
+ case VFIO_AP_CFG_CHG_IRQ_INDEX:
+ notifier = &vapdev->cfg_notifier;
+ fd_read = vfio_ap_cfg_chg_notifier_handler;
+ break;
default:
error_setg(errp, "vfio: Unsupported device irq(%d)", irq);
return false;
@@ -175,6 +193,15 @@ static void vfio_ap_realize(DeviceState *dev, Error **errp)
warn_report_err(err);
}
+ if (!vfio_ap_register_irq_notifier(vapdev, VFIO_AP_CFG_CHG_IRQ_INDEX, &err))
+ {
+ /*
+ * Report this error, but do not make it a failing condition.
+ * Lack of this IRQ in the host does not prevent normal operation.
+ */
+ warn_report_err(err);
+ }
+
return;
error:
--
2.39.5 (Apple Git-154)On 1/7/25 19:43, Rorie Reyes wrote:
> Register an event notifier handler to process AP configuration
> change events by queuing the event and generating a CRW to let
> the guest know its AP configuration has changed
>
> Signed-off-by: Rorie Reyes <rreyes@linux.ibm.com>
> Reviewed-by: Anthony Krowiak <akrowiak@linux.ibm.com>
> Tested-by: Anthony Krowiak <akrowiak@linux.ibm.com>
> ---
> hw/vfio/ap.c | 27 +++++++++++++++++++++++++++
> 1 file changed, 27 insertions(+)
>
> diff --git a/hw/vfio/ap.c b/hw/vfio/ap.c
> index 30b08ad375..533cadb2dd 100644
> --- a/hw/vfio/ap.c
> +++ b/hw/vfio/ap.c
> @@ -18,6 +18,7 @@
> #include "hw/vfio/vfio-common.h"
> #include "system/iommufd.h"
> #include "hw/s390x/ap-device.h"
> +#include "hw/s390x/css.h"
> #include "qemu/error-report.h"
> #include "qemu/event_notifier.h"
> #include "qemu/main-loop.h"
> @@ -37,6 +38,7 @@ struct VFIOAPDevice {
> APDevice apdev;
> VFIODevice vdev;
> EventNotifier req_notifier;
> + EventNotifier cfg_notifier;
> };
>
> OBJECT_DECLARE_SIMPLE_TYPE(VFIOAPDevice, VFIO_AP_DEVICE)
> @@ -70,6 +72,18 @@ static void vfio_ap_req_notifier_handler(void *opaque)
> }
> }
>
> +static void vfio_ap_cfg_chg_notifier_handler(void *opaque)
> +{
> + VFIOAPDevice *vapdev = opaque;
> +
> + if (!event_notifier_test_and_clear(&vapdev->cfg_notifier)) {
> + warn_report("Event notifier not initialized");
I don't think this warning is needed. May be reverse the logic :
if (event_notifier_test_and_clear(&vapdev->cfg_notifier)) {
css_generate_css_crws(0);
}
Thanks,
C.
> + return;
> + }
> +
> + css_generate_css_crws(0);
> +}
> +
> static bool vfio_ap_register_irq_notifier(VFIOAPDevice *vapdev,
> unsigned int irq, Error **errp)
> {
> @@ -85,6 +99,10 @@ static bool vfio_ap_register_irq_notifier(VFIOAPDevice *vapdev,
> notifier = &vapdev->req_notifier;
> fd_read = vfio_ap_req_notifier_handler;
> break;
> + case VFIO_AP_CFG_CHG_IRQ_INDEX:
> + notifier = &vapdev->cfg_notifier;
> + fd_read = vfio_ap_cfg_chg_notifier_handler;
> + break;
> default:
> error_setg(errp, "vfio: Unsupported device irq(%d)", irq);
> return false;
>
> @@ -175,6 +193,15 @@ static void vfio_ap_realize(DeviceState *dev, Error **errp)
> warn_report_err(err);
> }
>
> + if (!vfio_ap_register_irq_notifier(vapdev, VFIO_AP_CFG_CHG_IRQ_INDEX, &err))
> + {
> + /*
> + * Report this error, but do not make it a failing condition.
> + * Lack of this IRQ in the host does not prevent normal operation.
> + */
> + warn_report_err(err);
> + }
> +
> return;
>
> error:
On 1/7/25 1:43 PM, Rorie Reyes wrote:
> Register an event notifier handler to process AP configuration
> change events by queuing the event and generating a CRW to let
> the guest know its AP configuration has changed
>
> Signed-off-by: Rorie Reyes <rreyes@linux.ibm.com>
> Reviewed-by: Anthony Krowiak <akrowiak@linux.ibm.com>
> Tested-by: Anthony Krowiak <akrowiak@linux.ibm.com>
> ---
> hw/vfio/ap.c | 27 +++++++++++++++++++++++++++
> 1 file changed, 27 insertions(+)
>
> diff --git a/hw/vfio/ap.c b/hw/vfio/ap.c
> index 30b08ad375..533cadb2dd 100644
> --- a/hw/vfio/ap.c
> +++ b/hw/vfio/ap.c
> @@ -18,6 +18,7 @@
> #include "hw/vfio/vfio-common.h"
> #include "system/iommufd.h"
> #include "hw/s390x/ap-device.h"
> +#include "hw/s390x/css.h"
> #include "qemu/error-report.h"
> #include "qemu/event_notifier.h"
> #include "qemu/main-loop.h"
> @@ -37,6 +38,7 @@ struct VFIOAPDevice {
> APDevice apdev;
> VFIODevice vdev;
> EventNotifier req_notifier;
> + EventNotifier cfg_notifier;
> };
>
> OBJECT_DECLARE_SIMPLE_TYPE(VFIOAPDevice, VFIO_AP_DEVICE)
> @@ -70,6 +72,18 @@ static void vfio_ap_req_notifier_handler(void *opaque)
> }
> }
>
> +static void vfio_ap_cfg_chg_notifier_handler(void *opaque)
> +{
> + VFIOAPDevice *vapdev = opaque;
> +
> + if (!event_notifier_test_and_clear(&vapdev->cfg_notifier)) {
> + warn_report("Event notifier not initialized");
> + return;
> + }
> +
> + css_generate_css_crws(0);
> +}
> +
> static bool vfio_ap_register_irq_notifier(VFIOAPDevice *vapdev,
> unsigned int irq, Error **errp)
> {
> @@ -85,6 +99,10 @@ static bool vfio_ap_register_irq_notifier(VFIOAPDevice *vapdev,
> notifier = &vapdev->req_notifier;
> fd_read = vfio_ap_req_notifier_handler;
> break;
> + case VFIO_AP_CFG_CHG_IRQ_INDEX:
> + notifier = &vapdev->cfg_notifier;
> + fd_read = vfio_ap_cfg_chg_notifier_handler;
> + break;
> default:
> error_setg(errp, "vfio: Unsupported device irq(%d)", irq);
> return false;
> @@ -175,6 +193,15 @@ static void vfio_ap_realize(DeviceState *dev, Error **errp)
> warn_report_err(err);
> }
I missed this in my previous reviews; however, this needs a function to
unregister the
VFIO_AP_CFG_CHG_IRQ_INDEX notifier.
>
> + if (!vfio_ap_register_irq_notifier(vapdev, VFIO_AP_CFG_CHG_IRQ_INDEX, &err))
> + {
> + /*
> + * Report this error, but do not make it a failing condition.
> + * Lack of this IRQ in the host does not prevent normal operation.
> + */
> + warn_report_err(err);
> + }
> +
> return;
>
> error:
On 1/7/25 19:43, Rorie Reyes wrote:
> Register an event notifier handler to process AP configuration
> change events by queuing the event and generating a CRW to let
> the guest know its AP configuration has changed
>
> Signed-off-by: Rorie Reyes <rreyes@linux.ibm.com>
> Reviewed-by: Anthony Krowiak <akrowiak@linux.ibm.com>
> Tested-by: Anthony Krowiak <akrowiak@linux.ibm.com>
I don't recall a previous version of these changes where these
trailers were added. Was this part of an internal review ?
It is best to restart the process when the patches become public.
Thanks,
C.
> ---
> hw/vfio/ap.c | 27 +++++++++++++++++++++++++++
> 1 file changed, 27 insertions(+)
>
> diff --git a/hw/vfio/ap.c b/hw/vfio/ap.c
> index 30b08ad375..533cadb2dd 100644
> --- a/hw/vfio/ap.c
> +++ b/hw/vfio/ap.c
> @@ -18,6 +18,7 @@
> #include "hw/vfio/vfio-common.h"
> #include "system/iommufd.h"
> #include "hw/s390x/ap-device.h"
> +#include "hw/s390x/css.h"
> #include "qemu/error-report.h"
> #include "qemu/event_notifier.h"
> #include "qemu/main-loop.h"
> @@ -37,6 +38,7 @@ struct VFIOAPDevice {
> APDevice apdev;
> VFIODevice vdev;
> EventNotifier req_notifier;
> + EventNotifier cfg_notifier;
> };
>
> OBJECT_DECLARE_SIMPLE_TYPE(VFIOAPDevice, VFIO_AP_DEVICE)
> @@ -70,6 +72,18 @@ static void vfio_ap_req_notifier_handler(void *opaque)
> }
> }
>
> +static void vfio_ap_cfg_chg_notifier_handler(void *opaque)
> +{
> + VFIOAPDevice *vapdev = opaque;
> +
> + if (!event_notifier_test_and_clear(&vapdev->cfg_notifier)) {
> + warn_report("Event notifier not initialized");
> + return;
> + }
> +
> + css_generate_css_crws(0);
> +}
> +
> static bool vfio_ap_register_irq_notifier(VFIOAPDevice *vapdev,
> unsigned int irq, Error **errp)
> {
> @@ -85,6 +99,10 @@ static bool vfio_ap_register_irq_notifier(VFIOAPDevice *vapdev,
> notifier = &vapdev->req_notifier;
> fd_read = vfio_ap_req_notifier_handler;
> break;
> + case VFIO_AP_CFG_CHG_IRQ_INDEX:
> + notifier = &vapdev->cfg_notifier;
> + fd_read = vfio_ap_cfg_chg_notifier_handler;
> + break;
> default:
> error_setg(errp, "vfio: Unsupported device irq(%d)", irq);
> return false;
> @@ -175,6 +193,15 @@ static void vfio_ap_realize(DeviceState *dev, Error **errp)
> warn_report_err(err);
> }
>
> + if (!vfio_ap_register_irq_notifier(vapdev, VFIO_AP_CFG_CHG_IRQ_INDEX, &err))
> + {
> + /*
> + * Report this error, but do not make it a failing condition.
> + * Lack of this IRQ in the host does not prevent normal operation.
> + */
> + warn_report_err(err);
> + }
> +
> return;
>
> error:
On 1/8/25 2:34 AM, Cédric Le Goater wrote: > On 1/7/25 19:43, Rorie Reyes wrote: >> Register an event notifier handler to process AP configuration >> change events by queuing the event and generating a CRW to let >> the guest know its AP configuration has changed >> >> Signed-off-by: Rorie Reyes <rreyes@linux.ibm.com> >> Reviewed-by: Anthony Krowiak <akrowiak@linux.ibm.com> >> Tested-by: Anthony Krowiak <akrowiak@linux.ibm.com> > > I don't recall a previous version of these changes where these > trailers were added. Was this part of an internal review ? > It is best to restart the process when the patches become public. > > Thanks, > > C. Hey Cédric, Yes these patches went through an internal review and Anthony Krowiak is the primary maintainer for VFIO-AP. This is my first upstream review so apologize for the confusion. Thanks, Rorie
© 2016 - 2026 Red Hat, Inc.