[v2] tcg: Merge *_i32 and *_i64 opcodes

[PATCH v2 25/81] tcg: Validate op supported in opcode_args_ct

Posted by Richard Henderson 2 months, 4 weeks ago

We should have checked that the op is supported before
emitting it.  The backend cannot be expected to have a
constraint set for unsupported ops.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 tcg/tcg.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tcg/tcg.c b/tcg/tcg.c
index f72a8e5a47..80744b86bb 100644
--- a/tcg/tcg.c
+++ b/tcg/tcg.c
@@ -3367,6 +3367,10 @@ static const TCGArgConstraint *opcode_args_ct(const TCGOp *op)
     const TCGOpDef *def = &tcg_op_defs[op->opc];
     TCGConstraintSetIndex con_set;
 
+#ifdef CONFIG_DEBUG_TCG
+    assert(tcg_op_supported(op->opc, TCGOP_TYPE(op), TCGOP_FLAGS(op)));
+#endif
+
     if (def->nb_iargs + def->nb_oargs == 0) {
         return NULL;
     }
-- 
2.43.0

Re: [PATCH v2 25/81] tcg: Validate op supported in opcode_args_ct

Posted by Philippe Mathieu-Daudé 2 months, 3 weeks ago

On 7/1/25 09:00, Richard Henderson wrote:
> We should have checked that the op is supported before
> emitting it.  The backend cannot be expected to have a
> constraint set for unsupported ops.
> 
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>   tcg/tcg.c | 4 ++++
>   1 file changed, 4 insertions(+)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>