[v2] tap: Use g_spawn_sync() and g_spawn_check_wait_status()

[PATCH v2 1/2] glib-compat: Define g_spawn_check_wait_status()

Posted by Akihiko Odaki 3 months ago

g_spawn_check_exit_status() is renamed to g_spawn_check_wait_status()
in 2.70.

Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
---
 include/glib-compat.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/include/glib-compat.h b/include/glib-compat.h
index 86be439ba0ef..0bddb327bd5d 100644
--- a/include/glib-compat.h
+++ b/include/glib-compat.h
@@ -68,6 +68,8 @@
  * without generating warnings.
  */
 
+#define g_spawn_check_wait_status g_spawn_check_exit_status
+
 /*
  * g_memdup2_qemu:
  * @mem: (nullable): the memory to copy.

-- 
2.47.1

Re: [PATCH v2 1/2] glib-compat: Define g_spawn_check_wait_status()

Posted by Daniel P. Berrangé 3 months ago

On Sat, Jan 04, 2025 at 05:04:07PM +0900, Akihiko Odaki wrote:
> g_spawn_check_exit_status() is renamed to g_spawn_check_wait_status()
> in 2.70.
> 
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> ---
>  include/glib-compat.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/include/glib-compat.h b/include/glib-compat.h
> index 86be439ba0ef..0bddb327bd5d 100644
> --- a/include/glib-compat.h
> +++ b/include/glib-compat.h
> @@ -68,6 +68,8 @@
>   * without generating warnings.
>   */
>  
> +#define g_spawn_check_wait_status g_spawn_check_exit_status

This needs to be conditionalized on !GLIB_CHECK_VERSION(2, 70, 0)


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

[PATCH v2 1/2] glib-compat: Define g_spawn_check_wait_status()
[PATCH v2 2/2] tap: Use g_spawn_sync() and g_spawn_check_wait_status()