1. Patchew
  2. QEMU
  3. View series

[PATCH v2] Add a b4 configuration file

Jiaxun Yang posted 1 patch 3 months ago 
.b4-config | 14 ++++++++++++++
1 file changed, 14 insertions(+)
[PATCH v2] Add a b4 configuration file
Posted by Jiaxun Yang 3 months ago 
b4 [1] is a convenient tool to manage patch series with mailing list
working flow.

Add a project default config file to match QEMU's mailing list conventions
as well as adopting differences on scripting.

Examples of b4:

```
$ b4 prep --check
Checking patches using:
  scripts/checkpatch.pl -q --terse --no-summary --mailback -

---
Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
---
Changes in v2:
- Add lore masks (philmd) from:
  https://lore.kernel.org/qemu-devel/20241224135054.10243-1-philmd@linaro.org/
- Link to v1: https://lore.kernel.org/r/20241222-b4-config-v1-1-b3667beb30a4@flygoat.com
---
● cc5a4c890fed: Add a b4 configuration file
  ● checkpatch.pl: 27: WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
---
Success: 0, Warning: 1, Error: 0
```

```
$ b4 prep -c
Will collect To: addresses using echo
Will collect Cc: addresses using get_maintainer.pl
Collecting To/Cc addresses
    + To: qemu-devel@nongnu.org
---
You can trim/expand this list with: b4 prep --edit-cover
Invoking git-filter-repo to update the cover letter.
New history written in 0.02 seconds...
Completely finished after 0.06 seconds
```

[1]: https://b4.docs.kernel.org/

Co-developed-by: Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
---
 .b4-config | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/.b4-config b/.b4-config
new file mode 100644
index 0000000000000000000000000000000000000000..4b9b2fe290f92f784cd3229616e2cbf0e8550e02
--- /dev/null
+++ b/.b4-config
@@ -0,0 +1,14 @@
+#
+# Common b4 settings that can be used to send patches to QEMU upstream.
+# https://b4.docs.kernel.org/
+#
+
+[b4]
+    send-series-to = qemu-devel@nongnu.org
+    send-auto-to-cmd = echo
+    send-auto-cc-cmd = scripts/get_maintainer.pl --noroles --norolestats --nogit --nogit-fallback
+    am-perpatch-check-cmd = scripts/checkpatch.pl -q --terse --no-summary --mailback -
+    prep-perpatch-check-cmd = scripts/checkpatch.pl -q --terse --no-summary --mailback -
+    searchmask = https://lore.kernel.org/qemu-devel/?x=m&t=1&q=%s
+    linkmask = https://lore.kernel.org/qemu-devel/%s
+    linktrailermask = Message-ID: <%s>

---
base-commit: 65cb7129f4160c7e07a0da107f888ec73ae96776
change-id: 20241222-b4-config-e469b075802c

Best regards,
-- 
Jiaxun Yang <jiaxun.yang@flygoat.com>
Re: [PATCH v2] Add a b4 configuration file
Posted by Cédric Le Goater 2 months, 2 weeks ago 
On 1/2/25 23:53, Jiaxun Yang wrote:
> b4 [1] is a convenient tool to manage patch series with mailing list
> working flow.
> 
> Add a project default config file to match QEMU's mailing list conventions
> as well as adopting differences on scripting.
> 
> Examples of b4:
> 
> ```
> $ b4 prep --check
> Checking patches using:
>    scripts/checkpatch.pl -q --terse --no-summary --mailback -
> 
> ---
> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
> ---
> Changes in v2:
> - Add lore masks (philmd) from:
>    https://lore.kernel.org/qemu-devel/20241224135054.10243-1-philmd@linaro.org/
> - Link to v1: https://lore.kernel.org/r/20241222-b4-config-v1-1-b3667beb30a4@flygoat.com
> ---
> ● cc5a4c890fed: Add a b4 configuration file
>    ● checkpatch.pl: 27: WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
> ---
> Success: 0, Warning: 1, Error: 0
> ```
> 
> ```
> $ b4 prep -c
> Will collect To: addresses using echo
> Will collect Cc: addresses using get_maintainer.pl
> Collecting To/Cc addresses
>      + To: qemu-devel@nongnu.org
> ---
> You can trim/expand this list with: b4 prep --edit-cover
> Invoking git-filter-repo to update the cover letter.
> New history written in 0.02 seconds...
> Completely finished after 0.06 seconds
> ```
> 
> [1]: https://b4.docs.kernel.org/
> 
> Co-developed-by: Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
> ---
>   .b4-config | 14 ++++++++++++++
>   1 file changed, 14 insertions(+)
> 
> diff --git a/.b4-config b/.b4-config
> new file mode 100644
> index 0000000000000000000000000000000000000000..4b9b2fe290f92f784cd3229616e2cbf0e8550e02
> --- /dev/null
> +++ b/.b4-config
> @@ -0,0 +1,14 @@
> +#
> +# Common b4 settings that can be used to send patches to QEMU upstream.
> +# https://b4.docs.kernel.org/
> +#
> +
> +[b4]
> +    send-series-to = qemu-devel@nongnu.org
> +    send-auto-to-cmd = echo
> +    send-auto-cc-cmd = scripts/get_maintainer.pl --noroles --norolestats --nogit --nogit-fallback
> +    am-perpatch-check-cmd = scripts/checkpatch.pl -q --terse --no-summary --mailback -
> +    prep-perpatch-check-cmd = scripts/checkpatch.pl -q --terse --no-summary --mailback -
> +    searchmask = https://lore.kernel.org/qemu-devel/?x=m&t=1&q=%s
> +    linkmask = https://lore.kernel.org/qemu-devel/%s
> +    linktrailermask = Message-ID: <%s>

Why is this changing the link trailer ?

I think the default format :

   Link: https://lore.kernel.org/qemu-devel/<msgid>

is more convenient. people have a direct URL to click on.

Thanks,

C.



> 
> ---
> base-commit: 65cb7129f4160c7e07a0da107f888ec73ae96776
> change-id: 20241222-b4-config-e469b075802c
> 
> Best regards,
Re: [PATCH v2] Add a b4 configuration file
Posted by Philippe Mathieu-Daudé 2 months, 3 weeks ago 
On 2/1/25 23:53, Jiaxun Yang wrote:
> b4 [1] is a convenient tool to manage patch series with mailing list
> working flow.
> 
> Add a project default config file to match QEMU's mailing list conventions
> as well as adopting differences on scripting.
> 
> Examples of b4:
> 
> ```
> $ b4 prep --check
> Checking patches using:
>    scripts/checkpatch.pl -q --terse --no-summary --mailback -
> 
> ---
> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
> ---
> Changes in v2:
> - Add lore masks (philmd) from:
>    https://lore.kernel.org/qemu-devel/20241224135054.10243-1-philmd@linaro.org/
> - Link to v1: https://lore.kernel.org/r/20241222-b4-config-v1-1-b3667beb30a4@flygoat.com
> ---
> ● cc5a4c890fed: Add a b4 configuration file
>    ● checkpatch.pl: 27: WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
> ---
> Success: 0, Warning: 1, Error: 0
> ```
> 
> ```
> $ b4 prep -c
> Will collect To: addresses using echo
> Will collect Cc: addresses using get_maintainer.pl
> Collecting To/Cc addresses
>      + To: qemu-devel@nongnu.org
> ---
> You can trim/expand this list with: b4 prep --edit-cover
> Invoking git-filter-repo to update the cover letter.
> New history written in 0.02 seconds...
> Completely finished after 0.06 seconds
> ```
> 
> [1]: https://b4.docs.kernel.org/
> 
> Co-developed-by: Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
> ---
>   .b4-config | 14 ++++++++++++++
>   1 file changed, 14 insertions(+)

Squashing in order to avoid checkpatch.pl error:

-- >8 --
diff --git a/MAINTAINERS b/MAINTAINERS
index ec898a3cbc6..0c71eb3f925 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -4310,3 +4310,9 @@ Machine development tool
  M: Maksim Davydov <davydov-max@yandex-team.ru>
  S: Supported
  F: scripts/compare-machine-types.py
+
+b4 tool configuration
+M: Jiaxun Yang <jiaxun.yang@flygoat.com>
+M: Philippe Mathieu-Daudé <philmd@linaro.org>
+S: Odd Fixes
+F: .b4-config
---

and queued, thanks!
Re: [PATCH v2] Add a b4 configuration file
Posted by Markus Armbruster 2 months, 3 weeks ago 
Philippe Mathieu-Daudé <philmd@linaro.org> writes:

> On 2/1/25 23:53, Jiaxun Yang wrote:
>> b4 [1] is a convenient tool to manage patch series with mailing list
>> working flow.
>> Add a project default config file to match QEMU's mailing list conventions
>> as well as adopting differences on scripting.
>> Examples of b4:
>> ```
>> $ b4 prep --check
>> Checking patches using:
>>    scripts/checkpatch.pl -q --terse --no-summary --mailback -
>> ---
>> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
>> ---
>> Changes in v2:
>> - Add lore masks (philmd) from:
>>    https://lore.kernel.org/qemu-devel/20241224135054.10243-1-philmd@linaro.org/
>> - Link to v1: https://lore.kernel.org/r/20241222-b4-config-v1-1-b3667beb30a4@flygoat.com
>> ---
>> ● cc5a4c890fed: Add a b4 configuration file
>>    ● checkpatch.pl: 27: WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
>> ---
>> Success: 0, Warning: 1, Error: 0
>> ```
>> ```
>> $ b4 prep -c
>> Will collect To: addresses using echo
>> Will collect Cc: addresses using get_maintainer.pl
>> Collecting To/Cc addresses
>>      + To: qemu-devel@nongnu.org
>> ---
>> You can trim/expand this list with: b4 prep --edit-cover
>> Invoking git-filter-repo to update the cover letter.
>> New history written in 0.02 seconds...
>> Completely finished after 0.06 seconds
>> ```
>> [1]: https://b4.docs.kernel.org/
>> Co-developed-by: Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
>> ---
>>   .b4-config | 14 ++++++++++++++
>>   1 file changed, 14 insertions(+)
>
> Squashing in order to avoid checkpatch.pl error:
>
> -- >8 --
> diff --git a/MAINTAINERS b/MAINTAINERS
> index ec898a3cbc6..0c71eb3f925 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -4310,3 +4310,9 @@ Machine development tool
>  M: Maksim Davydov <davydov-max@yandex-team.ru>
>  S: Supported
>  F: scripts/compare-machine-types.py
> +
> +b4 tool configuration

Start the title with a capital letter, please.

> +M: Jiaxun Yang <jiaxun.yang@flygoat.com>
> +M: Philippe Mathieu-Daudé <philmd@linaro.org>
> +S: Odd Fixes
> +F: .b4-config

The scope of this entry is less than clear.  What kind of tools?

It's not our own tooling (scripts/...).  Perhaps it's tools used by
enough developers to warrant committing common configuration to Git.  We
have such configuration files already, not covered by MAINTAINERS, e.g.:

    .dir-locals.el
    .editorconfig
    .exrc
    .gdbinit
    .gitpublish
    .pylintrc

The path of least resistance is to add .b4-config the same way.

If we decide we want a new entry in MAINTAINERS, its scope should be
reasonably clear, and we should add existing files, if any, to it.

> ---
>
> and queued, thanks!
Re: [PATCH v2] Add a b4 configuration file
Posted by Philippe Mathieu-Daudé 2 months, 3 weeks ago 
On 13/1/25 07:53, Markus Armbruster wrote:
> Philippe Mathieu-Daudé <philmd@linaro.org> writes:
> 
>> On 2/1/25 23:53, Jiaxun Yang wrote:
>>> b4 [1] is a convenient tool to manage patch series with mailing list
>>> working flow.
>>> Add a project default config file to match QEMU's mailing list conventions
>>> as well as adopting differences on scripting.
>>> Examples of b4:
>>> ```
>>> $ b4 prep --check
>>> Checking patches using:
>>>     scripts/checkpatch.pl -q --terse --no-summary --mailback -
>>> ---
>>> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
>>> ---
>>> Changes in v2:
>>> - Add lore masks (philmd) from:
>>>     https://lore.kernel.org/qemu-devel/20241224135054.10243-1-philmd@linaro.org/
>>> - Link to v1: https://lore.kernel.org/r/20241222-b4-config-v1-1-b3667beb30a4@flygoat.com
>>> ---
>>> ● cc5a4c890fed: Add a b4 configuration file
>>>     ● checkpatch.pl: 27: WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
>>> ---
>>> Success: 0, Warning: 1, Error: 0
>>> ```
>>> ```
>>> $ b4 prep -c
>>> Will collect To: addresses using echo
>>> Will collect Cc: addresses using get_maintainer.pl
>>> Collecting To/Cc addresses
>>>       + To: qemu-devel@nongnu.org
>>> ---
>>> You can trim/expand this list with: b4 prep --edit-cover
>>> Invoking git-filter-repo to update the cover letter.
>>> New history written in 0.02 seconds...
>>> Completely finished after 0.06 seconds
>>> ```
>>> [1]: https://b4.docs.kernel.org/
>>> Co-developed-by: Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>>> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
>>> ---
>>>    .b4-config | 14 ++++++++++++++
>>>    1 file changed, 14 insertions(+)
>>
>> Squashing in order to avoid checkpatch.pl error:
>>
>> -- >8 --
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index ec898a3cbc6..0c71eb3f925 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -4310,3 +4310,9 @@ Machine development tool
>>   M: Maksim Davydov <davydov-max@yandex-team.ru>
>>   S: Supported
>>   F: scripts/compare-machine-types.py
>> +
>> +b4 tool configuration
> 
> Start the title with a capital letter, please.
> 
>> +M: Jiaxun Yang <jiaxun.yang@flygoat.com>
>> +M: Philippe Mathieu-Daudé <philmd@linaro.org>
>> +S: Odd Fixes
>> +F: .b4-config
> 
> The scope of this entry is less than clear.  What kind of tools?
> 
> It's not our own tooling (scripts/...).  Perhaps it's tools used by
> enough developers to warrant committing common configuration to Git.  We
> have such configuration files already, not covered by MAINTAINERS, e.g.:
> 
>      .dir-locals.el
>      .editorconfig
>      .exrc
>      .gdbinit
>      .gitpublish
>      .pylintrc
> 
> The path of least resistance is to add .b4-config the same way.
> 
> If we decide we want a new entry in MAINTAINERS, its scope should be
> reasonably clear, and we should add existing files, if any, to it.

OK, then I'll just ignore ./checkpatch.pl warning for this patch.

Thanks,

Phil.

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.