cpus: Avoid re-initializing fields cleared in cpu_common_reset_hold()

[PATCH 0/3] cpus: Avoid re-initializing fields cleared in cpu_common_reset_hold()

Philippe Mathieu-Daudé posted 3 patches 1 year, 1 month ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20241230153929.87137-1-philmd@linaro.org

Maintainers: Eduardo Habkost <eduardo@habkost.net>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Yanan Wang <wangyanan55@huawei.com>, Zhao Liu <zhao1.liu@intel.com>, Bernhard Beschow <shentey@gmail.com>, Peter Maydell <peter.maydell@linaro.org>, Richard Henderson <richard.henderson@linaro.org>, Helge Deller <deller@gmx.de>, Song Gao <gaosong@loongson.cn>, Stafford Horne <shorne@gmail.com>

hw/core/cpu-common.c      | 1 -
hw/misc/mips_cpc.c        | 1 -
hw/ppc/e500.c             | 1 -
target/arm/arm-powerctl.c | 2 --
target/hppa/cpu.c         | 2 --
target/loongarch/cpu.c    | 1 -
target/openrisc/cpu.c     | 1 -
7 files changed, 9 deletions(-)

Expand all Fold all

[PATCH 0/3] cpus: Avoid re-initializing fields cleared in cpu_common_reset_hold()

Posted by Philippe Mathieu-Daudé 1 year, 1 month ago

Having this call tree:

  cpu_reset()
  -> device_cold_reset()
     -> DeviceClass::reset()
        -> target_cpu_reset()
           -> ResettablePhases::hold()
              -> CPUClass::phases::hold()
                 -> cpu_common_reset_hold()

If we call cpu_reset(), common fields will be reset in
cpu_common_reset_hold(), we don't need to manually do it.

Remove the pointless re-assignments on CPUState.

Based-on: <20241230152519.86291-1-philmd@linaro.org>

Philippe Mathieu-Daudé (3):
  accel/tcg: Remove pointless initialization of cflags_next_tb
  target/cpus: Remove pointless re-assignment of
    CPUState::exception_index
  target/cpus: Remove pointless re-assignment of CPUState::halted

 hw/core/cpu-common.c      | 1 -
 hw/misc/mips_cpc.c        | 1 -
 hw/ppc/e500.c             | 1 -
 target/arm/arm-powerctl.c | 2 --
 target/hppa/cpu.c         | 2 --
 target/loongarch/cpu.c    | 1 -
 target/openrisc/cpu.c     | 1 -
 7 files changed, 9 deletions(-)

-- 
2.47.1

Re: [PATCH 0/3] cpus: Avoid re-initializing fields cleared in cpu_common_reset_hold()

Posted by Philippe Mathieu-Daudé 1 year, 1 month ago

On 30/12/24 16:39, Philippe Mathieu-Daudé wrote:
> Having this call tree:
> 
>    cpu_reset()
>    -> device_cold_reset()
>       -> DeviceClass::reset()
>          -> target_cpu_reset()
>             -> ResettablePhases::hold()
>                -> CPUClass::phases::hold()
>                   -> cpu_common_reset_hold()
> 
> If we call cpu_reset(), common fields will be reset in
> cpu_common_reset_hold(), we don't need to manually do it.
> 
> Remove the pointless re-assignments on CPUState.
Ping for patches 2 & 3?