From: ghy <2247883756@qq.com>
Refer to the link below for a description of the vldi instructions:
https://jia.je/unofficial-loongarch-intrinsics-guide/lsx/misc/#synopsis_88
Fixed errors in vldi instruction implementation.
Signed-off-by: Guo Hongyu <guohongyu24@mails.ucas.ac.cn>
Tested-by: Xianglai Li <lixianglai@loongson.cn>
Signed-off-by: Xianglai Li <lixianglai@loongson.cn>
Reviewed-by: Bibo Mao <maobibo@loongson.cn>
Signed-off-by: Bibo Mao <maobibo@loongson.cn>
---
target/loongarch/tcg/insn_trans/trans_vec.c.inc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/loongarch/tcg/insn_trans/trans_vec.c.inc b/target/loongarch/tcg/insn_trans/trans_vec.c.inc
index 92b1d22e28..d317dfcc1c 100644
--- a/target/loongarch/tcg/insn_trans/trans_vec.c.inc
+++ b/target/loongarch/tcg/insn_trans/trans_vec.c.inc
@@ -3480,7 +3480,7 @@ static uint64_t vldi_get_value(DisasContext *ctx, uint32_t imm)
break;
case 1:
/* data: {2{16'0, imm[7:0], 8'0}} */
- data = (t << 24) | (t << 8);
+ data = (t << 40) | (t << 8);
break;
case 2:
/* data: {2{8'0, imm[7:0], 16'0}} */
--
2.43.5Hi Bibo, On 25/12/24 03:40, Bibo Mao wrote: > From: ghy <2247883756@qq.com> Is this authorship correct? Should it be: From: Guo Hongyu <guohongyu24@mails.ucas.ac.cn> > > Refer to the link below for a description of the vldi instructions: > https://jia.je/unofficial-loongarch-intrinsics-guide/lsx/misc/#synopsis_88 > Fixed errors in vldi instruction implementation. > > Signed-off-by: Guo Hongyu <guohongyu24@mails.ucas.ac.cn> to match the S-o-b? > Tested-by: Xianglai Li <lixianglai@loongson.cn> > Signed-off-by: Xianglai Li <lixianglai@loongson.cn> > Reviewed-by: Bibo Mao <maobibo@loongson.cn> > Signed-off-by: Bibo Mao <maobibo@loongson.cn> > --- > target/loongarch/tcg/insn_trans/trans_vec.c.inc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
On 2024/12/25 下午7:32, Philippe Mathieu-Daudé wrote: > Hi Bibo, > > On 25/12/24 03:40, Bibo Mao wrote: >> From: ghy <2247883756@qq.com> > > Is this authorship correct? Should it be: > From: Guo Hongyu <guohongyu24@mails.ucas.ac.cn> yes, this is better. > >> >> Refer to the link below for a description of the vldi instructions: >> https://jia.je/unofficial-loongarch-intrinsics-guide/lsx/misc/#synopsis_88 >> >> Fixed errors in vldi instruction implementation. >> >> Signed-off-by: Guo Hongyu <guohongyu24@mails.ucas.ac.cn> > > to match the S-o-b? Guo Hongyu submits the first version with attachment, xianglai tests it and submit again with plain text. I added them both with S-o-b -:) What to do in this condition? Regards Bibo Mao > >> Tested-by: Xianglai Li <lixianglai@loongson.cn> >> Signed-off-by: Xianglai Li <lixianglai@loongson.cn> >> Reviewed-by: Bibo Mao <maobibo@loongson.cn> >> Signed-off-by: Bibo Mao <maobibo@loongson.cn> >> --- >> target/loongarch/tcg/insn_trans/trans_vec.c.inc | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >
On 26/12/24 05:22, bibo mao wrote: > > > On 2024/12/25 下午7:32, Philippe Mathieu-Daudé wrote: >> Hi Bibo, >> >> On 25/12/24 03:40, Bibo Mao wrote: >>> From: ghy <2247883756@qq.com> >> >> Is this authorship correct? Should it be: >> From: Guo Hongyu <guohongyu24@mails.ucas.ac.cn> > yes, this is better. >> >>> >>> Refer to the link below for a description of the vldi instructions: >>> https://jia.je/unofficial-loongarch-intrinsics-guide/lsx/misc/ >>> #synopsis_88 >>> Fixed errors in vldi instruction implementation. >>> >>> Signed-off-by: Guo Hongyu <guohongyu24@mails.ucas.ac.cn> >> >> to match the S-o-b? > Guo Hongyu submits the first version with attachment, xianglai tests it > and submit again with plain text. I added them both with S-o-b -:) > > What to do in this condition? IIUC the technical issue, you can fix the authorship using: git commit --amend --author='Guo Hongyu <guohongyu24@mails.ucas.ac.cn>' > > Regards > Bibo Mao >> >>> Tested-by: Xianglai Li <lixianglai@loongson.cn> >>> Signed-off-by: Xianglai Li <lixianglai@loongson.cn> >>> Reviewed-by: Bibo Mao <maobibo@loongson.cn> >>> Signed-off-by: Bibo Mao <maobibo@loongson.cn> >>> --- >>> target/loongarch/tcg/insn_trans/trans_vec.c.inc | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >> >
On 2024/12/27 上午1:38, Philippe Mathieu-Daudé wrote: > On 26/12/24 05:22, bibo mao wrote: >> >> >> On 2024/12/25 下午7:32, Philippe Mathieu-Daudé wrote: >>> Hi Bibo, >>> >>> On 25/12/24 03:40, Bibo Mao wrote: >>>> From: ghy <2247883756@qq.com> >>> >>> Is this authorship correct? Should it be: >>> From: Guo Hongyu <guohongyu24@mails.ucas.ac.cn> >> yes, this is better. >>> >>>> >>>> Refer to the link below for a description of the vldi instructions: >>>> https://jia.je/unofficial-loongarch-intrinsics-guide/lsx/misc/ >>>> #synopsis_88 >>>> Fixed errors in vldi instruction implementation. >>>> >>>> Signed-off-by: Guo Hongyu <guohongyu24@mails.ucas.ac.cn> >>> >>> to match the S-o-b? >> Guo Hongyu submits the first version with attachment, xianglai tests >> it and submit again with plain text. I added them both with S-o-b -:) >> >> What to do in this condition? > > IIUC the technical issue, you can fix the authorship using: > > git commit --amend --author='Guo Hongyu <guohongyu24@mails.ucas.ac.cn>' oh, I see now. Mail author should be consistent with SOB. I had thought there could not be multiple SOBs :) Thanks for pointing it out. Regards Bibo Mao > >> >> Regards >> Bibo Mao >>> >>>> Tested-by: Xianglai Li <lixianglai@loongson.cn> >>>> Signed-off-by: Xianglai Li <lixianglai@loongson.cn> >>>> Reviewed-by: Bibo Mao <maobibo@loongson.cn> >>>> Signed-off-by: Bibo Mao <maobibo@loongson.cn> >>>> --- >>>> target/loongarch/tcg/insn_trans/trans_vec.c.inc | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >> >
© 2016 - 2025 Red Hat, Inc.