Refector EFI style booting data structure generation to
support 32bit EFI variant on LoongArch32 CPU.
All data structs are filled with padding members if necessary
and marked as QEMU_PACKED to avoid host ABI alignment impact.
Host endian is being cared as well.
It also fixed various problems in old implementation such
as null pointer on empty string, memory desc map_size not set,
incorrect memory map definition and so on.
Reviewed-by: Song Gao <gaosong@loongson.cn>
Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
---
hw/loongarch/boot.c | 220 ++++++++++++++++++++++++++++++--------------
include/hw/loongarch/boot.h | 106 +++++++++++++++++----
2 files changed, 238 insertions(+), 88 deletions(-)
diff --git a/hw/loongarch/boot.c b/hw/loongarch/boot.c
index f258eefe9ac6566b4e043347773a6c240afead07..477c40ccb49d45d4d5026d37db0e79f5f2d89d8e 100644
--- a/hw/loongarch/boot.c
+++ b/hw/loongarch/boot.c
@@ -5,6 +5,7 @@
* Copyright (c) 2023 Loongson Technology Corporation Limited
*/
+#include <zlib.h>
#include "qemu/osdep.h"
#include "qemu/units.h"
#include "target/loongarch/cpu.h"
@@ -74,88 +75,165 @@ static inline void *guidcpy(void *dst, const void *src)
return memcpy(dst, src, sizeof(efi_guid_t));
}
-static void init_efi_boot_memmap(struct efi_system_table *systab,
- void *p, void *start)
+static void efi_hdr_crc32(efi_table_hdr_t *hdr)
{
- unsigned i;
- struct efi_boot_memmap *boot_memmap = p;
- efi_guid_t tbl_guid = LINUX_EFI_BOOT_MEMMAP_GUID;
+ uint32_t val;
- /* efi_configuration_table 1 */
- guidcpy(&systab->tables[0].guid, &tbl_guid);
- systab->tables[0].table = (struct efi_configuration_table *)(p - start);
- systab->nr_tables = 1;
-
- boot_memmap->desc_size = sizeof(efi_memory_desc_t);
- boot_memmap->desc_ver = 1;
- boot_memmap->map_size = 0;
-
- efi_memory_desc_t *map = p + sizeof(struct efi_boot_memmap);
- for (i = 0; i < memmap_entries; i++) {
- map = (void *)boot_memmap + sizeof(*map);
- map[i].type = memmap_table[i].type;
- map[i].phys_addr = ROUND_UP(memmap_table[i].address, 64 * KiB);
- map[i].num_pages = ROUND_DOWN(memmap_table[i].address +
- memmap_table[i].length - map[i].phys_addr, 64 * KiB);
- p += sizeof(efi_memory_desc_t);
- }
+ hdr->crc32 = 0;
+ val = crc32(0, (const unsigned char *)hdr, hdr->headersize);
+ hdr->crc32 = cpu_to_le32(val);
}
-static void init_efi_initrd_table(struct efi_system_table *systab,
- void *p, void *start)
+static void init_efi_vendor_string(void **p)
{
- efi_guid_t tbl_guid = LINUX_EFI_INITRD_MEDIA_GUID;
- struct efi_initrd *initrd_table = p;
+ uint16_t *vendor_str = *p;
- /* efi_configuration_table 2 */
- guidcpy(&systab->tables[1].guid, &tbl_guid);
- systab->tables[1].table = (struct efi_configuration_table *)(p - start);
- systab->nr_tables = 2;
+ /* QEMU in UTF16-LE */
+ stw_le_p(vendor_str++, 0x0051); /* Q */
+ stw_le_p(vendor_str++, 0x0045); /* E */
+ stw_le_p(vendor_str++, 0x004D); /* M */
+ stw_le_p(vendor_str++, 0x0055); /* U */
+ stw_le_p(vendor_str++, 0x0000); /* \0 */
- initrd_table->base = initrd_offset;
- initrd_table->size = initrd_size;
+ *p = vendor_str;
+ *p = QEMU_ALIGN_PTR_UP(*p, sizeof(target_long));
}
-static void init_efi_fdt_table(struct efi_system_table *systab)
+static void memmap_write_descs(efi_memory_desc_t *map)
{
- efi_guid_t tbl_guid = DEVICE_TREE_GUID;
-
- /* efi_configuration_table 3 */
- guidcpy(&systab->tables[2].guid, &tbl_guid);
- systab->tables[2].table = (void *)FDT_BASE;
- systab->nr_tables = 3;
-}
-
-static void init_systab(struct loongarch_boot_info *info, void *p, void *start)
-{
- void *bp_tables_start;
- struct efi_system_table *systab = p;
+ int i;
- info->a2 = p - start;
+ for (i = 0; i < memmap_entries; i++) {
+ uint32_t efi_type;
+ hwaddr start = memmap_table[i].address;
+ hwaddr end = memmap_table[i].address + memmap_table[i].length;
+
+ switch (memmap_table[i].type) {
+ case MEMMAP_TYPE_MEMORY:
+ efi_type = EFI_CONVENTIONAL_MEMORY;
+ break;
+ case MEMMAP_TYPE_RESERVED:
+ efi_type = EFI_RESERVED_TYPE;
+ break;
+ case MEMMAP_TYPE_ACPI:
+ efi_type = EFI_ACPI_RECLAIM_MEMORY;
+ break;
+ case MEMMAP_TYPE_NVS:
+ efi_type = EFI_ACPI_MEMORY_NVS;
+ break;
+ default:
+ efi_type = EFI_RESERVED_TYPE;
+ break;
+ }
- systab->hdr.signature = EFI_SYSTEM_TABLE_SIGNATURE;
- systab->hdr.revision = EFI_SPECIFICATION_VERSION;
- systab->hdr.revision = sizeof(struct efi_system_table),
- systab->fw_revision = FW_VERSION << 16 | FW_PATCHLEVEL << 8;
- systab->runtime = 0;
- systab->boottime = 0;
- systab->nr_tables = 0;
+ if (memmap_table[i].reserved) {
+ start = QEMU_ALIGN_DOWN(start, EFI_PAGE_SIZE);
+ end = QEMU_ALIGN_UP(end, EFI_PAGE_SIZE);
+ } else {
+ start = QEMU_ALIGN_UP(start, EFI_PAGE_SIZE);
+ end = QEMU_ALIGN_DOWN(end, EFI_PAGE_SIZE);
+ }
- p += ROUND_UP(sizeof(struct efi_system_table), 64 * KiB);
+ map[i].type = cpu_to_le32(efi_type);
+ map[i].phys_addr = cpu_to_le64(start);
+ map[i].virt_addr = cpu_to_le64(start);
+ map[i].num_pages = cpu_to_le64((end - start) >> EFI_PAGE_SHIFT);
+ }
+}
- systab->tables = p;
- bp_tables_start = p;
+#define EFI_BOOT_MEMMAP_TABLE_GEN(type) \
+static void init_efi_boot_memmap_##type(void *guidp, void **p) \
+{ \
+ struct efi_boot_memmap_##type *boot_memmap = *p; \
+ efi_guid_t tbl_guid = LINUX_EFI_BOOT_MEMMAP_GUID; \
+ \
+ /* efi_configuration_table 1 */ \
+ guidcpy(guidp, &tbl_guid); \
+ \
+ boot_memmap->desc_size = cpu_to_le##type(sizeof(efi_memory_desc_t)); \
+ boot_memmap->desc_ver = cpu_to_le32(1); \
+ boot_memmap->map_size = cpu_to_le##type(boot_memmap->desc_size * \
+ memmap_entries); \
+ memmap_write_descs(boot_memmap->map); \
+ *p += sizeof(struct efi_boot_memmap_##type); \
+}
- init_efi_boot_memmap(systab, p, start);
- p += ROUND_UP(sizeof(struct efi_boot_memmap) +
- sizeof(efi_memory_desc_t) * memmap_entries, 64 * KiB);
- init_efi_initrd_table(systab, p, start);
- p += ROUND_UP(sizeof(struct efi_initrd), 64 * KiB);
- init_efi_fdt_table(systab);
+#define EFI_INITRD_TABLE_GEN(type) \
+static void init_efi_initrd_table_##type(void *guidp, void **p) \
+{ \
+ efi_guid_t tbl_guid = LINUX_EFI_INITRD_MEDIA_GUID; \
+ struct efi_initrd_##type *initrd_table = *p; \
+ \
+ /* efi_configuration_table */ \
+ guidcpy(guidp, &tbl_guid); \
+ \
+ initrd_table->base = cpu_to_le##type(initrd_offset); \
+ initrd_table->size = cpu_to_le##type(initrd_size); \
+ *p += sizeof(struct efi_initrd_##type); \
+}
- systab->tables = (struct efi_configuration_table *)(bp_tables_start - start);
+#define BOOTP_ALIGN_PTR_UP(p, s, n) ({ \
+ uintptr_t __ptr = (uintptr_t)(s) + \
+ QEMU_ALIGN_UP((uintptr_t)(p) - (uintptr_t)(s), n); \
+ (typeof(p))(__ptr); \
+})
+
+#define EFI_INIT_SYSTAB_GEN(type) \
+ EFI_BOOT_MEMMAP_TABLE_GEN(type) \
+ EFI_INITRD_TABLE_GEN(type) \
+static void init_systab_##type(struct loongarch_boot_info *info, \
+ void *p, void *start) \
+{ \
+ uint32_t nr_tables = 0; \
+ const efi_guid_t fdt_guid = DEVICE_TREE_GUID; \
+ struct efi_system_table_##type *systab; \
+ struct efi_configuration_table_##type *cfg_tabs; \
+ \
+ p = BOOTP_ALIGN_PTR_UP(p, start, EFI_TABLE_ALIGN); \
+ systab = p; \
+ info->a2 = p - start; \
+ \
+ systab->hdr.signature = cpu_to_le64(EFI_SYSTEM_TABLE_SIGNATURE); \
+ systab->hdr.revision = cpu_to_le32(EFI_SPECIFICATION_VERSION); \
+ systab->hdr.headersize = \
+ cpu_to_le32(sizeof(struct efi_system_table_##type)); \
+ systab->fw_revision = \
+ cpu_to_le32(FW_VERSION << 16 | FW_PATCHLEVEL << 8); \
+ systab->runtime = 0; \
+ systab->boottime = 0; \
+ systab->nr_tables = 0; \
+ \
+ p += sizeof(struct efi_system_table_##type); \
+ systab->fw_vendor = cpu_to_le##type(p - start); \
+ init_efi_vendor_string(&p); \
+ \
+ p = BOOTP_ALIGN_PTR_UP(p, start, EFI_TABLE_ALIGN); \
+ systab->tables = cpu_to_le##type(p - start); \
+ cfg_tabs = p; \
+ p += sizeof(struct efi_configuration_table_##type) * 3; \
+ \
+ p = BOOTP_ALIGN_PTR_UP(p, start, EFI_TABLE_ALIGN); \
+ cfg_tabs[nr_tables].table = cpu_to_le##type(p - start); \
+ init_efi_boot_memmap_##type(&cfg_tabs[nr_tables].guid, &p); \
+ nr_tables++; \
+ \
+ if (initrd_size > 0) { \
+ cfg_tabs[nr_tables].table = cpu_to_le##type(p - start); \
+ init_efi_initrd_table_##type(&cfg_tabs[nr_tables].guid, &p); \
+ nr_tables++; \
+ } \
+ \
+ guidcpy(&cfg_tabs[nr_tables].guid, &fdt_guid); \
+ cfg_tabs[nr_tables].table = cpu_to_le##type(FDT_BASE); \
+ nr_tables++; \
+ \
+ systab->nr_tables = cpu_to_le32(nr_tables); \
+ efi_hdr_crc32(&systab->hdr); \
}
+EFI_INIT_SYSTAB_GEN(32)
+EFI_INIT_SYSTAB_GEN(64)
+
static void init_cmdline(struct loongarch_boot_info *info, void *p, void *start)
{
hwaddr cmdline_addr = p - start;
@@ -223,7 +301,7 @@ static void reset_load_elf(void *opaque)
cpu_reset(CPU(cpu));
if (env->load_elf) {
- if (cpu == LOONGARCH_CPU(first_cpu)) {
+ if (cpu == LOONGARCH_CPU(first_cpu)) {
env->gpr[4] = env->boot_info->a0;
env->gpr[5] = env->boot_info->a1;
env->gpr[6] = env->boot_info->a2;
@@ -265,21 +343,25 @@ static void loongarch_firmware_boot(LoongArchVirtMachineState *lvms,
fw_cfg_add_kernel_info(info, lvms->fw_cfg);
}
-static void init_boot_rom(struct loongarch_boot_info *info, void *p)
+static void init_boot_rom(struct loongarch_boot_info *info, void *p,
+ bool is_64bit)
{
void *start = p;
init_cmdline(info, p, start);
p += COMMAND_LINE_SIZE;
- init_systab(info, p, start);
+ if (is_64bit)
+ init_systab_64(info, p, start);
+ else
+ init_systab_32(info, p, start);
}
static void loongarch_direct_kernel_boot(struct loongarch_boot_info *info)
{
void *p, *bp;
int64_t kernel_addr = VIRT_FLASH0_BASE;
- LoongArchCPU *lacpu;
+ LoongArchCPU *lacpu = LOONGARCH_CPU(first_cpu);
CPUState *cs;
if (info->kernel_filename) {
@@ -293,7 +375,7 @@ static void loongarch_direct_kernel_boot(struct loongarch_boot_info *info)
/* Load cmdline and system tables at [0 - 1 MiB] */
p = g_malloc0(1 * MiB);
bp = p;
- init_boot_rom(info, p);
+ init_boot_rom(info, p, is_la64(&lacpu->env));
rom_add_blob_fixed_as("boot_info", bp, 1 * MiB, 0, &address_space_memory);
/* Load slave boot code at pflash0 . */
diff --git a/include/hw/loongarch/boot.h b/include/hw/loongarch/boot.h
index b3b870df1f097662dff7fc7c173f152da583d374..96ec15016a314499acf65c6c47e0c4932aa99d01 100644
--- a/include/hw/loongarch/boot.h
+++ b/include/hw/loongarch/boot.h
@@ -38,11 +38,35 @@ typedef struct {
EFI_GUID(0xb1b621d5, 0xf19c, 0x41a5, 0x83, 0x0b, \
0xd9, 0x15, 0x2c, 0x69, 0xaa, 0xe0)
+/* Memory types: */
+#define EFI_RESERVED_TYPE 0
+#define EFI_LOADER_CODE 1
+#define EFI_LOADER_DATA 2
+#define EFI_BOOT_SERVICES_CODE 3
+#define EFI_BOOT_SERVICES_DATA 4
+#define EFI_RUNTIME_SERVICES_CODE 5
+#define EFI_RUNTIME_SERVICES_DATA 6
+#define EFI_CONVENTIONAL_MEMORY 7
+#define EFI_UNUSABLE_MEMORY 8
+#define EFI_ACPI_RECLAIM_MEMORY 9
+#define EFI_ACPI_MEMORY_NVS 10
+#define EFI_MEMORY_MAPPED_IO 11
+#define EFI_MEMORY_MAPPED_IO_PORT_SPACE 12
+#define EFI_PAL_CODE 13
+#define EFI_PERSISTENT_MEMORY 14
+#define EFI_UNACCEPTED_MEMORY 15
+#define EFI_MAX_MEMORY_TYPE 16
+
+#define EFI_PAGE_SHIFT 12
+#define EFI_PAGE_SIZE (1UL << EFI_PAGE_SHIFT)
+
+#define EFI_TABLE_ALIGN (64 * KiB)
+
struct efi_config_table {
efi_guid_t guid;
uint64_t *ptr;
const char name[16];
-};
+} QEMU_PACKED;
typedef struct {
uint64_t signature;
@@ -50,51 +74,90 @@ typedef struct {
uint32_t headersize;
uint32_t crc32;
uint32_t reserved;
-} efi_table_hdr_t;
+} QEMU_PACKED efi_table_hdr_t;
-struct efi_configuration_table {
+struct efi_configuration_table_32 {
efi_guid_t guid;
- void *table;
-};
+ uint32_t table;
+} QEMU_PACKED;
-struct efi_system_table {
+struct efi_configuration_table_64 {
+ efi_guid_t guid;
+ uint64_t table;
+} QEMU_PACKED;
+
+struct efi_system_table_32 {
+ efi_table_hdr_t hdr;
+ uint32_t fw_vendor; /* physical addr of CHAR16 vendor string */
+ uint32_t fw_revision;
+ uint32_t con_in_handle;
+ uint32_t con_in;
+ uint32_t con_out_handle;
+ uint32_t con_out;
+ uint32_t stderr_handle;
+ uint32_t stderr_placeholder;
+ uint32_t runtime;
+ uint32_t boottime;
+ uint32_t nr_tables;
+ uint32_t tables;
+} QEMU_PACKED;
+
+struct efi_system_table_64 {
efi_table_hdr_t hdr;
uint64_t fw_vendor; /* physical addr of CHAR16 vendor string */
uint32_t fw_revision;
+ uint32_t __pad1;
uint64_t con_in_handle;
- uint64_t *con_in;
+ uint64_t con_in;
uint64_t con_out_handle;
- uint64_t *con_out;
+ uint64_t con_out;
uint64_t stderr_handle;
uint64_t stderr_placeholder;
- uint64_t *runtime;
- uint64_t *boottime;
- uint64_t nr_tables;
- struct efi_configuration_table *tables;
-};
+ uint64_t runtime;
+ uint64_t boottime;
+ uint32_t nr_tables;
+ uint32_t __pad2;
+ uint64_t tables;
+} QEMU_PACKED;
typedef struct {
uint32_t type;
- uint32_t pad;
+ uint32_t __pad;
uint64_t phys_addr;
uint64_t virt_addr;
uint64_t num_pages;
uint64_t attribute;
-} efi_memory_desc_t;
+} QEMU_PACKED efi_memory_desc_t;
+
+struct efi_boot_memmap_32 {
+ uint32_t map_size;
+ uint32_t desc_size;
+ uint32_t desc_ver;
+ uint32_t map_key;
+ uint32_t buff_size;
+ uint32_t __pad;
+ efi_memory_desc_t map[32];
+} QEMU_PACKED;
-struct efi_boot_memmap {
+struct efi_boot_memmap_64 {
uint64_t map_size;
uint64_t desc_size;
uint32_t desc_ver;
+ uint32_t __pad;
uint64_t map_key;
uint64_t buff_size;
efi_memory_desc_t map[32];
-};
+} QEMU_PACKED;
+
+struct efi_initrd_32 {
+ uint32_t base;
+ uint32_t size;
+} QEMU_PACKED;
-struct efi_initrd {
+struct efi_initrd_64 {
uint64_t base;
uint64_t size;
-};
+} QEMU_PACKED;
struct loongarch_boot_info {
uint64_t ram_size;
@@ -110,6 +173,11 @@ extern unsigned memmap_entries;
struct memmap_entry {
uint64_t address;
uint64_t length;
+ /* E820 style type */
+#define MEMMAP_TYPE_MEMORY 1
+#define MEMMAP_TYPE_RESERVED 2
+#define MEMMAP_TYPE_ACPI 3
+#define MEMMAP_TYPE_NVS 4
uint32_t type;
uint32_t reserved;
};
--
2.43.0© 2016 - 2024 Red Hat, Inc.