qmp: update vhost-user protocol feature maps

[PATCH] qmp: update vhost-user protocol feature maps

Posted by Laurent Vivier 1 year, 1 month ago

Add VHOST_USER_PROTOCOL_F_SHARED_OBJECT and
VHOST_USER_PROTOCOL_F_DEVICE_STATE protocol feature maps to
the virtio introspection.

Cc: jonah.palmer@oracle.com
Fixes: 160947666276 ("vhost-user: add shared_object msg")
Cc: aesteve@redhat.com
Fixes: cda83adc62b6 ("vhost-user: Interface for migration state transfer")
Cc: hreitz@redhat.com
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
---
 hw/virtio/virtio-qmp.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/hw/virtio/virtio-qmp.c b/hw/virtio/virtio-qmp.c
index cccc6fe76183..8a32a3b1052c 100644
--- a/hw/virtio/virtio-qmp.c
+++ b/hw/virtio/virtio-qmp.c
@@ -121,6 +121,12 @@ static const qmp_virtio_feature_map_t vhost_user_protocol_map[] = {
     FEATURE_ENTRY(VHOST_USER_PROTOCOL_F_STATUS, \
             "VHOST_USER_PROTOCOL_F_STATUS: Querying and notifying back-end "
             "device status supported"),
+    FEATURE_ENTRY(VHOST_USER_PROTOCOL_F_SHARED_OBJECT, \
+            "VHOST_USER_PROTOCOL_F_SHARED_OBJECT: Backend shared object "
+            "supported"),
+    FEATURE_ENTRY(VHOST_USER_PROTOCOL_F_DEVICE_STATE, \
+            "VHOST_USER_PROTOCOL_F_DEVICE_STATE: Backend device state transfer "
+            "supported"),
     { -1, "" }
 };
 
-- 
2.47.1

Re: [PATCH] qmp: update vhost-user protocol feature maps

Posted by Jonah Palmer 1 year, 1 month ago


On 12/16/24 12:09 PM, Laurent Vivier wrote:
> Add VHOST_USER_PROTOCOL_F_SHARED_OBJECT and
> VHOST_USER_PROTOCOL_F_DEVICE_STATE protocol feature maps to
> the virtio introspection.
> 
> Cc: jonah.palmer@oracle.com
> Fixes: 160947666276 ("vhost-user: add shared_object msg")
> Cc: aesteve@redhat.com
> Fixes: cda83adc62b6 ("vhost-user: Interface for migration state transfer")
> Cc: hreitz@redhat.com
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> ---
>   hw/virtio/virtio-qmp.c | 6 ++++++
>   1 file changed, 6 insertions(+)
> 
> diff --git a/hw/virtio/virtio-qmp.c b/hw/virtio/virtio-qmp.c
> index cccc6fe76183..8a32a3b1052c 100644
> --- a/hw/virtio/virtio-qmp.c
> +++ b/hw/virtio/virtio-qmp.c
> @@ -121,6 +121,12 @@ static const qmp_virtio_feature_map_t vhost_user_protocol_map[] = {
>       FEATURE_ENTRY(VHOST_USER_PROTOCOL_F_STATUS, \
>               "VHOST_USER_PROTOCOL_F_STATUS: Querying and notifying back-end "
>               "device status supported"),
> +    FEATURE_ENTRY(VHOST_USER_PROTOCOL_F_SHARED_OBJECT, \
> +            "VHOST_USER_PROTOCOL_F_SHARED_OBJECT: Backend shared object "
> +            "supported"),
> +    FEATURE_ENTRY(VHOST_USER_PROTOCOL_F_DEVICE_STATE, \
> +            "VHOST_USER_PROTOCOL_F_DEVICE_STATE: Backend device state transfer "
> +            "supported"),
>       { -1, "" }
>   };
>   
Signed-off-by: Jonah Palmer <jonah.palmer@oracle.com>
---
Jonah

Re: [PATCH] qmp: update vhost-user protocol feature maps

Posted by Michael Tokarev 1 year, 1 month ago

16.12.2024 20:30, Jonah Palmer wrote:
...

> Signed-off-by: Jonah Palmer <jonah.palmer@oracle.com>
Should this be a Reviewed-by instead?

Thanks,

/mjt

Re: [PATCH] qmp: update vhost-user protocol feature maps

Posted by Jonah Palmer 1 year, 1 month ago


On 12/22/24 4:13 AM, Michael Tokarev wrote:
> 16.12.2024 20:30, Jonah Palmer wrote:
> ...
> 
>> Signed-off-by: Jonah Palmer <jonah.palmer@oracle.com>
> Should this be a Reviewed-by instead?
> 
> Thanks,
> 
> /mjt

Oof, yes, it should've been. My apologies, I was on vacation and only 
saw this just now.

Re: [PATCH] qmp: update vhost-user protocol feature maps

Posted by Philippe Mathieu-Daudé 1 year ago

On 6/1/25 14:25, Jonah Palmer wrote:
> 
> 
> On 12/22/24 4:13 AM, Michael Tokarev wrote:
>> 16.12.2024 20:30, Jonah Palmer wrote:
>> ...
>>
>>> Signed-off-by: Jonah Palmer <jonah.palmer@oracle.com>
>> Should this be a Reviewed-by instead?
>>
>> Thanks,
>>
>> /mjt
> 
> Oof, yes, it should've been. My apologies, I was on vacation and only 
> saw this just now.

Already merged as commit 1e3d4d9a1a32ac6835f0d295a5117851c421fb5d.