[v1] migration: Drop/unexport migration_is_device() and migration_is_active()

[PATCH 8/9] migration: Drop migration_is_device()

Posted by Avihai Horon 3 months, 3 weeks ago

After being removed from VFIO, migration_is_device() no longer has any
users. Drop it.

Signed-off-by: Avihai Horon <avihaih@nvidia.com>
---
 include/migration/misc.h | 1 -
 migration/migration.c    | 7 -------
 2 files changed, 8 deletions(-)

diff --git a/include/migration/misc.h b/include/migration/misc.h
index 804eb23c06..ad1e25826a 100644
--- a/include/migration/misc.h
+++ b/include/migration/misc.h
@@ -54,7 +54,6 @@ void migration_object_init(void);
 void migration_shutdown(void);
 
 bool migration_is_active(void);
-bool migration_is_device(void);
 bool migration_is_running(void);
 bool migration_thread_is_self(void);
 
diff --git a/migration/migration.c b/migration/migration.c
index 8c5bd0a75c..18ca60af4f 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -1645,13 +1645,6 @@ bool migration_is_active(void)
             s->state == MIGRATION_STATUS_POSTCOPY_ACTIVE);
 }
 
-bool migration_is_device(void)
-{
-    MigrationState *s = current_migration;
-
-    return s->state == MIGRATION_STATUS_DEVICE;
-}
-
 bool migration_thread_is_self(void)
 {
     MigrationState *s = current_migration;
-- 
2.40.1

Re: [PATCH 8/9] migration: Drop migration_is_device()

Posted by Peter Xu 3 months, 3 weeks ago

On Mon, Dec 16, 2024 at 11:46:37AM +0200, Avihai Horon wrote:
> After being removed from VFIO, migration_is_device() no longer has any
> users. Drop it.
> 
> Signed-off-by: Avihai Horon <avihaih@nvidia.com>

Thanks for working on this, Avihai!

Acked-by: Peter Xu <peterx@redhat.com>

-- 
Peter Xu

Re: [PATCH 8/9] migration: Drop migration_is_device()

Posted by Cédric Le Goater 3 months, 3 weeks ago

On 12/16/24 10:46, Avihai Horon wrote:
> After being removed from VFIO, migration_is_device() no longer has any
> users. Drop it.
> 
> Signed-off-by: Avihai Horon <avihaih@nvidia.com>


Reviewed-by: Cédric Le Goater <clg@redhat.com>

Thanks,

C.


> ---
>   include/migration/misc.h | 1 -
>   migration/migration.c    | 7 -------
>   2 files changed, 8 deletions(-)
> 
> diff --git a/include/migration/misc.h b/include/migration/misc.h
> index 804eb23c06..ad1e25826a 100644
> --- a/include/migration/misc.h
> +++ b/include/migration/misc.h
> @@ -54,7 +54,6 @@ void migration_object_init(void);
>   void migration_shutdown(void);
>   
>   bool migration_is_active(void);
> -bool migration_is_device(void);
>   bool migration_is_running(void);
>   bool migration_thread_is_self(void);
>   
> diff --git a/migration/migration.c b/migration/migration.c
> index 8c5bd0a75c..18ca60af4f 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -1645,13 +1645,6 @@ bool migration_is_active(void)
>               s->state == MIGRATION_STATUS_POSTCOPY_ACTIVE);
>   }
>   
> -bool migration_is_device(void)
> -{
> -    MigrationState *s = current_migration;
> -
> -    return s->state == MIGRATION_STATUS_DEVICE;
> -}
> -
>   bool migration_thread_is_self(void)
>   {
>       MigrationState *s = current_migration;