Hi,
Thanks for the new version, changes are ok for me!
@Michael @LiuYi, @Jason, do you think we are ready to move forward?
Thanks
>cmd
On 12/12/2024 09:37, Zhenzhong Duan wrote:
> Caution: External email. Do not open attachments or click links, unless this email comes from a known sender and you know the content is safe.
>
>
> Hi,
>
> Per Jason Wang's suggestion, iommufd nesting series[1] is split into
> "Enable stage-1 translation for emulated device" series and
> "Enable stage-1 translation for passthrough device" series.
>
> PATCH1-5: Some preparing work before support stage-1 translation
> PATCH6-9: Implement stage-1 translation for emulated device
> PATCH10-14:Emulate iotlb invalidation of stage-1 mapping
> PATCH15-17:Set default aw_bits to 48 in all modes, update DMAR table
> PATCH18-19:Expose scalable mode "x-flts" and "fs1gp" to cmdline
> PATCH20: Add qtest
>
> Note in spec revision 3.4, it renames "First-level" to "First-stage",
> "Second-level" to "Second-stage". But the scalable mode was added
> before that change. So we keep old favor using First-level/fl/Second-level/sl
> in code but change to use stage-1/stage-2 in commit log.
> But keep in mind First-level/fl/stage-1 all have same meaning,
> same for Second-level/sl/stage-2.
>
> Test done:
> - two VFIO devices hotplug/unplug in legacy and scalable mode with x-flts=on/off
> - vhost with caching-mode=off
> - windows 2019 VM bootup
>
> Qemu code can be found at [2]
> The whole nesting series can be found at [3]
>
> [1] https://lists.gnu.org/archive/html/qemu-devel/2024-01/msg02740.html
> [2] https://github.com/yiliu1765/qemu/tree/zhenzhong/iommufd_stage1_emu_v6
> [3] https://github.com/yiliu1765/qemu/tree/zhenzhong/iommufd_nesting_rfcv2
>
> Thanks
> Zhenzhong
>
> Changelog:
> v6:
> - s/"Legacy mode: not support x-flts=on"/"x-flts is only available in scalable mode" (Clement)
> - drop scalable modern mode concept totally (Jason, Clement)
>
> v5:
> - add new patch8 to check if translation result fall in ir range (Liuyi)
> - remove unused parameter ih from vtd_piotlb_page_invalidate() (Liuyi)
> - define target as pointer in vtd_find_as_by_sid_and_pasid() (Liuyi)
> - s/x-fls/x-flts (Liuyi)
> - set default aw_bits to 48 for all modes (jason)
> - fix return value of vtd_iova_to_flpte()
> - merge piotlb inv notify to vtd_iotlb_page_invalidate_notify(),
> no functional change
>
> v4:
> - s/Scalable legacy/Scalable in logging (Clement)
> - test the mode first to make the intention clearer (Clement)
> - s/x-cap-fs1gp/fs1gp and s/VTD_FL_RW_MASK/VTD_FL_RW (Jason)
> - introduce x-fls instead of updating x-scalable-mode (Jason)
> - Refine comment log in patch4 (jason)
> - s/tansltion/translation/ and s/VTD_SPTE_RSVD_LEN/VTD_FPTE_RSVD_LEN/ (Liuyi)
> - update the order and naming of VTD_FPTE_PAGE_* (Liuyi)
>
> v3:
> - drop unnecessary !(s->ecap & VTD_ECAP_SMTS) (Clement)
> - simplify calculation of return value for vtd_iova_fl_check_canonical() (Liuyi)
> - make A/D bit setting atomic (Liuyi)
> - refine error msg (Clement, Liuyi)
>
> v2:
> - check ecap/cap bits instead of s->scalable_modern in vtd_pe_type_check() (Clement)
> - declare VTD_ECAP_FLTS/FS1GP after the feature is implemented (Clement)
> - define VTD_INV_DESC_PIOTLB_G (Clement)
> - make error msg consistent in vtd_process_piotlb_desc() (Clement)
> - refine commit log in patch16 (Clement)
> - add VTD_ECAP_IR to ECAP_MODERN_FIXED1 (Clement)
> - add a knob x-cap-fs1gp to control stage-1 1G paging capability
> - collect Clement's R-B
>
> v1:
> - define VTD_HOST_AW_AUTO (Clement)
> - passing pgtt as a parameter to vtd_update_iotlb (Clement)
> - prefix sl_/fl_ to second/first level specific functions (Clement)
> - pick reserved bit check from Clement, add his Co-developed-by
> - Update test without using libqtest-single.h (Thomas)
>
> rfcv2:
> - split from nesting series (Jason)
> - merged some commits from Clement
> - add qtest (jason)
>
>
> Clément Mathieu--Drif (4):
> intel_iommu: Check if the input address is canonical
> intel_iommu: Set accessed and dirty bits during stage-1 translation
> intel_iommu: Add an internal API to find an address space with PASID
> intel_iommu: Add support for PASID-based device IOTLB invalidation
>
> Yi Liu (2):
> intel_iommu: Rename slpte to pte
> intel_iommu: Implement stage-1 translation
>
> Yu Zhang (1):
> intel_iommu: Use the latest fault reasons defined by spec
>
> Zhenzhong Duan (13):
> intel_iommu: Make pasid entry type check accurate
> intel_iommu: Add a placeholder variable for scalable mode stage-1
> translation
> intel_iommu: Flush stage-2 cache in PASID-selective PASID-based iotlb
> invalidation
> intel_iommu: Check stage-1 translation result with interrupt range
> intel_iommu: Flush stage-1 cache in iotlb invalidation
> intel_iommu: Process PASID-based iotlb invalidation
> intel_iommu: piotlb invalidation should notify unmap
> tests/acpi: q35: allow DMAR acpi table changes
> intel_iommu: Set default aw_bits to 48 starting from QEMU 9.2
> tests/acpi: q35: Update host address width in DMAR
> intel_iommu: Introduce a property x-flts for stage-1 translation
> intel_iommu: Introduce a property to control FS1GP cap bit setting
> tests/qtest: Add intel-iommu test
>
> MAINTAINERS | 1 +
> hw/i386/intel_iommu_internal.h | 101 ++++-
> include/hw/i386/intel_iommu.h | 8 +-
> hw/i386/intel_iommu.c | 732 ++++++++++++++++++++++++------
> hw/i386/pc.c | 1 +
> tests/qtest/intel-iommu-test.c | 64 +++
> tests/data/acpi/x86/q35/DMAR.dmar | Bin 120 -> 120 bytes
> tests/qtest/meson.build | 1 +
> 8 files changed, 748 insertions(+), 160 deletions(-)
> create mode 100644 tests/qtest/intel-iommu-test.c
>
> --
> 2.34.1
>