[v1] tcg: Remove in-flight mask data from OptContext

[PATCH 05/46] tcg/optimize: Use finish_folding in fold_addsub2

Posted by Richard Henderson 5 months ago

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 tcg/optimize.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tcg/optimize.c b/tcg/optimize.c
index 3f2f351bae..135b14974f 100644
--- a/tcg/optimize.c
+++ b/tcg/optimize.c
@@ -1292,7 +1292,7 @@ static bool fold_addsub2(OptContext *ctx, TCGOp *op, bool add)
         op->args[4] = arg_new_constant(ctx, bl);
         op->args[5] = arg_new_constant(ctx, bh);
     }
-    return false;
+    return finish_folding(ctx, op);
 }
 
 static bool fold_add2(OptContext *ctx, TCGOp *op)
-- 
2.43.0

Re: [PATCH 05/46] tcg/optimize: Use finish_folding in fold_addsub2

Posted by Pierrick Bouvier 4 months, 3 weeks ago

On 12/10/24 07:23, Richard Henderson wrote:
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>   tcg/optimize.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tcg/optimize.c b/tcg/optimize.c
> index 3f2f351bae..135b14974f 100644
> --- a/tcg/optimize.c
> +++ b/tcg/optimize.c
> @@ -1292,7 +1292,7 @@ static bool fold_addsub2(OptContext *ctx, TCGOp *op, bool add)
>           op->args[4] = arg_new_constant(ctx, bl);
>           op->args[5] = arg_new_constant(ctx, bh);
>       }
> -    return false;
> +    return finish_folding(ctx, op);
>   }
>   
>   static bool fold_add2(OptContext *ctx, TCGOp *op)

Any reason to separate this patch from previous one?

Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>