[PATCH 34/46] tcg/optimize: Use finish_folding in fold_cmp_vec

Richard Henderson posted 46 patches 5 months ago
There is a newer version of this series
[PATCH 34/46] tcg/optimize: Use finish_folding in fold_cmp_vec
Posted by Richard Henderson 5 months ago
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 tcg/optimize.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tcg/optimize.c b/tcg/optimize.c
index dd6ef3d831..30446baabd 100644
--- a/tcg/optimize.c
+++ b/tcg/optimize.c
@@ -2462,7 +2462,7 @@ static bool fold_cmp_vec(OptContext *ctx, TCGOp *op)
     if (swap_commutative(NO_DEST, &op->args[1], &op->args[2])) {
         op->args[3] = tcg_swap_cond(op->args[3]);
     }
-    return false;
+    return finish_folding(ctx, op);
 }
 
 static bool fold_cmpsel_vec(OptContext *ctx, TCGOp *op)
-- 
2.43.0
Re: [PATCH 34/46] tcg/optimize: Use finish_folding in fold_cmp_vec
Posted by Pierrick Bouvier 4 months, 3 weeks ago
On 12/10/24 07:23, Richard Henderson wrote:
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>   tcg/optimize.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tcg/optimize.c b/tcg/optimize.c
> index dd6ef3d831..30446baabd 100644
> --- a/tcg/optimize.c
> +++ b/tcg/optimize.c
> @@ -2462,7 +2462,7 @@ static bool fold_cmp_vec(OptContext *ctx, TCGOp *op)
>       if (swap_commutative(NO_DEST, &op->args[1], &op->args[2])) {
>           op->args[3] = tcg_swap_cond(op->args[3]);
>       }
> -    return false;
> +    return finish_folding(ctx, op);
>   }
>   
>   static bool fold_cmpsel_vec(OptContext *ctx, TCGOp *op)

Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>