[v1] tcg: Remove in-flight mask data from OptContext

[PATCH 32/46] tcg/optimize: Use fold_masks_zs in fold_negsetcond

Posted by Richard Henderson 5 months ago

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 tcg/optimize.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/tcg/optimize.c b/tcg/optimize.c
index cfd4c08f11..0097502425 100644
--- a/tcg/optimize.c
+++ b/tcg/optimize.c
@@ -2369,8 +2369,7 @@ static bool fold_negsetcond(OptContext *ctx, TCGOp *op)
     }
 
     /* Value is {0,-1} so all bits are repetitions of the sign. */
-    ctx->s_mask = -1;
-    return false;
+    return fold_masks_zs(ctx, op, -1, -1);
 }
 
 static bool fold_setcond2(OptContext *ctx, TCGOp *op)
-- 
2.43.0

Re: [PATCH 32/46] tcg/optimize: Use fold_masks_zs in fold_negsetcond

Posted by Pierrick Bouvier 4 months, 3 weeks ago

On 12/10/24 07:23, Richard Henderson wrote:
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>   tcg/optimize.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/tcg/optimize.c b/tcg/optimize.c
> index cfd4c08f11..0097502425 100644
> --- a/tcg/optimize.c
> +++ b/tcg/optimize.c
> @@ -2369,8 +2369,7 @@ static bool fold_negsetcond(OptContext *ctx, TCGOp *op)
>       }
>   
>       /* Value is {0,-1} so all bits are repetitions of the sign. */
> -    ctx->s_mask = -1;
> -    return false;
> +    return fold_masks_zs(ctx, op, -1, -1);
>   }
>   
>   static bool fold_setcond2(OptContext *ctx, TCGOp *op)

Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>