[v1] tcg: Remove in-flight mask data from OptContext

[PATCH 31/46] tcg/optimize: Use fold_masks_z in fold_setcond

Posted by Richard Henderson 5 months ago

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 tcg/optimize.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/tcg/optimize.c b/tcg/optimize.c
index 7b1d437c27..cfd4c08f11 100644
--- a/tcg/optimize.c
+++ b/tcg/optimize.c
@@ -2349,9 +2349,7 @@ static bool fold_setcond(OptContext *ctx, TCGOp *op)
         fold_setcond_tst_pow2(ctx, op, false);
     }
 
-    ctx->z_mask = 1;
-    ctx->s_mask = smask_from_zmask(1);
-    return false;
+    return fold_masks_z(ctx, op, 1);
 }
 
 static bool fold_negsetcond(OptContext *ctx, TCGOp *op)
-- 
2.43.0

Re: [PATCH 31/46] tcg/optimize: Use fold_masks_z in fold_setcond

Posted by Pierrick Bouvier 4 months, 3 weeks ago

On 12/10/24 07:23, Richard Henderson wrote:
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>   tcg/optimize.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/tcg/optimize.c b/tcg/optimize.c
> index 7b1d437c27..cfd4c08f11 100644
> --- a/tcg/optimize.c
> +++ b/tcg/optimize.c
> @@ -2349,9 +2349,7 @@ static bool fold_setcond(OptContext *ctx, TCGOp *op)
>           fold_setcond_tst_pow2(ctx, op, false);
>       }
>   
> -    ctx->z_mask = 1;
> -    ctx->s_mask = smask_from_zmask(1);
> -    return false;
> +    return fold_masks_z(ctx, op, 1);
>   }
>   
>   static bool fold_negsetcond(OptContext *ctx, TCGOp *op)

Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>