[v1] tcg: Remove in-flight mask data from OptContext

[PATCH 13/46] tcg/optimize: Use finish_folding in fold_dup, fold_dup2

Posted by Richard Henderson 5 months ago

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 tcg/optimize.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tcg/optimize.c b/tcg/optimize.c
index 59f510b49a..e6dc9f2e28 100644
--- a/tcg/optimize.c
+++ b/tcg/optimize.c
@@ -1681,7 +1681,7 @@ static bool fold_dup(OptContext *ctx, TCGOp *op)
         t = dup_const(TCGOP_VECE(op), t);
         return tcg_opt_gen_movi(ctx, op, op->args[0], t);
     }
-    return false;
+    return finish_folding(ctx, op);
 }
 
 static bool fold_dup2(OptContext *ctx, TCGOp *op)
@@ -1696,7 +1696,7 @@ static bool fold_dup2(OptContext *ctx, TCGOp *op)
         op->opc = INDEX_op_dup_vec;
         TCGOP_VECE(op) = MO_32;
     }
-    return false;
+    return finish_folding(ctx, op);
 }
 
 static bool fold_eqv(OptContext *ctx, TCGOp *op)
-- 
2.43.0

Re: [PATCH 13/46] tcg/optimize: Use finish_folding in fold_dup, fold_dup2

Posted by Pierrick Bouvier 4 months, 3 weeks ago

On 12/10/24 07:23, Richard Henderson wrote:
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>   tcg/optimize.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tcg/optimize.c b/tcg/optimize.c
> index 59f510b49a..e6dc9f2e28 100644
> --- a/tcg/optimize.c
> +++ b/tcg/optimize.c
> @@ -1681,7 +1681,7 @@ static bool fold_dup(OptContext *ctx, TCGOp *op)
>           t = dup_const(TCGOP_VECE(op), t);
>           return tcg_opt_gen_movi(ctx, op, op->args[0], t);
>       }
> -    return false;
> +    return finish_folding(ctx, op);
>   }
>   
>   static bool fold_dup2(OptContext *ctx, TCGOp *op)
> @@ -1696,7 +1696,7 @@ static bool fold_dup2(OptContext *ctx, TCGOp *op)
>           op->opc = INDEX_op_dup_vec;
>           TCGOP_VECE(op) = MO_32;
>       }
> -    return false;
> +    return finish_folding(ctx, op);
>   }
>   
>   static bool fold_eqv(OptContext *ctx, TCGOp *op)

Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>