[v1] hw/nvram/fw_cfg: Move PCI bus methods out

[PATCH 0/6] hw/nvram/fw_cfg: Move PCI bus methods out

Philippe Mathieu-Daudé posted 6 patches 4 months ago

Diff against v2
Download series mbox

There is a newer version of this series

include/hw/nvram/fw_cfg.h | 21 ++++++----------
include/hw/pci/pci.h      |  3 +++
hw/arm/virt.c             |  3 ++-
hw/hppa/machine.c         |  2 +-
hw/i386/pc.c              |  3 ++-
hw/nvram/fw_cfg.c         | 34 +++++--------------------
hw/pci/pci.c              | 53 +++++++++++++++++++++++++++++++++++++++
system/vl.c               |  3 ++-
8 files changed, 76 insertions(+), 46 deletions(-)

Expand all Fold all

[PATCH 0/6] hw/nvram/fw_cfg: Move PCI bus methods out

Posted by Philippe Mathieu-Daudé 4 months ago

In order to keep fw_cfg device model clean, remove the PCI
bus specific code. Instead, the equivalent functionality is
implemented within the PCI_BUS object in hw/pci/,
implementing TYPE_FW_CFG_DATA_GENERATOR_INTERFACE.

Philippe Mathieu-Daudé (6):
  hw/nvram/fw_cfg: Rename fw_cfg_add_[file]_from_generator()
  hw/nvram/fw_cfg: Pass QOM parent to fw_cfg_add_file_from_generator()
  hw/pci: Have PCI_BUS implement TYPE_FW_CFG_DATA_GENERATOR_INTERFACE
  hw/pci: Add pci_bus_add_fw_cfg_extra_pci_roots() helper
  hw: Use pci_bus_add_fw_cfg_extra_pci_roots()
  hw/nvram/fw_cfg: Remove fw_cfg_add_extra_pci_roots()

 include/hw/nvram/fw_cfg.h | 21 ++++++----------
 include/hw/pci/pci.h      |  3 +++
 hw/arm/virt.c             |  3 ++-
 hw/hppa/machine.c         |  2 +-
 hw/i386/pc.c              |  3 ++-
 hw/nvram/fw_cfg.c         | 34 +++++--------------------
 hw/pci/pci.c              | 53 +++++++++++++++++++++++++++++++++++++++
 system/vl.c               |  3 ++-
 8 files changed, 76 insertions(+), 46 deletions(-)

-- 
2.45.2

Re: [PATCH 0/6] hw/nvram/fw_cfg: Move PCI bus methods out

Posted by Philippe Mathieu-Daudé 3 months, 3 weeks ago

On 6/12/24 19:13, Philippe Mathieu-Daudé wrote:
> In order to keep fw_cfg device model clean, remove the PCI
> bus specific code. Instead, the equivalent functionality is
> implemented within the PCI_BUS object in hw/pci/,
> implementing TYPE_FW_CFG_DATA_GENERATOR_INTERFACE.
> 
> Philippe Mathieu-Daudé (6):
>    hw/nvram/fw_cfg: Rename fw_cfg_add_[file]_from_generator()
>    hw/nvram/fw_cfg: Pass QOM parent to fw_cfg_add_file_from_generator()
>    hw/pci: Have PCI_BUS implement TYPE_FW_CFG_DATA_GENERATOR_INTERFACE
>    hw/pci: Add pci_bus_add_fw_cfg_extra_pci_roots() helper
>    hw: Use pci_bus_add_fw_cfg_extra_pci_roots()
>    hw/nvram/fw_cfg: Remove fw_cfg_add_extra_pci_roots()

ping