target/arm: Helper type cleanups

[PATCH 0/9] target/arm: Helper type cleanups

Posted by Richard Henderson 4 months, 1 week ago

Add macros such that "fpst" can be used with DEF_HELPER to
indicate float_status* instead of "ptr" for void*.
In addition, fix a few uses of "ptr" that should be "env".

r~

Richard Henderson (9):
  target/arm: Introduce fpst alias for helper.h
  target/arm: Convert vfp_helper.c to fpst alias
  target/arm: Convert helper-a64.c to fpst alias
  target/arm: Convert vec_helper.c to fpst alias
  target/arm: Convert neon_helper.c to fpst alias
  target/arm: Convert sve_helper.c to fpst alias
  target/arm: Convert sme_helper.c to fpst alias
  target/arm: Convert vec_helper.c to use env alias
  target/arm: Convert neon_helper.c to use env alias

 target/arm/helper.h          | 638 ++++++++++++++++++-----------------
 target/arm/tcg/helper-a64.h  | 114 +++----
 target/arm/tcg/helper-sme.h  |   4 +-
 target/arm/tcg/helper-sve.h  | 426 +++++++++++------------
 target/arm/tcg/helper-a64.c  |  98 ++----
 target/arm/tcg/neon_helper.c |  27 +-
 target/arm/tcg/sme_helper.c  |   8 +-
 target/arm/tcg/sve_helper.c  |  96 +++---
 target/arm/tcg/vec_helper.c  |  81 ++---
 target/arm/vfp_helper.c      | 120 +++----
 10 files changed, 775 insertions(+), 837 deletions(-)

-- 
2.43.0

Re: [PATCH 0/9] target/arm: Helper type cleanups

Posted by Peter Maydell 3 months, 4 weeks ago

On Fri, 6 Dec 2024 at 03:13, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> Add macros such that "fpst" can be used with DEF_HELPER to
> indicate float_status* instead of "ptr" for void*.
> In addition, fix a few uses of "ptr" that should be "env".
>
> r~
>
> Richard Henderson (9):
>   target/arm: Introduce fpst alias for helper.h
>   target/arm: Convert vfp_helper.c to fpst alias
>   target/arm: Convert helper-a64.c to fpst alias
>   target/arm: Convert vec_helper.c to fpst alias
>   target/arm: Convert neon_helper.c to fpst alias
>   target/arm: Convert sve_helper.c to fpst alias
>   target/arm: Convert sme_helper.c to fpst alias
>   target/arm: Convert vec_helper.c to use env alias
>   target/arm: Convert neon_helper.c to use env alias

I see that commit a9af119f3d to put the fpst alias into
helper-head.h.inc is already upstream, superseding patch
1 from this series, so I've queued the remaining patches
2..9 to target-arm.next.

thanks
-- PMM

Re: [PATCH 0/9] target/arm: Helper type cleanups

Posted by Richard Henderson 3 months, 4 weeks ago

On 12/16/24 08:01, Peter Maydell wrote:
> On Fri, 6 Dec 2024 at 03:13, Richard Henderson
> <richard.henderson@linaro.org> wrote:
>>
>> Add macros such that "fpst" can be used with DEF_HELPER to
>> indicate float_status* instead of "ptr" for void*.
>> In addition, fix a few uses of "ptr" that should be "env".
>>
>> r~
>>
>> Richard Henderson (9):
>>    target/arm: Introduce fpst alias for helper.h
>>    target/arm: Convert vfp_helper.c to fpst alias
>>    target/arm: Convert helper-a64.c to fpst alias
>>    target/arm: Convert vec_helper.c to fpst alias
>>    target/arm: Convert neon_helper.c to fpst alias
>>    target/arm: Convert sve_helper.c to fpst alias
>>    target/arm: Convert sme_helper.c to fpst alias
>>    target/arm: Convert vec_helper.c to use env alias
>>    target/arm: Convert neon_helper.c to use env alias
> 
> I see that commit a9af119f3d to put the fpst alias into
> helper-head.h.inc is already upstream, superseding patch
> 1 from this series, so I've queued the remaining patches
> 2..9 to target-arm.next.

Thanks!

r~