[v1] tests/functional: Fix tests failing when TCG is not available on macOS

[PATCH-for-9.2? 0/2] tests/functional: Fix tests failing when TCG is not available on macOS

Philippe Mathieu-Daudé posted 2 patches 1 year, 2 months ago

Diff against v2
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20241202204020.55665-1-philmd@linaro.org

Maintainers: Eduardo Habkost <eduardo@habkost.net>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Yanan Wang <wangyanan55@huawei.com>, Zhao Liu <zhao1.liu@intel.com>, Markus Armbruster <armbru@redhat.com>

There is a newer version of this series

tests/functional/test_empty_cpu_model.py | 2 +-
tests/functional/test_version.py         | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

Expand all Fold all

[PATCH-for-9.2? 0/2] tests/functional: Fix tests failing when TCG is not available on macOS

Posted by Philippe Mathieu-Daudé 1 year, 2 months ago

Explicit the QTest accelerator to have these 2 tests
pass on macOS when only HVF is built in.

Philippe Mathieu-Daudé (2):
  tests/functional/test_version: Use QTest accelerator
  tests/functional/test_empty_cpu_model: Use QTest accelerator

 tests/functional/test_empty_cpu_model.py | 2 +-
 tests/functional/test_version.py         | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

-- 
2.45.2

Re: [PATCH-for-9.2? 0/2] tests/functional: Fix tests failing when TCG is not available on macOS

Posted by Thomas Huth 1 year, 2 months ago

On 02/12/2024 21.40, Philippe Mathieu-Daudé wrote:
> Explicit the QTest accelerator to have these 2 tests
> pass on macOS when only HVF is built in.

Could we maybe rather add something like this at the top of 
tests/functional/meson.build :

if 'CONFIG_TCG' not in config_all and 'CONFIG_KVM' not in config_all
   subdir_done()
endif

?

  Thomas

Re: [PATCH-for-9.2? 0/2] tests/functional: Fix tests failing when TCG is not available on macOS

Posted by Philippe Mathieu-Daudé 1 year, 2 months ago

On 2/12/24 21:56, Thomas Huth wrote:
> On 02/12/2024 21.40, Philippe Mathieu-Daudé wrote:
>> Explicit the QTest accelerator to have these 2 tests
>> pass on macOS when only HVF is built in.
> 
> Could we maybe rather add something like this at the top of tests/ 
> functional/meson.build :
> 
> if 'CONFIG_TCG' not in config_all and 'CONFIG_KVM' not in config_all
>    subdir_done()
> endif

I'd rather not:
- these tests don't need anything of TCG/KVM/HVF
- we can run functional tests using QTest [*]

[*] I'm actually using that to test my qemu-system-any
     binary which has HW models but no vCPU nor accelerator
     right now (except QTest).

Re: [PATCH-for-9.2? 0/2] tests/functional: Fix tests failing when TCG is not available on macOS

Posted by Thomas Huth 1 year, 2 months ago

On 02/12/2024 22.01, Philippe Mathieu-Daudé wrote:
> On 2/12/24 21:56, Thomas Huth wrote:
>> On 02/12/2024 21.40, Philippe Mathieu-Daudé wrote:
>>> Explicit the QTest accelerator to have these 2 tests
>>> pass on macOS when only HVF is built in.
>>
>> Could we maybe rather add something like this at the top of tests/ 
>> functional/meson.build :
>>
>> if 'CONFIG_TCG' not in config_all and 'CONFIG_KVM' not in config_all
>>    subdir_done()
>> endif
> 
> I'd rather not:
> - these tests don't need anything of TCG/KVM/HVF
> - we can run functional tests using QTest [*]

Ok, but then please switch to "-accel qtest" instead of "-machine 
...,accel=qtest" since the latter is legacy and might go away sometime in 
the future.

  Thanks,
   Thomas

Re: [PATCH-for-9.2? 0/2] tests/functional: Fix tests failing when TCG is not available on macOS

Posted by Philippe Mathieu-Daudé 1 year, 2 months ago

On 3/12/24 07:11, Thomas Huth wrote:
> On 02/12/2024 22.01, Philippe Mathieu-Daudé wrote:
>> On 2/12/24 21:56, Thomas Huth wrote:
>>> On 02/12/2024 21.40, Philippe Mathieu-Daudé wrote:
>>>> Explicit the QTest accelerator to have these 2 tests
>>>> pass on macOS when only HVF is built in.
>>>
>>> Could we maybe rather add something like this at the top of tests/ 
>>> functional/meson.build :
>>>
>>> if 'CONFIG_TCG' not in config_all and 'CONFIG_KVM' not in config_all
>>>    subdir_done()
>>> endif
>>
>> I'd rather not:
>> - these tests don't need anything of TCG/KVM/HVF
>> - we can run functional tests using QTest [*]
> 
> Ok, but then please switch to "-accel qtest" instead of "- 
> machine ...,accel=qtest" since the latter is legacy and might go away 
> sometime in the future.

Doh I thought it was the opposite :/ Sure!

> 
>   Thanks,
>    Thomas
>