[PATCH 01/22] tests/functional: increase timeouts for arm sx1 test

Daniel P. Berrangé posted 22 patches 3 weeks, 5 days ago
There is a newer version of this series
[PATCH 01/22] tests/functional: increase timeouts for arm sx1 test
Posted by Daniel P. Berrangé 3 weeks, 5 days ago
When under high load the test VM does not complete running in the
default 30 second timeout. Double it to give more headroom.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 tests/functional/test_arm_sx1.py | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tests/functional/test_arm_sx1.py b/tests/functional/test_arm_sx1.py
index 2d86405831..2292317946 100755
--- a/tests/functional/test_arm_sx1.py
+++ b/tests/functional/test_arm_sx1.py
@@ -44,7 +44,7 @@ def test_arm_sx1_initrd(self):
         self.vm.add_args('-no-reboot')
         self.launch_kernel(zimage_path,
                            initrd=initrd_path)
-        self.vm.wait()
+        self.vm.wait(timeout=60)
 
     def test_arm_sx1_sd(self):
         self.set_machine('sx1')
@@ -55,7 +55,7 @@ def test_arm_sx1_sd(self):
         self.vm.add_args('-snapshot')
         self.vm.add_args('-drive', f'format=raw,if=sd,file={sd_fs_path}')
         self.launch_kernel(zimage_path)
-        self.vm.wait()
+        self.vm.wait(timeout=60)
 
     def test_arm_sx1_flash(self):
         self.set_machine('sx1')
@@ -66,7 +66,7 @@ def test_arm_sx1_flash(self):
         self.vm.add_args('-snapshot')
         self.vm.add_args('-drive', f'format=raw,if=pflash,file={flash_path}')
         self.launch_kernel(zimage_path)
-        self.vm.wait()
+        self.vm.wait(timeout=60)
 
 if __name__ == '__main__':
     LinuxKernelTest.main()
-- 
2.46.0


Re: [PATCH 01/22] tests/functional: increase timeouts for arm sx1 test
Posted by Thomas Huth 3 weeks, 5 days ago
On 29/11/2024 18.30, Daniel P. Berrangé wrote:
> When under high load the test VM does not complete running in the
> default 30 second timeout. Double it to give more headroom.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>   tests/functional/test_arm_sx1.py | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/functional/test_arm_sx1.py b/tests/functional/test_arm_sx1.py
> index 2d86405831..2292317946 100755
> --- a/tests/functional/test_arm_sx1.py
> +++ b/tests/functional/test_arm_sx1.py
> @@ -44,7 +44,7 @@ def test_arm_sx1_initrd(self):
>           self.vm.add_args('-no-reboot')
>           self.launch_kernel(zimage_path,
>                              initrd=initrd_path)
> -        self.vm.wait()
> +        self.vm.wait(timeout=60)
>   
>       def test_arm_sx1_sd(self):
>           self.set_machine('sx1')
> @@ -55,7 +55,7 @@ def test_arm_sx1_sd(self):
>           self.vm.add_args('-snapshot')
>           self.vm.add_args('-drive', f'format=raw,if=sd,file={sd_fs_path}')
>           self.launch_kernel(zimage_path)
> -        self.vm.wait()
> +        self.vm.wait(timeout=60)
>   
>       def test_arm_sx1_flash(self):
>           self.set_machine('sx1')
> @@ -66,7 +66,7 @@ def test_arm_sx1_flash(self):
>           self.vm.add_args('-snapshot')
>           self.vm.add_args('-drive', f'format=raw,if=pflash,file={flash_path}')
>           self.launch_kernel(zimage_path)
> -        self.vm.wait()
> +        self.vm.wait(timeout=60)

Ah! I think I've seen this test sometimes failing, too, good to know that it 
was likely just this simple reason!

Reviewed-by: Thomas Huth <thuth@redhat.com>