hw/usb/hcd-xhci-nec: Remove unused XHCINecState::flags field

[PATCH] hw/usb/hcd-xhci-nec: Remove unused XHCINecState::flags field

Posted by Philippe Mathieu-Daudé 4 weeks, 1 day ago

Commit b9599519a01 ("hw/usb/hcd-xhci: Remove XHCI_FLAG_SS_FIRST
flag") remove the last use of XHCINecState::flags but neglected
to remove it; do that now.

Reported-by: Nicholas Piggin <npiggin@gmail.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 hw/usb/hcd-xhci-nec.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/hw/usb/hcd-xhci-nec.c b/hw/usb/hcd-xhci-nec.c
index 0c063b3697d..1a191fc7372 100644
--- a/hw/usb/hcd-xhci-nec.c
+++ b/hw/usb/hcd-xhci-nec.c
@@ -30,10 +30,8 @@
 OBJECT_DECLARE_SIMPLE_TYPE(XHCINecState, NEC_XHCI)
 
 struct XHCINecState {
-    /*< private >*/
     XHCIPciState parent_obj;
-    /*< public >*/
-    uint32_t flags;
+
     uint32_t intrs;
     uint32_t slots;
 };
@@ -51,7 +49,6 @@ static void nec_xhci_instance_init(Object *obj)
     XHCIPciState *pci = XHCI_PCI(obj);
     XHCINecState *nec = NEC_XHCI(obj);
 
-    pci->xhci.flags    = nec->flags;
     pci->xhci.numintrs = nec->intrs;
     pci->xhci.numslots = nec->slots;
 }
-- 
2.45.2

Re: [PATCH] hw/usb/hcd-xhci-nec: Remove unused XHCINecState::flags field

Posted by Philippe Mathieu-Daudé 1 week, 6 days ago

On 27/11/24 13:28, Philippe Mathieu-Daudé wrote:
> Commit b9599519a01 ("hw/usb/hcd-xhci: Remove XHCI_FLAG_SS_FIRST
> flag") remove the last use of XHCINecState::flags but neglected
> to remove it; do that now.
> 
> Reported-by: Nicholas Piggin <npiggin@gmail.com>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   hw/usb/hcd-xhci-nec.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)

Patch queued.

Re: [PATCH] hw/usb/hcd-xhci-nec: Remove unused XHCINecState::flags field

Posted by Thomas Huth 2 weeks, 6 days ago

On 27/11/2024 13.28, Philippe Mathieu-Daudé wrote:
> Commit b9599519a01 ("hw/usb/hcd-xhci: Remove XHCI_FLAG_SS_FIRST
> flag") remove the last use of XHCINecState::flags but neglected
> to remove it; do that now.
> 
> Reported-by: Nicholas Piggin <npiggin@gmail.com>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   hw/usb/hcd-xhci-nec.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/hw/usb/hcd-xhci-nec.c b/hw/usb/hcd-xhci-nec.c
> index 0c063b3697d..1a191fc7372 100644
> --- a/hw/usb/hcd-xhci-nec.c
> +++ b/hw/usb/hcd-xhci-nec.c
> @@ -30,10 +30,8 @@
>   OBJECT_DECLARE_SIMPLE_TYPE(XHCINecState, NEC_XHCI)
>   
>   struct XHCINecState {
> -    /*< private >*/
>       XHCIPciState parent_obj;
> -    /*< public >*/
> -    uint32_t flags;
> +
>       uint32_t intrs;
>       uint32_t slots;
>   };
> @@ -51,7 +49,6 @@ static void nec_xhci_instance_init(Object *obj)
>       XHCIPciState *pci = XHCI_PCI(obj);
>       XHCINecState *nec = NEC_XHCI(obj);
>   
> -    pci->xhci.flags    = nec->flags;
>       pci->xhci.numintrs = nec->intrs;
>       pci->xhci.numslots = nec->slots;
>   }

Reviewed-by: Thomas Huth <thuth@redhat.com>