[PATCH v3 0/6] virtio-net fixes

Akihiko Odaki posted 6 patches 1 year, 2 months ago
Failed in applying to current master (apply log)
include/net/checksum.h |   2 +-
hw/net/virtio-net.c    | 108 +++++++++++++++++++++++++++----------------------
net/checksum.c         |   4 +-
3 files changed, 63 insertions(+), 51 deletions(-)
[PATCH v3 0/6] virtio-net fixes
Posted by Akihiko Odaki 1 year, 2 months ago
Most of this series are fixes for software RSS and hash reporting, which
should have no production user.

However there is one exception; patch "virtio-net: Fix size check in
dhclient workaround" fixes an out-of-bound access that can be triggered
for anyone who don't use vhost. It has Cc: qemu-stable@nongnu.org and
can be applied independently.

Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
---
Changes in v3:
- Rebased.
- Link to v2: https://lore.kernel.org/r/20241111-queue-v2-0-2f7883a1004f@daynix.com

Changes in v2:
- Dropped patch "virtio-net: Fix num_buffers for version 1" in favor of
  fixing the spec. See:
  https://lore.kernel.org/r/CACGkMEt0spn59oLyoCwcJDdLeYUEibePF7gppxdVX1YvmAr72Q@mail.gmail.com
- Added a Buglink to patch
  "virtio-net: Fix hash reporting when the queue changes".
- Rebased.
- Link to v1: https://lore.kernel.org/r/20240915-queue-v1-0-b49bd49b926d@daynix.com

---
Akihiko Odaki (6):
      net: checksum: Convert data to void *
      virtio-net: Fix size check in dhclient workaround
      virtio-net: Do not check for the queue before RSS
      virtio-net: Fix hash reporting when the queue changes
      virtio-net: Initialize hash reporting values
      virtio-net: Copy received header to buffer

 include/net/checksum.h |   2 +-
 hw/net/virtio-net.c    | 108 +++++++++++++++++++++++++++----------------------
 net/checksum.c         |   4 +-
 3 files changed, 63 insertions(+), 51 deletions(-)
---
base-commit: 34754a3a627e1937be7f3daaa0c5e73d91c7d9b5
change-id: 20240907-queue-f425937a730f

Best regards,
-- 
Akihiko Odaki <akihiko.odaki@daynix.com>
Re: [PATCH v3 0/6] virtio-net fixes
Posted by Lei Yang 1 year, 2 months ago
QE tested this series patches with regression tests, everything works well.

Tested-by: Lei Yang <leiyang@redhat.com>


On Fri, Nov 22, 2024 at 1:04 PM Akihiko Odaki <akihiko.odaki@daynix.com> wrote:
>
> Most of this series are fixes for software RSS and hash reporting, which
> should have no production user.
>
> However there is one exception; patch "virtio-net: Fix size check in
> dhclient workaround" fixes an out-of-bound access that can be triggered
> for anyone who don't use vhost. It has Cc: qemu-stable@nongnu.org and
> can be applied independently.
>
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> ---
> Changes in v3:
> - Rebased.
> - Link to v2: https://lore.kernel.org/r/20241111-queue-v2-0-2f7883a1004f@daynix.com
>
> Changes in v2:
> - Dropped patch "virtio-net: Fix num_buffers for version 1" in favor of
>   fixing the spec. See:
>   https://lore.kernel.org/r/CACGkMEt0spn59oLyoCwcJDdLeYUEibePF7gppxdVX1YvmAr72Q@mail.gmail.com
> - Added a Buglink to patch
>   "virtio-net: Fix hash reporting when the queue changes".
> - Rebased.
> - Link to v1: https://lore.kernel.org/r/20240915-queue-v1-0-b49bd49b926d@daynix.com
>
> ---
> Akihiko Odaki (6):
>       net: checksum: Convert data to void *
>       virtio-net: Fix size check in dhclient workaround
>       virtio-net: Do not check for the queue before RSS
>       virtio-net: Fix hash reporting when the queue changes
>       virtio-net: Initialize hash reporting values
>       virtio-net: Copy received header to buffer
>
>  include/net/checksum.h |   2 +-
>  hw/net/virtio-net.c    | 108 +++++++++++++++++++++++++++----------------------
>  net/checksum.c         |   4 +-
>  3 files changed, 63 insertions(+), 51 deletions(-)
> ---
> base-commit: 34754a3a627e1937be7f3daaa0c5e73d91c7d9b5
> change-id: 20240907-queue-f425937a730f
>
> Best regards,
> --
> Akihiko Odaki <akihiko.odaki@daynix.com>
>
>