[PATCH v2 0/7] Pointer Masking update for Zjpm v1.0

baturo.alexey@gmail.com posted 7 patches 1 year, 2 months ago
Failed in applying to current master (apply log)
There is a newer version of this series
target/riscv/cpu.c                      |  19 +-
target/riscv/cpu.h                      |  51 ++--
target/riscv/cpu_bits.h                 |  91 +-----
target/riscv/cpu_cfg.h                  |   3 +
target/riscv/cpu_helper.c               | 124 +++++---
target/riscv/csr.c                      | 357 ++----------------------
target/riscv/insn_trans/trans_rvh.c.inc |  11 +
target/riscv/machine.c                  |  17 +-
target/riscv/pmp.c                      |  14 +-
target/riscv/pmp.h                      |   1 +
target/riscv/tcg/tcg-cpu.c              |   5 +-
target/riscv/translate.c                |  51 ++--
target/riscv/vector_helper.c            |  18 +-
13 files changed, 224 insertions(+), 538 deletions(-)
[PATCH v2 0/7] Pointer Masking update for Zjpm v1.0
Posted by baturo.alexey@gmail.com 1 year, 2 months ago
From: Alexey Baturo <baturo.alexey@gmail.com>

Hi,

I've rebased this patch series and addressed Richard's and Daniel's comments.
Thanks

*** BLURB HERE ***
[v0]:
As Pointer Masking is finally ratified, these patches intend to update the existing code to the final version.
These patches have been submitted previously and I tried to address all the suggestions, but I'd suggest to review them from the clean slate and then finally push them to the repo.
Thanks.

Alexey Baturo (7):
  target/riscv: Remove obsolete pointer masking extension code.
  target/riscv: Add new CSR fields for S{sn,mn,m}pm extensions as part
    of Zjpm v1.0
  target/riscv: Add helper functions to calculate current number of
    masked bits for pointer masking
  target/riscv: Add pointer masking tb flags
  target/riscv: Update address modify functions to take into account
    pointer masking
  target/riscv: Apply pointer masking for virtualized memory accesses
  target/riscv: Enable updates for pointer masking variables and thus
    enable pointer masking extension

 target/riscv/cpu.c                      |  19 +-
 target/riscv/cpu.h                      |  51 ++--
 target/riscv/cpu_bits.h                 |  91 +-----
 target/riscv/cpu_cfg.h                  |   3 +
 target/riscv/cpu_helper.c               | 124 +++++---
 target/riscv/csr.c                      | 357 ++----------------------
 target/riscv/insn_trans/trans_rvh.c.inc |  11 +
 target/riscv/machine.c                  |  17 +-
 target/riscv/pmp.c                      |  14 +-
 target/riscv/pmp.h                      |   1 +
 target/riscv/tcg/tcg-cpu.c              |   5 +-
 target/riscv/translate.c                |  51 ++--
 target/riscv/vector_helper.c            |  18 +-
 13 files changed, 224 insertions(+), 538 deletions(-)

-- 
2.39.5
Re: [PATCH v2 0/7] Pointer Masking update for Zjpm v1.0
Posted by Daniel Henrique Barboza 1 year, 2 months ago
Hi Alexey,


I believe this is not the second version of this work. When I asked about the
next versions this was already in v9:

https://lore.kernel.org/qemu-riscv/d4241c7b-ae97-4dc1-bc60-5f0eed58d3a5@ventanamicro.com/

And it had most of the patches already reviewed by Alistair and Richard. So this
would be in fact v11, with a lot of patches already reviewed.

If you could re-send this series as v11, keeping reviewed-by tags from code that you
didn't change from one version to the other, the review will go faster.


Thanks,

Daniel

On 11/21/24 3:12 AM, baturo.alexey@gmail.com wrote:
> From: Alexey Baturo <baturo.alexey@gmail.com>
> 
> Hi,
> 
> I've rebased this patch series and addressed Richard's and Daniel's comments.
> Thanks
> 
> *** BLURB HERE ***
> [v0]:
> As Pointer Masking is finally ratified, these patches intend to update the existing code to the final version.
> These patches have been submitted previously and I tried to address all the suggestions, but I'd suggest to review them from the clean slate and then finally push them to the repo.
> Thanks.
> 
> Alexey Baturo (7):
>    target/riscv: Remove obsolete pointer masking extension code.
>    target/riscv: Add new CSR fields for S{sn,mn,m}pm extensions as part
>      of Zjpm v1.0
>    target/riscv: Add helper functions to calculate current number of
>      masked bits for pointer masking
>    target/riscv: Add pointer masking tb flags
>    target/riscv: Update address modify functions to take into account
>      pointer masking
>    target/riscv: Apply pointer masking for virtualized memory accesses
>    target/riscv: Enable updates for pointer masking variables and thus
>      enable pointer masking extension
> 
>   target/riscv/cpu.c                      |  19 +-
>   target/riscv/cpu.h                      |  51 ++--
>   target/riscv/cpu_bits.h                 |  91 +-----
>   target/riscv/cpu_cfg.h                  |   3 +
>   target/riscv/cpu_helper.c               | 124 +++++---
>   target/riscv/csr.c                      | 357 ++----------------------
>   target/riscv/insn_trans/trans_rvh.c.inc |  11 +
>   target/riscv/machine.c                  |  17 +-
>   target/riscv/pmp.c                      |  14 +-
>   target/riscv/pmp.h                      |   1 +
>   target/riscv/tcg/tcg-cpu.c              |   5 +-
>   target/riscv/translate.c                |  51 ++--
>   target/riscv/vector_helper.c            |  18 +-
>   13 files changed, 224 insertions(+), 538 deletions(-)
>
Re: [PATCH v2 0/7] Pointer Masking update for Zjpm v1.0
Posted by Alexey Baturo 1 year, 2 months ago
Hi Daniel,

Thanks for the suggestion. I've resubmitted it with the v11 tag and put
some reviewed-bys.

Thanks

пн, 25 нояб. 2024 г. в 16:37, Daniel Henrique Barboza <
dbarboza@ventanamicro.com>:

> Hi Alexey,
>
>
> I believe this is not the second version of this work. When I asked about
> the
> next versions this was already in v9:
>
>
> https://lore.kernel.org/qemu-riscv/d4241c7b-ae97-4dc1-bc60-5f0eed58d3a5@ventanamicro.com/
>
> And it had most of the patches already reviewed by Alistair and Richard.
> So this
> would be in fact v11, with a lot of patches already reviewed.
>
> If you could re-send this series as v11, keeping reviewed-by tags from
> code that you
> didn't change from one version to the other, the review will go faster.
>
>
> Thanks,
>
> Daniel
>
> On 11/21/24 3:12 AM, baturo.alexey@gmail.com wrote:
> > From: Alexey Baturo <baturo.alexey@gmail.com>
> >
> > Hi,
> >
> > I've rebased this patch series and addressed Richard's and Daniel's
> comments.
> > Thanks
> >
> > *** BLURB HERE ***
> > [v0]:
> > As Pointer Masking is finally ratified, these patches intend to update
> the existing code to the final version.
> > These patches have been submitted previously and I tried to address all
> the suggestions, but I'd suggest to review them from the clean slate and
> then finally push them to the repo.
> > Thanks.
> >
> > Alexey Baturo (7):
> >    target/riscv: Remove obsolete pointer masking extension code.
> >    target/riscv: Add new CSR fields for S{sn,mn,m}pm extensions as part
> >      of Zjpm v1.0
> >    target/riscv: Add helper functions to calculate current number of
> >      masked bits for pointer masking
> >    target/riscv: Add pointer masking tb flags
> >    target/riscv: Update address modify functions to take into account
> >      pointer masking
> >    target/riscv: Apply pointer masking for virtualized memory accesses
> >    target/riscv: Enable updates for pointer masking variables and thus
> >      enable pointer masking extension
> >
> >   target/riscv/cpu.c                      |  19 +-
> >   target/riscv/cpu.h                      |  51 ++--
> >   target/riscv/cpu_bits.h                 |  91 +-----
> >   target/riscv/cpu_cfg.h                  |   3 +
> >   target/riscv/cpu_helper.c               | 124 +++++---
> >   target/riscv/csr.c                      | 357 ++----------------------
> >   target/riscv/insn_trans/trans_rvh.c.inc |  11 +
> >   target/riscv/machine.c                  |  17 +-
> >   target/riscv/pmp.c                      |  14 +-
> >   target/riscv/pmp.h                      |   1 +
> >   target/riscv/tcg/tcg-cpu.c              |   5 +-
> >   target/riscv/translate.c                |  51 ++--
> >   target/riscv/vector_helper.c            |  18 +-
> >   13 files changed, 224 insertions(+), 538 deletions(-)
> >
>
>
Re: [PATCH v2 0/7] Pointer Masking update for Zjpm v1.0
Posted by Alistair Francis 1 year, 2 months ago
On Wed, Nov 27, 2024 at 3:38 PM Alexey Baturo <baturo.alexey@gmail.com> wrote:
>
> Hi Daniel,
>
> Thanks for the suggestion. I've resubmitted it with the v11 tag and put some reviewed-bys.

Thanks! It's a lot of time and effort to review code, so it's helpful
to keep existing tags. Note that it's fine (and you should) to remove
tags if the code has changed

Alistair