[PATCH 04/12] tests: Explicitly create containers in test_qom_partial_path()

Peter Xu posted 12 patches 2 days, 17 hours ago
There is a newer version of this series
[PATCH 04/12] tests: Explicitly create containers in test_qom_partial_path()
Posted by Peter Xu 2 days, 17 hours ago
Drop one use of container_get(), instead switch to the explicit function to
create a container.

Signed-off-by: Peter Xu <peterx@redhat.com>
---
 tests/unit/check-qom-proplist.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/unit/check-qom-proplist.c b/tests/unit/check-qom-proplist.c
index 79d4a8b89d..21b1e167ca 100644
--- a/tests/unit/check-qom-proplist.c
+++ b/tests/unit/check-qom-proplist.c
@@ -610,7 +610,7 @@ static void test_dummy_delchild(void)
 static void test_qom_partial_path(void)
 {
     Object *root  = object_get_objects_root();
-    Object *cont1 = container_get(root, "/cont1");
+    Object *cont1 = container_create(root, "cont1");
     Object *obj1  = object_new(TYPE_DUMMY);
     Object *obj2a = object_new(TYPE_DUMMY);
     Object *obj2b = object_new(TYPE_DUMMY);
-- 
2.45.0
Re: [PATCH 04/12] tests: Explicitly create containers in test_qom_partial_path()
Posted by Daniel P. Berrangé 2 days, 5 hours ago
On Wed, Nov 20, 2024 at 04:56:55PM -0500, Peter Xu wrote:
> Drop one use of container_get(), instead switch to the explicit function to
> create a container.
> 
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
>  tests/unit/check-qom-proplist.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|


Re: [PATCH 04/12] tests: Explicitly create containers in test_qom_partial_path()
Posted by Philippe Mathieu-Daudé 2 days, 6 hours ago
On 20/11/24 22:56, Peter Xu wrote:
> Drop one use of container_get(), instead switch to the explicit function to
> create a container.
> 
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
>   tests/unit/check-qom-proplist.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>