[PULL v2 0/8] Block layer patches

Kevin Wolf posted 8 patches 3 days, 22 hours ago
Only 0 patches received!
There is a newer version of this series
block/parallels.c                |  4 +--
hw/core/qdev-properties-system.c | 54 ++++++++++++++++++++++++++--------------
system/qdev-monitor.c            | 42 ++++++++++++++++++++-----------
system/vl.c                      | 14 +++--------
python/scripts/mkvenv.py         |  3 +++
tests/qemu-iotests/iotests.py    | 11 +++++---
python/setup.cfg                 |  1 +
tests/qemu-iotests/pylintrc      |  1 +
8 files changed, 82 insertions(+), 48 deletions(-)
[PULL v2 0/8] Block layer patches
Posted by Kevin Wolf 3 days, 22 hours ago
The following changes since commit e6459afb1ff4d86b361b14f4a2fc43f0d2b4d679:

  Merge tag 'pull-target-arm-20241119' of https://git.linaro.org/people/pmaydell/qemu-arm into staging (2024-11-19 14:23:34 +0000)

are available in the Git repository at:

  https://repo.or.cz/qemu/kevin.git tags/for-upstream

for you to fetch changes up to c77fc64e67f3f3050ccd487706eb5f1dcc3ec7d5:

  vl: use qmp_device_add() in qemu_create_cli_devices() (2024-11-19 18:23:06 +0100)

----------------------------------------------------------------
Block layer patches

- Fix qmp_device_add() to not throw non-scalar options away (fixes
  iothread-vq-mapping being silently ignored in device_add)
- Fix qdev property crash with integer PCI addresses and JSON -device
- iotests: Fix mypy failure
- parallels: Avoid potential integer overflow
- Fix crash in migration_is_running()

----------------------------------------------------------------
Dmitry Frolov (1):
      parallels: fix possible int overflow

John Snow (4):
      iotests: reflow ReproducibleTestRunner arguments
      iotests: correct resultclass type in ReproducibleTestRunner
      python: disable too-many-positional-arguments warning
      python: silence pylint raising-non-exception error

Kevin Wolf (1):
      qdev: Fix set_pci_devfn() to visit option only once

Stefan Hajnoczi (2):
      qdev-monitor: avoid QemuOpts in QMP device_add
      vl: use qmp_device_add() in qemu_create_cli_devices()

 block/parallels.c                |  4 +--
 hw/core/qdev-properties-system.c | 54 ++++++++++++++++++++++++++--------------
 system/qdev-monitor.c            | 42 ++++++++++++++++++++-----------
 system/vl.c                      | 14 +++--------
 python/scripts/mkvenv.py         |  3 +++
 tests/qemu-iotests/iotests.py    | 11 +++++---
 python/setup.cfg                 |  1 +
 tests/qemu-iotests/pylintrc      |  1 +
 8 files changed, 82 insertions(+), 48 deletions(-)
Re: [PULL v2 0/8] Block layer patches
Posted by Peter Maydell 3 days, 19 hours ago
On Tue, 19 Nov 2024 at 17:28, Kevin Wolf <kwolf@redhat.com> wrote:
>
> The following changes since commit e6459afb1ff4d86b361b14f4a2fc43f0d2b4d679:
>
>   Merge tag 'pull-target-arm-20241119' of https://git.linaro.org/people/pmaydell/qemu-arm into staging (2024-11-19 14:23:34 +0000)
>
> are available in the Git repository at:
>
>   https://repo.or.cz/qemu/kevin.git tags/for-upstream
>
> for you to fetch changes up to c77fc64e67f3f3050ccd487706eb5f1dcc3ec7d5:
>
>   vl: use qmp_device_add() in qemu_create_cli_devices() (2024-11-19 18:23:06 +0100)
>
> ----------------------------------------------------------------
> Block layer patches
>
> - Fix qmp_device_add() to not throw non-scalar options away (fixes
>   iothread-vq-mapping being silently ignored in device_add)
> - Fix qdev property crash with integer PCI addresses and JSON -device
> - iotests: Fix mypy failure
> - parallels: Avoid potential integer overflow
> - Fix crash in migration_is_running()
>
> ----------------------------------------------------------------

Hi; this failed in the build-oss-fuzz test with a lot of
AddressSanitizer leak reports about leaks from an allocation
triggered via set_pci_devfn. Probably they're all the
same thing; here's the first:

Direct leak of 108 byte(s) in 27 object(s) allocated from:
#0 0x559ac9152c1d in calloc
(/builds/qemu-project/qemu/build-oss-fuzz/DEST_DIR/qemu-fuzz-i386-target-generic-fuzz-virtio-9p+0xca8c1d)
(BuildId: 96bfdcd076cb68d4f42f95581b14d11718bed747)
#1 0x7fc4e6bf8871 in g_malloc0 (/lib64/libglib-2.0.so.0+0x64871)
(BuildId: 36b60dbd02e796145a982d0151ce37202ec05649)
#2 0x559aca4773e0 in qobject_input_start_alternate
/builds/qemu-project/qemu/build-oss-fuzz/../qapi/qobject-input-visitor.c:391:12
#3 0x559aca46fa98 in visit_start_alternate
/builds/qemu-project/qemu/build-oss-fuzz/../qapi/qapi-visit-core.c:119:10
#4 0x559ac9343b33 in set_pci_devfn
/builds/qemu-project/qemu/build-oss-fuzz/../hw/core/qdev-properties-system.c:824:10
#5 0x559ac9ff7707 in object_property_init_defval
/builds/qemu-project/qemu/build-oss-fuzz/../qom/object.c:1591:5
#6 0x559ac9feb0f3 in object_class_property_init_all
/builds/qemu-project/qemu/build-oss-fuzz/../qom/object.c:557:13
#7 0x559ac9feb0f3 in object_initialize_with_type
/builds/qemu-project/qemu/build-oss-fuzz/../qom/object.c:573:5
#8 0x559ac9fec69c in object_new_with_type
/builds/qemu-project/qemu/build-oss-fuzz/../qom/object.c:780:5
#9 0x559ac9fec69c in object_new_with_class
/builds/qemu-project/qemu/build-oss-fuzz/../qom/object.c:788:12
#10 0x559ac99cd111 in qemu_get_nic_models
/builds/qemu-project/qemu/build-oss-fuzz/../net/net.c:951:27
#11 0x559ac99cd86f in qemu_create_nic_bus_devices
/builds/qemu-project/qemu/build-oss-fuzz/../net/net.c:1186:29
#12 0x559ac9c032e6 in pc_nic_init
/builds/qemu-project/qemu/build-oss-fuzz/../hw/i386/pc.c:1256:9
#13 0x559ac9bcdeb5 in pc_q35_init
/builds/qemu-project/qemu/build-oss-fuzz/../hw/i386/pc_q35.c:320:5
#14 0x559ac9334b8d in machine_run_board_init
/builds/qemu-project/qemu/build-oss-fuzz/../hw/core/machine.c:1622:5
#15 0x559ac9907a03 in qemu_init_board
/builds/qemu-project/qemu/build-oss-fuzz/../system/vl.c:2629:5
#16 0x559ac9907a03 in qmp_x_exit_preconfig
/builds/qemu-project/qemu/build-oss-fuzz/../system/vl.c:2715:5
#17 0x559ac990da48 in qemu_init
/builds/qemu-project/qemu/build-oss-fuzz/../system/vl.c:3750:9

https://gitlab.com/qemu-project/qemu/-/jobs/8415761320

thanks
-- PMM